diff --git a/src/runmode-af-packet.c b/src/runmode-af-packet.c index 20501d7495..d26df0f710 100644 --- a/src/runmode-af-packet.c +++ b/src/runmode-af-packet.c @@ -280,20 +280,20 @@ static void *ParseAFPConfig(const char *iface) } } - if (ConfGetChildValueBoolWithDefault(if_root, if_default, "use-mmap", (int *)&boolval) == 1) { + if (ConfGetChildValueBoolWithDefault(if_root, if_default, "use-mmap", &boolval) == 1) { if (!boolval) { SCLogWarning( "%s: \"use-mmap\" option is obsolete: mmap is always enabled", aconf->iface); } } - (void)ConfGetChildValueBoolWithDefault(if_root, if_default, "mmap-locked", (int *)&boolval); + (void)ConfGetChildValueBoolWithDefault(if_root, if_default, "mmap-locked", &boolval); if (boolval) { SCLogConfig("%s: enabling locked memory for mmap", aconf->iface); aconf->flags |= AFP_MMAP_LOCKED; } - if (ConfGetChildValueBoolWithDefault(if_root, if_default, "tpacket-v3", (int *)&boolval) == 1) { + if (ConfGetChildValueBoolWithDefault(if_root, if_default, "tpacket-v3", &boolval) == 1) { if (boolval) { if (strcasecmp(RunmodeGetActive(), "workers") == 0) { #ifdef HAVE_TPACKET_V3 @@ -314,8 +314,7 @@ static void *ParseAFPConfig(const char *iface) } } - (void)ConfGetChildValueBoolWithDefault( - if_root, if_default, "use-emergency-flush", (int *)&boolval); + (void)ConfGetChildValueBoolWithDefault(if_root, if_default, "use-emergency-flush", &boolval); if (boolval) { SCLogConfig("%s: using emergency ring flush", aconf->iface); aconf->flags |= AFP_EMERGENCY_MODE; @@ -428,7 +427,7 @@ static void *ParseAFPConfig(const char *iface) #ifdef HAVE_PACKET_EBPF boolval = false; - if (ConfGetChildValueBoolWithDefault(if_root, if_default, "pinned-maps", (int *)&boolval) == 1) { + if (ConfGetChildValueBoolWithDefault(if_root, if_default, "pinned-maps", &boolval) == 1) { if (boolval) { SCLogConfig("%s: using pinned maps", aconf->iface); aconf->ebpf_t_config.flags |= EBPF_PINNED_MAPS; @@ -544,7 +543,8 @@ static void *ParseAFPConfig(const char *iface) } boolval = true; - if (ConfGetChildValueBoolWithDefault(if_root, if_default, "use-percpu-hash", (int *)&boolval) == 1) { + if (ConfGetChildValueBoolWithDefault(if_root, if_default, "use-percpu-hash", &boolval) == + 1) { if (boolval == false) { SCLogConfig("%s: not using percpu hash", aconf->iface); aconf->ebpf_t_config.cpus_count = 1; @@ -621,7 +621,7 @@ static void *ParseAFPConfig(const char *iface) aconf->block_timeout = 10; } - (void)ConfGetChildValueBoolWithDefault(if_root, if_default, "disable-promisc", (int *)&boolval); + (void)ConfGetChildValueBoolWithDefault(if_root, if_default, "disable-promisc", &boolval); if (boolval) { SCLogConfig("%s: disabling promiscuous mode", aconf->iface); aconf->promisc = 0; diff --git a/src/runmode-af-xdp.c b/src/runmode-af-xdp.c index 7c27ee6ba8..8eebfeb89a 100644 --- a/src/runmode-af-xdp.c +++ b/src/runmode-af-xdp.c @@ -161,7 +161,7 @@ static void *ParseAFXDPConfig(const char *iface) ConfNode *af_xdp_node = NULL; int conf_val = 0; intmax_t conf_val_int = 0; - bool boolval = false; + int boolval = 0; if (iface == NULL) { return NULL; @@ -220,7 +220,7 @@ static void *ParseAFXDPConfig(const char *iface) (void)SC_ATOMIC_ADD(aconf->ref, aconf->threads); /* Promisc Mode */ - (void)ConfGetChildValueBoolWithDefault(if_root, if_default, "disable-promisc", (int *)&boolval); + (void)ConfGetChildValueBoolWithDefault(if_root, if_default, "disable-promisc", &boolval); if (boolval) { SCLogConfig("Disabling promiscuous mode on iface %s", aconf->iface); aconf->promisc = 0; diff --git a/src/runmode-netmap.c b/src/runmode-netmap.c index b1771b16c2..26fc2c4546 100644 --- a/src/runmode-netmap.c +++ b/src/runmode-netmap.c @@ -217,7 +217,7 @@ static int ParseNetmapSettings(NetmapIfaceSettings *ns, const char *iface, ConfSetBPFFilter(if_root, if_default, iface, &ns->bpf_filter); int boolval = 0; - (void)ConfGetChildValueBoolWithDefault(if_root, if_default, "disable-promisc", (int *)&boolval); + (void)ConfGetChildValueBoolWithDefault(if_root, if_default, "disable-promisc", &boolval); if (boolval) { SCLogInfo("%s: disabling promiscuous mode", ns->iface); ns->promisc = false; diff --git a/src/source-nfq.c b/src/source-nfq.c index 6a5f9d2074..97964af43d 100644 --- a/src/source-nfq.c +++ b/src/source-nfq.c @@ -227,7 +227,7 @@ void NFQInitConfig(bool quiet) } } - (void)ConfGetBool("nfq.fail-open", (int *)&boolval); + (void)ConfGetBool("nfq.fail-open", &boolval); if (boolval) { #ifdef HAVE_NFQ_SET_QUEUE_FLAGS SCLogInfo("Enabling fail-open on queue");