mqtt: move sub/unsub limits into app-layer config

(cherry picked from commit 3c1cc1e345)

src/detect-mqtt-subscribe-topic.c

@@ -205,7 +205,7 @@ void DetectMQTTSubscribeTopicRegister (void)
     sigmatch_table[DETECT_AL_MQTT_SUBSCRIBE_TOPIC].flags |= SIGMATCH_INFO_STICKY_BUFFER;
 
     intmax_t val = 0;
-    if (ConfGetInt("mqtt.subscribe-topic-match-limit", &val)) {
+    if (ConfGetInt("app-layer.protocols.mqtt.subscribe-topic-match-limit", &val)) {
         subscribe_topic_match_limit = val;
     }
     if (subscribe_topic_match_limit <= 0) {

src/detect-mqtt-unsubscribe-topic.c

@@ -205,7 +205,7 @@ void DetectMQTTUnsubscribeTopicRegister (void)
     sigmatch_table[DETECT_AL_MQTT_UNSUBSCRIBE_TOPIC].flags |= SIGMATCH_INFO_STICKY_BUFFER;
 
     intmax_t val = 0;
-    if (ConfGetInt("mqtt.unsubscribe-topic-match-limit", &val)) {
+    if (ConfGetInt("app-layer.protocols.mqtt.unsubscribe-topic-match-limit", &val)) {
         unsubscribe_topic_match_limit = val;
     }
     if (unsubscribe_topic_match_limit <= 0) {

suricata.yaml.in

@@ -722,6 +722,8 @@ app-layer:
     mqtt:
       # enabled: no
       # max-msg-length: 1mb
+      # subscribe-topic-match-limit: 100
+      # unsubscribe-topic-match-limit: 100
     krb5:
       enabled: yes
     snmp:
@@ -1111,11 +1113,6 @@ pcre:
   match-limit: 3500
   match-limit-recursion: 1500
 
-# MQTT topic detection depth
-#mqtt:
-#  subscribe-topic-match-limit: 100
-#  unsubscribe-topic-match-limit: 100
-
 ##
 ## Advanced Traffic Tracking and Reconstruction Settings
 ##