mirror of https://github.com/OISF/suricata
Fix Coverity 1220098 and 1220099
*** CID 1220098: Missing unlock (LOCK)
/src/log-droplog.c: 195 in LogDropLogNetFilter()
189 SCMutexLock(&dlt->file_ctx->fp_mutex);
190
191 if (dlt->file_ctx->rotation_flag) {
192 dlt->file_ctx->rotation_flag = 0;
193 if (SCConfLogReopen(dlt->file_ctx) != 0) {
194 /* Rotation failed, error already logged. */
>>> CID 1220098: Missing unlock (LOCK)
>>> Returning without unlocking "dlt->file_ctx->fp_mutex".
195 return TM_ECODE_FAILED;
196 }
197 }
198
199 if (dlt->file_ctx == NULL) {
200 return TM_ECODE_FAILED;
*** CID 1220099: Dereference before null check (REVERSE_INULL)
/src/log-droplog.c: 199 in LogDropLogNetFilter()
193 if (SCConfLogReopen(dlt->file_ctx) != 0) {
194 /* Rotation failed, error already logged. */
195 return TM_ECODE_FAILED;
196 }
197 }
198
>>> CID 1220099: Dereference before null check (REVERSE_INULL)
>>> Null-checking "dlt->file_ctx" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
199 if (dlt->file_ctx == NULL) {
200 return TM_ECODE_FAILED;
201 }
202
203 char srcip[46] = "";
204 char dstip[46] = "";
pull/981/head
parent
8a77e6bc8e
commit
2c20c9d409
Loading…
Reference in New Issue