From 14987dca35745caf465eddcaa798feff2b8eb4c6 Mon Sep 17 00:00:00 2001
From: Victor Julien <vjulien@oisf.net>
Date: Wed, 24 Sep 2025 08:12:16 +0200
Subject: [PATCH] detect/datarep: fix format truncation warning
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

detect-datarep.c: In function ‘SetupLoadPath’:
detect-datarep.c:262:9: error: ‘%s’ directive output may be truncated writing likely 1 or more bytes into a region of size between 0 and 4095 [-Werror=format-truncation=]
  262 |     if (snprintf(path, sizeof(path), "%s/%s", dir, load) >= (int)sizeof(path)) // TODO windows path
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
detect-datarep.c:262:9: note: assuming directive output of 1 byte
detect-datarep.c:262:9: note: ‘snprintf’ output 2 or more bytes (assuming 4098) into a destination of size 4096
cc1: all warnings being treated as errors

Ticket: #7905.
---
 src/detect-datarep.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/detect-datarep.c b/src/detect-datarep.c
index 8dd05fd574..4a5e8353e4 100644
--- a/src/detect-datarep.c
+++ b/src/detect-datarep.c
@@ -259,7 +259,7 @@ static int SetupLoadPath(const DetectEngineCtx *de_ctx,
 
     SCLogDebug("rule_file %s dir %s", de_ctx->rule_file, dir);
     char path[PATH_MAX];
-    if (snprintf(path, sizeof(path), "%s/%s", dir, load) >= (int)sizeof(path)) // TODO windows path
+    if (PathMerge(path, sizeof(path), dir, load) < 0)
         return -1;
 
     if (SCPathExists(path)) {