detect/mpm: micro optimization in setup

8 years ago · 0b97fbbc13
parent 4438e34ed9
commit 0b97fbbc13
1 changed files with 2 additions and 2 deletions
--- a/src/detect-engine-mpm.c
+++ b/src/detect-engine-mpm.c
@ -933,6 +933,8 @@ static void MpmStoreSetup(const DetectEngineCtx *de_ctx, MpmStore *ms)
            s = de_ctx->sig_array[sig];
            if (s == NULL)
                continue;
+            if ((s->flags & ms->direction) == 0)
+                continue;
            if (s->init_data->mpm_sm == NULL)
                continue;
            int list = SigMatchListSMBelongsTo(s, s->init_data->mpm_sm);
@ -940,8 +942,6 @@ static void MpmStoreSetup(const DetectEngineCtx *de_ctx, MpmStore *ms)
                continue;
            if (list != ms->sm_list)
                continue;
-            if ((s->flags & ms->direction) == 0)
-                continue;

            SCLogDebug("adding %u", s->id);