From 0ad5a38fb440d423793ed0904dfa85757ea35966 Mon Sep 17 00:00:00 2001 From: Victor Julien Date: Fri, 11 Dec 2020 10:19:41 +0100 Subject: [PATCH] ci: buildbot is decommissioned, so remove prscript refs (cherry picked from commit 372fc26739b414684ad0a7e25f444ceceb379173) --- .github/PULL_REQUEST_TEMPLATE.md | 2 -- doc/devguide/codebase/contributing/code-submission-process.rst | 3 --- 2 files changed, 5 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 3888e480c9..7a203af6a6 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -11,8 +11,6 @@ Describe changes: - - -[PRScript](https://redmine.openinfosecfoundation.org/projects/suricata/wiki/PRscript) output (if applicable): - #suricata-verify-pr: #suricata-verify-repo: #suricata-verify-branch: diff --git a/doc/devguide/codebase/contributing/code-submission-process.rst b/doc/devguide/codebase/contributing/code-submission-process.rst index 8a7a34a34a..87aeb2397a 100644 --- a/doc/devguide/codebase/contributing/code-submission-process.rst +++ b/doc/devguide/codebase/contributing/code-submission-process.rst @@ -37,13 +37,10 @@ A github pull request is actually just a pointer to a branch in your tree. Githu #. Incremental pull requests need to describe changes since the last PR #. Link to the ticket(s) that are addressed to it. #. When fixing an issue, update the issue status to ``In Review`` after submitting the PR. -#. Links to the prscript builds* #. Pull requests are automatically tested using github actions (https://github.com/OISF/suricata/blob/master/.github/workflows/builds.yml). Failing builds won't be considered and should be closed immediately. #. Pull requests that change, or add a feature should include a documentation update commit - (*) access to prscript is limited to trusted devs. For the rest of you, ask Victor, Eric, Andreas or Jason to run it for you. - Tests and QA ~~~~~~~~~~~~