From 053b2b3b5b1197064bba5d59d4731c5789ff7239 Mon Sep 17 00:00:00 2001 From: Victor Julien Date: Tue, 1 Mar 2022 12:43:25 +0100 Subject: [PATCH] detect/address: minor unittest cleanup --- src/detect-engine-address.c | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/src/detect-engine-address.c b/src/detect-engine-address.c index d59893d370..954ebff61d 100644 --- a/src/detect-engine-address.c +++ b/src/detect-engine-address.c @@ -4346,23 +4346,18 @@ static int AddressTestAddressGroupSetup48(void) static int AddressTestCutIPv401(void) { - DetectAddress *a, *b, *c; - a = DetectAddressParseSingle("1.2.3.0/255.255.255.0"); - b = DetectAddressParseSingle("1.2.2.0-1.2.3.4"); + DetectAddress *c; + DetectAddress *a = DetectAddressParseSingle("1.2.3.0/255.255.255.0"); + FAIL_IF_NULL(a); + DetectAddress *b = DetectAddressParseSingle("1.2.2.0-1.2.3.4"); + FAIL_IF_NULL(b); - if (DetectAddressCut(NULL, a, b, &c) == -1) - goto error; + FAIL_IF(DetectAddressCut(NULL, a, b, &c) == -1); DetectAddressFree(a); DetectAddressFree(b); DetectAddressFree(c); - return 1; - -error: - DetectAddressFree(a); - DetectAddressFree(b); - DetectAddressFree(c); - return 0; + PASS; } static int AddressTestCutIPv402(void)