Commit Graph

8 Commits (82a82ec3e7232f9d227484449c3315c04c0c57d7)

Author SHA1 Message Date
Your Name 72e840345e Fix PHPStan 'empty() always exists and is not falsy' errors
- Remove redundant empty() checks where variables are guaranteed to exist and be non-falsy
- Replace empty() with simple null/false checks where appropriate
- Maintain original logic while fixing static analysis issues
- Affected files:
  - app/Http/Controllers/GroupController.php
  - app/Http/Controllers/ProfileAliasController.php
  - app/Jobs/ImageOptimizePipeline/ImageUpdate.php
  - app/Jobs/InboxPipeline/DeleteWorker.php
  - app/Jobs/InboxPipeline/InboxValidator.php
  - app/Jobs/InboxPipeline/InboxWorker.php
  - app/Jobs/ProfilePipeline/HandleUpdateActivity.php
  - app/Rules/ExpoPushTokenRule.php
  - app/Services/AutospamService.php
  - app/Services/CollectionService.php
  - app/Services/NotificationAppGatewayService.php
  - app/Services/WebfingerService.php
  - app/Util/ActivityPub/Helpers.php
2 weeks ago
Your Name 4bbabfffb9 Misc pipelines defensive checks 2 weeks ago
Anil Kulkarni 2f6c6830ea
Fix null dereference error when updating the sharedInbox for actor
updates.

The old code assumes that all update messages have an endpoints key.
However, both the endpoints key, as well as the sharedInbox may be
missing or null per spec. This commit fixes the bug by using isset to
check for the key to exist, otherwise coalescing it to null

server to server update messages are PUT operations, not PATCH,
so if the sharedInbox is missing in the update, it should always be
removed (if previously set)
2 weeks ago
Daniel Supernault 3686c92122
Update Status storage, add SanitizerService to fix spacing in html stripped content 2 months ago
Daniel Supernault 5bea903409
Update HandleUpdateActivity 2 years ago
Daniel Supernault 1bf3ad7ed9
Update HandleUpdateActivity 2 years ago
Daniel Supernault 31afaba3d0
Update ProfilePipeline 2 years ago
Daniel Supernault 29961c4a80
Update ap inbox 2 years ago