mirror of https://github.com/usememos/memos
You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
70 lines
2.6 KiB
TypeScript
70 lines
2.6 KiB
TypeScript
import { isValidElement } from "react";
|
|
import type { RouteObject } from "react-router-dom";
|
|
import { describe, expect, it } from "vitest";
|
|
import { routeConfig, ROUTES } from "@/router";
|
|
import { RequireAuthRoute, RequireGuestRoute } from "@/router/guards";
|
|
|
|
// Walk the nested route config and find the first route with the given path,
|
|
// starting from the provided roots. Returns undefined if nothing matches.
|
|
function findByPath(routes: RouteObject[], path: string): RouteObject | undefined {
|
|
for (const route of routes) {
|
|
if (route.path === path) return route;
|
|
const hit = route.children ? findByPath(route.children, path) : undefined;
|
|
if (hit) return hit;
|
|
}
|
|
return undefined;
|
|
}
|
|
|
|
function elementType(route: RouteObject | undefined): unknown {
|
|
if (!route?.element || !isValidElement(route.element)) return undefined;
|
|
return route.element.type;
|
|
}
|
|
|
|
function hasAncestorOfType(routes: RouteObject[], path: string, guardType: unknown): boolean {
|
|
const walk = (subtree: RouteObject[], ancestorGuards: unknown[]): boolean => {
|
|
for (const route of subtree) {
|
|
const nextAncestors = [...ancestorGuards];
|
|
const type = elementType(route);
|
|
if (type) nextAncestors.push(type);
|
|
if (route.path === path) {
|
|
return nextAncestors.includes(guardType);
|
|
}
|
|
if (route.children && walk(route.children, nextAncestors)) {
|
|
return true;
|
|
}
|
|
}
|
|
return false;
|
|
};
|
|
return walk(routes, []);
|
|
}
|
|
|
|
describe("router configuration", () => {
|
|
it("keeps /auth/callback outside the guest-only guard", () => {
|
|
// Regression guard for issue #5846 follow-up: an authenticated tab elsewhere
|
|
// must not short-circuit the OAuth callback via RequireGuestRoute.
|
|
expect(hasAncestorOfType(routeConfig, "callback", RequireGuestRoute)).toBe(false);
|
|
});
|
|
|
|
it("wraps the remaining /auth children in RequireGuestRoute", () => {
|
|
for (const path of ["", "admin", "signup"]) {
|
|
expect(hasAncestorOfType(routeConfig, path, RequireGuestRoute)).toBe(true);
|
|
}
|
|
});
|
|
|
|
it("wraps authenticated-only pages in RequireAuthRoute", () => {
|
|
for (const path of [ROUTES.ARCHIVED, ROUTES.ATTACHMENTS, ROUTES.INBOX, ROUTES.SETTING]) {
|
|
expect(hasAncestorOfType(routeConfig, path, RequireAuthRoute)).toBe(true);
|
|
}
|
|
});
|
|
|
|
it("leaves public pages outside RequireAuthRoute", () => {
|
|
for (const path of [ROUTES.ABOUT, ROUTES.EXPLORE, "memos/:uid", "memos/shares/:token", "u/:username"]) {
|
|
expect(hasAncestorOfType(routeConfig, path, RequireAuthRoute)).toBe(false);
|
|
}
|
|
});
|
|
|
|
it("exposes an accessible /auth/callback route definition", () => {
|
|
expect(findByPath(routeConfig, "callback")).toBeTruthy();
|
|
});
|
|
});
|