From ed1954c58cab12da799f90d3fe5ab91649206ce8 Mon Sep 17 00:00:00 2001 From: steven Date: Sat, 9 Mar 2024 12:56:44 +0800 Subject: [PATCH] chore: fix check setting value --- server/integration/telegram.go | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/server/integration/telegram.go b/server/integration/telegram.go index 98730d0a..96ba9e71 100644 --- a/server/integration/telegram.go +++ b/server/integration/telegram.go @@ -145,21 +145,21 @@ func (t *TelegramHandler) CallbackQueryHandle(ctx context.Context, bot *telegram return bot.AnswerCallbackQuery(ctx, callbackQuery.ID, fmt.Sprintf("Memo %d not found, possibly deleted elsewhere", memoID)) } - var disablePublicMemo bool setting, err := t.store.GetWorkspaceSetting(ctx, &store.FindWorkspaceSetting{ Name: apiv1.SystemSettingDisablePublicMemosName.String(), }) if err != nil { return bot.AnswerCallbackQuery(ctx, callbackQuery.ID, fmt.Sprintf("Failed to get workspace setting %s", err)) } - - err = json.Unmarshal([]byte(setting.Value), &disablePublicMemo) - if err != nil { - return bot.AnswerCallbackQuery(ctx, callbackQuery.ID, fmt.Sprintf("Failed to get workspace setting %s", err)) - } - - if disablePublicMemo && visibility == store.Public { - return bot.AnswerCallbackQuery(ctx, callbackQuery.ID, fmt.Sprintf("Failed to changing Memo %d to %s\n(workspace disallowed public memo)", memoID, visibility)) + if setting != nil && setting.Value != "" { + disablePublicMemo := false + err = json.Unmarshal([]byte(setting.Value), &disablePublicMemo) + if err != nil { + return bot.AnswerCallbackQuery(ctx, callbackQuery.ID, fmt.Sprintf("Failed to get workspace setting %s", err)) + } + if disablePublicMemo && visibility == store.Public { + return bot.AnswerCallbackQuery(ctx, callbackQuery.ID, fmt.Sprintf("Failed to changing Memo %d to %s\n(workspace disallowed public memo)", memoID, visibility)) + } } update := store.UpdateMemo{