From c87df8791bab44664dfb8b97274312172aa89b50 Mon Sep 17 00:00:00 2001 From: Athurg Gooth Date: Thu, 14 Sep 2023 14:18:29 +0800 Subject: [PATCH] chore: optimize performance of /memo/stats (#2218) Optimize performance of /memo/stats --- api/v1/memo.go | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/api/v1/memo.go b/api/v1/memo.go index 95aeb899..cf1c40d0 100644 --- a/api/v1/memo.go +++ b/api/v1/memo.go @@ -504,18 +504,16 @@ func (s *APIV1Service) GetMemoStats(c echo.Context) error { if err != nil { return echo.NewHTTPError(http.StatusInternalServerError, "Failed to find memo list").SetInternal(err) } - memoResponseList := []*Memo{} - for _, memo := range list { - memoResponse, err := s.convertMemoFromStore(ctx, memo) - if err != nil { - return echo.NewHTTPError(http.StatusInternalServerError, "Failed to compose memo response").SetInternal(err) - } - memoResponseList = append(memoResponseList, memoResponse) - } displayTsList := []int64{} - for _, memo := range memoResponseList { - displayTsList = append(displayTsList, memo.DisplayTs) + if memoDisplayWithUpdatedTs { + for _, memo := range list { + displayTsList = append(displayTsList, memo.CreatedTs) + } + } else { + for _, memo := range list { + displayTsList = append(displayTsList, memo.UpdatedTs) + } } return c.JSON(http.StatusOK, displayTsList) }