From b734d429ec2c69c0395704ff15c57485c6512f4c Mon Sep 17 00:00:00 2001 From: johnnyjoy Date: Mon, 3 Feb 2025 13:08:13 +0800 Subject: [PATCH] chore: fix linter warning --- server/router/api/v1/user_service_shortcuts.go | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/server/router/api/v1/user_service_shortcuts.go b/server/router/api/v1/user_service_shortcuts.go index 37c78bf8..72d0a085 100644 --- a/server/router/api/v1/user_service_shortcuts.go +++ b/server/router/api/v1/user_service_shortcuts.go @@ -80,11 +80,9 @@ func (s *APIV1Service) CreateShortcut(ctx context.Context, request *v1pb.CreateS } if newShortcut.Filter == "" { return nil, status.Errorf(codes.InvalidArgument, "filter is required") - } else { - _, err := filter.Parse(newShortcut.Filter, filter.MemoFilterCELAttributes...) - if err != nil { - return nil, status.Errorf(codes.InvalidArgument, "invalid filter: %v", err) - } + } + if _, err := filter.Parse(newShortcut.Filter, filter.MemoFilterCELAttributes...); err != nil { + return nil, status.Errorf(codes.InvalidArgument, "invalid filter: %v", err) } if request.ValidateOnly { return &v1pb.Shortcut{ @@ -175,12 +173,10 @@ func (s *APIV1Service) UpdateShortcut(ctx context.Context, request *v1pb.UpdateS } else if field == "filter" { if request.Shortcut.GetFilter() == "" { return nil, status.Errorf(codes.InvalidArgument, "filter is required") - } else { - // Validate the filter. - _, err := filter.Parse(request.Shortcut.GetFilter(), filter.MemoFilterCELAttributes...) - if err != nil { - return nil, status.Errorf(codes.InvalidArgument, "invalid filter: %v", err) - } + } + // Validate the filter. + if _, err := filter.Parse(request.Shortcut.GetFilter(), filter.MemoFilterCELAttributes...); err != nil { + return nil, status.Errorf(codes.InvalidArgument, "invalid filter: %v", err) } shortcut.Filter = request.Shortcut.GetFilter() }