From 4499f45b67c9903cce440bafa8d9dd172d566f5e Mon Sep 17 00:00:00 2001
From: Steven <stevenlgtm@gmail.com>
Date: Wed, 8 Nov 2023 21:49:03 +0800
Subject: [PATCH] chore: deprecate daily review offset local setting

---
 .../Settings/PreferencesSection.tsx           | 35 -------------------
 web/src/components/TagList.tsx                |  2 +-
 web/src/pages/DailyReview.tsx                 |  6 ++--
 web/src/store/module/user.ts                  |  1 -
 web/src/types/modules/setting.d.ts            |  1 -
 5 files changed, 3 insertions(+), 42 deletions(-)

diff --git a/web/src/components/Settings/PreferencesSection.tsx b/web/src/components/Settings/PreferencesSection.tsx
index 349a8dd5..4ab9792b 100644
--- a/web/src/components/Settings/PreferencesSection.tsx
+++ b/web/src/components/Settings/PreferencesSection.tsx
@@ -18,8 +18,6 @@ const PreferencesSection = () => {
   const { setting, localSetting } = userStore.state.user as User;
   const [telegramUserId, setTelegramUserId] = useState<string>(setting.telegramUserId);
 
-  const dailyReviewTimeOffsetOptions: number[] = [...Array(24).keys()];
-
   const handleLocaleSelectChange = async (locale: Locale) => {
     await userStore.upsertUserSetting("locale", locale);
     globalStore.setLocale(locale);
@@ -38,10 +36,6 @@ const PreferencesSection = () => {
     userStore.upsertLocalSetting({ ...localSetting, enableDoubleClickEditing: event.target.checked });
   };
 
-  const handleDailyReviewTimeOffsetChanged = (value: number) => {
-    userStore.upsertLocalSetting({ ...localSetting, dailyReviewTimeOffset: value });
-  };
-
   const handleSaveTelegramUserId = async () => {
     try {
       await userStore.upsertUserSetting("telegram-user-id", telegramUserId);
@@ -87,35 +81,6 @@ const PreferencesSection = () => {
           ))}
         </Select>
       </div>
-      <div className="form-label selector">
-        <span className="text-sm break-keep text-ellipsis overflow-hidden">{t("setting.preference-section.daily-review-time-offset")}</span>
-        <span className="w-auto inline-flex">
-          <Select
-            placeholder="hh"
-            className="!min-w-fit"
-            value={localSetting.dailyReviewTimeOffset}
-            onChange={(_, value) => {
-              if (value !== null) {
-                handleDailyReviewTimeOffsetChanged(value);
-              }
-            }}
-            slotProps={{
-              listbox: {
-                sx: {
-                  maxHeight: "15rem",
-                  overflow: "auto",
-                },
-              },
-            }}
-          >
-            {dailyReviewTimeOffsetOptions.map((item) => (
-              <Option key={item} value={item} className="whitespace-nowrap">
-                {item.toString().padStart(2, "0")}
-              </Option>
-            ))}
-          </Select>
-        </span>
-      </div>
 
       <label className="form-label selector">
         <span className="text-sm break-keep">{t("setting.preference-section.enable-double-click")}</span>
diff --git a/web/src/components/TagList.tsx b/web/src/components/TagList.tsx
index 3bf15aaf..bed7313f 100644
--- a/web/src/components/TagList.tsx
+++ b/web/src/components/TagList.tsx
@@ -132,7 +132,7 @@ const TagItemContainer: React.FC<TagItemContainerProps> = (props: TagItemContain
               className={`flex flex-row justify-center items-center w-6 h-6 shrink-0 transition-all rotate-0 ${showSubTags && "rotate-90"}`}
               onClick={handleToggleBtnClick}
             >
-              <Icon.ChevronRight className="w-5 h-5 opacity-80 dark:text-gray-400" />
+              <Icon.ChevronRight className="w-5 h-5 opacity-40 dark:text-gray-400" />
             </span>
           ) : null}
         </div>
diff --git a/web/src/pages/DailyReview.tsx b/web/src/pages/DailyReview.tsx
index 2d48893b..66ff44cc 100644
--- a/web/src/pages/DailyReview.tsx
+++ b/web/src/pages/DailyReview.tsx
@@ -14,23 +14,21 @@ import DatePicker from "@/components/kit/DatePicker";
 import { DAILY_TIMESTAMP, DEFAULT_MEMO_LIMIT } from "@/helpers/consts";
 import { getDateStampByDate, getNormalizedDateString, getTimeStampByDate, getTimeString } from "@/helpers/datetime";
 import useCurrentUser from "@/hooks/useCurrentUser";
-import { useMemoStore, useUserStore } from "@/store/module";
+import { useMemoStore } from "@/store/module";
 import { extractUsernameFromName } from "@/store/v1";
 import { useTranslate } from "@/utils/i18n";
 
 const DailyReview = () => {
   const t = useTranslate();
   const memoStore = useMemoStore();
-  const userStore = useUserStore();
   const user = useCurrentUser();
-  const { localSetting } = userStore.state.user as User;
   const currentDateStamp = getDateStampByDate(getNormalizedDateString()) as number;
   const [selectedDateStamp, setSelectedDateStamp] = useState<number>(currentDateStamp as number);
   const [showDatePicker, toggleShowDatePicker] = useToggle(false);
   const dailyMemos = memoStore.state.memos
     .filter((m) => {
       const displayTimestamp = getTimeStampByDate(m.displayTs);
-      const selectedDateStampWithOffset = selectedDateStamp + localSetting.dailyReviewTimeOffset * 60 * 60 * 1000;
+      const selectedDateStampWithOffset = selectedDateStamp;
       return (
         m.rowStatus === "NORMAL" &&
         m.creatorUsername === extractUsernameFromName(user.name) &&
diff --git a/web/src/store/module/user.ts b/web/src/store/module/user.ts
index 23b28110..f4ad3e3d 100644
--- a/web/src/store/module/user.ts
+++ b/web/src/store/module/user.ts
@@ -15,7 +15,6 @@ const defaultSetting: Setting = {
 
 const defaultLocalSetting: LocalSetting = {
   enableDoubleClickEditing: false,
-  dailyReviewTimeOffset: 0,
 };
 
 export const convertResponseModelUser = (user: User): User => {
diff --git a/web/src/types/modules/setting.d.ts b/web/src/types/modules/setting.d.ts
index 0bd58d1b..02542400 100644
--- a/web/src/types/modules/setting.d.ts
+++ b/web/src/types/modules/setting.d.ts
@@ -13,7 +13,6 @@ interface Setting {
 
 interface LocalSetting {
   enableDoubleClickEditing: boolean;
-  dailyReviewTimeOffset: number;
 }
 
 interface UserLocaleSetting {