From 435bd5c44f6c5d6fc552e346c361852bfef3e300 Mon Sep 17 00:00:00 2001
From: johnnyjoy <yourselfhosted@gmail.com>
Date: Sat, 19 Oct 2024 20:53:53 +0800
Subject: [PATCH] fix: update relation graph checks

---
 web/src/components/MemoDetailSidebar/MemoDetailSidebar.tsx    | 4 +++-
 .../MemoRelationForceGraph/MemoRelationForceGraph.tsx         | 3 ++-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/web/src/components/MemoDetailSidebar/MemoDetailSidebar.tsx b/web/src/components/MemoDetailSidebar/MemoDetailSidebar.tsx
index 3c0dc86e..87f15abf 100644
--- a/web/src/components/MemoDetailSidebar/MemoDetailSidebar.tsx
+++ b/web/src/components/MemoDetailSidebar/MemoDetailSidebar.tsx
@@ -1,6 +1,7 @@
 import clsx from "clsx";
 import { isEqual } from "lodash-es";
 import { CheckCircleIcon, Code2Icon, HashIcon, LinkIcon } from "lucide-react";
+import { MemoRelation_Type } from "@/types/proto/api/v1/memo_relation_service";
 import { Memo, MemoProperty } from "@/types/proto/api/v1/memo_service";
 import { useTranslate } from "@/utils/i18n";
 import MemoRelationForceGraph from "../MemoRelationForceGraph";
@@ -14,6 +15,7 @@ const MemoDetailSidebar = ({ memo, className }: Props) => {
   const t = useTranslate();
   const property = MemoProperty.fromPartial(memo.property || {});
   const hasSpecialProperty = property.hasLink || property.hasTaskList || property.hasCode || property.hasIncompleteTasks;
+  const shouldShowRelationGraph = memo.relations.filter((r) => r.type === MemoRelation_Type.REFERENCE).length > 0;
 
   return (
     <aside
@@ -23,7 +25,7 @@ const MemoDetailSidebar = ({ memo, className }: Props) => {
       )}
     >
       <div className="flex flex-col justify-start items-start w-full px-1 gap-2 h-auto shrink-0 flex-nowrap hide-scrollbar">
-        {memo.relations.length > 0 && (
+        {shouldShowRelationGraph && (
           <div className="relative w-full h-36 border rounded-lg bg-zinc-50 dark:bg-zinc-900 dark:border-zinc-800">
             <MemoRelationForceGraph className="w-full h-full" memo={memo} />
             <span className="absolute top-1 left-2 text-xs opacity-60 font-mono">Relations</span>
diff --git a/web/src/components/MemoRelationForceGraph/MemoRelationForceGraph.tsx b/web/src/components/MemoRelationForceGraph/MemoRelationForceGraph.tsx
index 62c207cb..695cd622 100644
--- a/web/src/components/MemoRelationForceGraph/MemoRelationForceGraph.tsx
+++ b/web/src/components/MemoRelationForceGraph/MemoRelationForceGraph.tsx
@@ -3,6 +3,7 @@ import clsx from "clsx";
 import { useEffect, useRef, useState } from "react";
 import ForceGraph2D, { ForceGraphMethods, LinkObject, NodeObject } from "react-force-graph-2d";
 import useNavigateTo from "@/hooks/useNavigateTo";
+import { MemoRelation_Type } from "@/types/proto/api/v1/memo_relation_service";
 import { Memo } from "@/types/proto/api/v1/memo_service";
 import { LinkType, NodeType } from "./types";
 import { convertMemoRelationsToGraphData } from "./utils";
@@ -44,7 +45,7 @@ const MemoRelationForceGraph = ({ className, memo }: Props) => {
         nodeRelSize={3}
         nodeLabel={(node) => node.memo.uid.slice(0, 6).toLowerCase()}
         linkColor={() => (mode === "light" ? "#e4e4e7" : "#3f3f46")}
-        graphData={convertMemoRelationsToGraphData(memo.relations)}
+        graphData={convertMemoRelationsToGraphData(memo.relations.filter((r) => r.type === MemoRelation_Type.REFERENCE))}
         onNodeClick={onNodeClick}
         linkDirectionalArrowLength={3}
         linkDirectionalArrowRelPos={1}