You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
mastodon/app/controllers/api
Akihiko Odaki ae871c4d46
Make Array-creation behavior of Paginable more predictable (#14687)
* Make Array-creation behavior of Paginable more predictable

Paginable.paginate_by_id usually returns ActiveRecord::Relation, but it
returns an Array if min_id option is present. The behavior caused problems
fixed with the following commits:
- 552e886b64
- b63ede5005
- 64ef37b89d

To prevent from recurring similar problems, this commit introduces two
changes:
- The scope now always returns an Array whether min_id option is present
  or not.
- The scope is renamed to to_a_paginated_by_id to clarify it returns an
  Array.

* Transform Paginable.to_a_paginated_by_id from a scope to a class method

https://api.rubyonrails.org/classes/ActiveRecord/Scoping/Named/ClassMethods.html#method-i-scope
> The method is intended to return an ActiveRecord::Relation object, which
> is composable with other scopes.

Paginable.to_a_paginated_by_id returns an Array and is not appropriate
as a scope.
4 years ago
..
v1 Make Array-creation behavior of Paginable more predictable (#14687) 4 years ago
v2 Change local media attachments to perform heavy processing asynchronously (#13210) 5 years ago
web Remove useless `respond_to` calls (#13208) 5 years ago
base_controller.rb Fix functional user requirements in whitelist mode (#14093) 5 years ago
oembed_controller.rb Fix OEmbed leaking information about existence of non-public statuses (#12930) 5 years ago
proofs_controller.rb Fix proofs API being inaccessible in secure mode (#12495) 5 years ago