You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
mastodon/spec/models
Claire 0a120d86d2
Fix error-prone SQL queries (#15828)
* Fix error-prone SQL queries in Account search

While this code seems to not present an actual vulnerability, one could
easily be introduced by mistake due to how the query is built.

This PR parameterises the `to_tsquery` input to make the query more robust.

* Harden code for Status#tagged_with_all and Status#tagged_with_none

Those two scopes aren't used in a way that could be vulnerable to an SQL
injection, but keeping them unchanged might be a hazard.

* Remove unneeded spaces surrounding tsquery term

* Please CodeClimate

* Move advanced_search_for SQL template to its own function

This avoids one level of indentation while making clearer that the SQL template
isn't build from all the dynamic parameters of advanced_search_for.

* Add tests covering tagged_with, tagged_with_all and tagged_with_none

* Rewrite tagged_with_none to avoid multiple joins and make it more robust

* Remove obsolete brakeman warnings

* Revert "Remove unneeded spaces surrounding tsquery term"

The two queries are not strictly equivalent.

This reverts commit 86f16c537e.
3 years ago
..
admin
concerns Add remove from followers api (#16864) 3 years ago
trends Add trending links (#16917) 3 years ago
web Add `policy` param to `POST /api/v1/push/subscriptions` (#16040) 4 years ago
account_alias_spec.rb
account_conversation_spec.rb
account_deletion_request_spec.rb
account_domain_block_spec.rb
account_filter_spec.rb Add batch suspend for accounts in admin UI (#17009) 3 years ago
account_migration_spec.rb
account_moderation_note_spec.rb
account_spec.rb Fix error when suspending user with an already-existing canonical email block (#17036) 3 years ago
account_statuses_cleanup_policy_spec.rb Allow keeping only 1 boosts/favs on auto deleting posts (#16653) 3 years ago
announcement_mute_spec.rb
announcement_reaction_spec.rb
announcement_spec.rb
backup_spec.rb
block_spec.rb
canonical_email_block_spec.rb Add canonical e-mail blocks for suspended accounts (#16049) 4 years ago
conversation_mute_spec.rb
conversation_spec.rb
custom_emoji_category_spec.rb
custom_emoji_filter_spec.rb
custom_emoji_spec.rb
custom_filter_spec.rb
device_spec.rb
domain_allow_spec.rb
domain_block_spec.rb
email_domain_block_spec.rb
encrypted_message_spec.rb
export_spec.rb
favourite_spec.rb
featured_tag_spec.rb
follow_recommendation_suppression_spec.rb
follow_request_spec.rb Fix edge case where accepted follow cannot be processed because of follow limit (#16098) 4 years ago
follow_spec.rb
home_feed_spec.rb
identity_spec.rb
import_spec.rb
invite_spec.rb
ip_block_spec.rb
list_account_spec.rb
list_spec.rb
login_activity_spec.rb Add authentication history (#16408) 4 years ago
marker_spec.rb
media_attachment_spec.rb Fix error when rendering public pages with media attachments (#16763) 3 years ago
mention_spec.rb
mute_spec.rb
notification_spec.rb
one_time_key_spec.rb
poll_spec.rb
poll_vote_spec.rb
preview_card_spec.rb
public_feed_spec.rb
relationship_filter_spec.rb
relay_spec.rb
remote_follow_spec.rb
report_filter_spec.rb
report_spec.rb Add notifications for statuses deleted by moderators (#17204) 3 years ago
rule_spec.rb
scheduled_status_spec.rb
session_activation_spec.rb Add Ruby 3.0 support (#16046) 4 years ago
setting_spec.rb
site_upload_spec.rb
status_edit_spec.rb Add support for editing for published statuses (#16697) 3 years ago
status_pin_spec.rb Add support for private pinned posts (#16954) 3 years ago
status_spec.rb Fix error-prone SQL queries (#15828) 3 years ago
status_stat_spec.rb
system_key_spec.rb
tag_feed_spec.rb Fix typo in tag_feed_spec.rb (#16466) 4 years ago
tag_spec.rb Improve tag search query (#16104) 4 years ago
unavailable_domain_spec.rb
user_invite_request_spec.rb
user_spec.rb Add ability to skip sign-in token authentication for specific users (#16427) 4 years ago
webauthn_credentials_spec.rb