mirror of https://github.com/mastodon/mastodon
You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
693c66dfde
The intent of the previous concatenation was to minimize object
allocations, which can end up being a slow killer. However, it turns
out that under MRI 2.4.x, the shove-strings-in-an-array-and-join method
is not only arguably more common but (in this particular case) actually
allocates *fewer* objects than the string concatenation.
Or, at least, that's what I gather by running this:
words = %w(palmettoes nudged hibernation bullish stockade's tightened Hades
Dixie's formalize superego's commissaries Zappa's viceroy's apothecaries
tablespoonful's barons Chennai tollgate ticked expands)
a = Account.first
KeywordMute.transaction do
words.each { |w| KeywordMute.create!(keyword: w, account: a) }
GC.start
s1 = GC.stat
re = String.new.tap do |str|
scoped = KeywordMute.where(account: a)
keywords = scoped.select(:id, :keyword)
count = scoped.count
keywords.find_each.with_index do |kw, index|
str << Regexp.escape(kw.keyword.strip)
str << '|' if index < count - 1
end
end
s2 = GC.stat
puts s1.inspect, s2.inspect
raise ActiveRecord::Rollback
end
vs this:
words = %w( palmettoes nudged hibernation bullish stockade's tightened Hades Dixie's
formalize superego's commissaries Zappa's viceroy's apothecaries tablespoonful's
barons Chennai tollgate ticked expands
)
a = Account.first
KeywordMute.transaction do
words.each { |w| KeywordMute.create!(keyword: w, account: a) }
GC.start
s1 = GC.stat
re = [].tap do |arr|
KeywordMute.where(account: a).select(:keyword, :id).find_each do |m|
arr << Regexp.escape(m.keyword.strip)
end
end.join('|')
s2 = GC.stat
puts s1.inspect, s2.inspect
raise ActiveRecord::Rollback
end
Using rails r, here is a comparison of the total_allocated_objects and
malloc_increase_bytes GC stat data:
total_allocated_objects malloc_increase_bytes
string concat 3200241 -> 3201428 (+1187) 1176 -> 45216 (44040)
array join 3200380 -> 3201299 (+919) 1176 -> 36448 (35272)
|
8 years ago | |
|---|---|---|
| app | 8 years ago | |
| bin | 9 years ago | |
| config | 8 years ago | |
| db | 8 years ago | |
| docs | 9 years ago | |
| lib | 8 years ago | |
| log | ||
| nanobox | 9 years ago | |
| public | 8 years ago | |
| spec | 8 years ago | |
| streaming | 8 years ago | |
| vendor/assets | ||
| .babelrc | 9 years ago | |
| .buildpacks | 9 years ago | |
| .codeclimate.yml | 9 years ago | |
| .dockerignore | 9 years ago | |
| .editorconfig | 9 years ago | |
| .env.nanobox | 9 years ago | |
| .env.production.sample | 9 years ago | |
| .env.test | 9 years ago | |
| .env.vagrant | ||
| .eslintignore | ||
| .eslintrc.yml | 8 years ago | |
| .foreman | 9 years ago | |
| .gitattributes | 9 years ago | |
| .gitignore | 8 years ago | |
| .haml-lint.yml | 9 years ago | |
| .nanoignore | 9 years ago | |
| .nvmrc | 9 years ago | |
| .postcssrc.yml | 9 years ago | |
| .profile | 9 years ago | |
| .rspec | ||
| .rubocop.yml | 9 years ago | |
| .ruby-version | 9 years ago | |
| .scss-lint.yml | 9 years ago | |
| .slugignore | 9 years ago | |
| .travis.yml | 8 years ago | |
| .yarnclean | 9 years ago | |
| Aptfile | 9 years ago | |
| CODEOWNERS | 8 years ago | |
| CONTRIBUTING.md | 9 years ago | |
| Capfile | 9 years ago | |
| Dockerfile | 9 years ago | |
| Gemfile | 9 years ago | |
| Gemfile.lock | 8 years ago | |
| ISSUE_TEMPLATE.md | 9 years ago | |
| LICENSE | ||
| Procfile | 9 years ago | |
| Procfile.dev | 9 years ago | |
| README.md | 9 years ago | |
| Rakefile | ||
| Vagrantfile | 9 years ago | |
| app.json | 9 years ago | |
| boxfile.yml | 9 years ago | |
| config.ru | ||
| docker-compose.yml | 9 years ago | |
| docker_entrypoint.sh | 9 years ago | |
| jest.config.js | 8 years ago | |
| package.json | 8 years ago | |
| scalingo.json | 9 years ago | |
| yarn.lock | 8 years ago | |
README.md
Mastodon Glitch Edition
Now with automated deploys!
So here's the deal: we all work on this code, and then it runs on dev.glitch.social and anyone who uses that does so absolutely at their own risk. can you dig it?
- You can view documentation for this project at glitch-soc.github.io/docs/.
- And contributing guidelines are available here and here.