85 Commits (dc253ea234d86c3c3360898058261efbfea6f2ed)

Author	SHA1	Message	Date
Matt Jankowski	d1e08bd38c	Handle nil and blank cases in Account finders (#3500)	8 years ago
Matt Jankowski	2cc3111a77	Expand spec coverage and refactor the `Account.find_` methods (#3485) ... * Move specs for account finder methods to concern spec * Move account finder methods to concern * Improve spec wording * Use more explicit comparison to ensure correct return value * Add coverage for .find_local! and .find_remote! * Add some methods to the finder * Use arel on matching_username method * Avoid ternary in matching domain method * Simplify finder methods * Use an AccountFinder class to simplify lookup	8 years ago
Akihiko Odaki	7db98aa70e	Refactor User and spec (#3431) ... * Protect send_devise_notification of User * Improve spec for User	8 years ago
Jack Jennings	3a2003ba86	Extract authorization policy for viewing statuses (#3150)	8 years ago
Akihiko Odaki	bf575a1f5e	Introduce recent to Follow (#3247) ... Introduce recent to Follow, as Account and other models have. This change also adds specs for the scope and the dependents.	8 years ago
Matt Jankowski	e1b42e9aa0	Add coverage for ReportFilter and AccountFilter (#3236)	8 years ago
Matt Jankowski	8f4b7c1820	Filter languages with opt out (#3175) ... * Remove allowed_languages and add filtered_languages * Use filtered_languages instead of allowed_languages	8 years ago
Eugen Rochko	d3be2b582a	More tests for public timeline method (#3171)	8 years ago
Eugen Rochko	620d0d8029	Account domain blocks (#2381) ... * Add <ostatus:conversation /> tag to Atom input/output Only uses ref attribute (not href) because href would be the alternate link that's always included also. Creates new conversation for every non-reply status. Carries over conversation for every reply. Keeps remote URIs verbatim, generates local URIs on the fly like the rest of them. * Conversation muting - prevents notifications that reference a conversation (including replies, favourites, reblogs) from being created. API endpoints /api/v1/statuses/:id/mute and /api/v1/statuses/:id/unmute Currently no way to tell when a status/conversation is muted, so the web UI only has a "disable notifications" button, doesn't work as a toggle * Display "Dismiss notifications" on all statuses in notifications column, not just own * Add "muted" as a boolean attribute on statuses JSON For now always false on contained reblogs, since it's only relevant for statuses returned from the notifications endpoint, which are not nested Remove "Disable notifications" from detailed status view, since it's only relevant in the notifications column * Up max class length * Remove pending test for conversation mute * Add tests, clean up * Rename to "mute conversation" and "unmute conversation" * Raise validation error when trying to mute/unmute status without conversation * Adding account domain blocks that filter notifications and public timelines * Add tests for domain blocks in notifications, public timelines Filter reblogs of blocked domains from home * Add API for listing and creating account domain blocks * API for creating/deleting domain blocks, tests for Status#ancestors and Status#descendants, filter domain blocks from them * Filter domains in streaming API * Update account_domain_block_spec.rb	8 years ago
alpaca-tc	682b68438e	Improve Account#triadic_closures (#3079)	8 years ago
alpaca-tc	a2a2af244c	Optimize Status#permitted_for 24x (#3069) ... * Build query with arel node * Add spec for current Status#permitted_for implementation * Refactor status.rb * Order by visibility to optimize query	8 years ago
Eugen Rochko	d0dd9eb5b5	Feature conversations muting (#3017) ... * Add <ostatus:conversation /> tag to Atom input/output Only uses ref attribute (not href) because href would be the alternate link that's always included also. Creates new conversation for every non-reply status. Carries over conversation for every reply. Keeps remote URIs verbatim, generates local URIs on the fly like the rest of them. * Conversation muting - prevents notifications that reference a conversation (including replies, favourites, reblogs) from being created. API endpoints /api/v1/statuses/:id/mute and /api/v1/statuses/:id/unmute Currently no way to tell when a status/conversation is muted, so the web UI only has a "disable notifications" button, doesn't work as a toggle * Display "Dismiss notifications" on all statuses in notifications column, not just own * Add "muted" as a boolean attribute on statuses JSON For now always false on contained reblogs, since it's only relevant for statuses returned from the notifications endpoint, which are not nested Remove "Disable notifications" from detailed status view, since it's only relevant in the notifications column * Up max class length * Remove pending test for conversation mute * Add tests, clean up * Rename to "mute conversation" and "unmute conversation" * Raise validation error when trying to mute/unmute status without conversation	8 years ago
alpaca-tc	e9810cbad6	Fixes NoMethodError: undefined method 'first' for nil:NilClass (#3036)	8 years ago
Eugen Rochko	5abdc77c80	Add conversation model, <ostatus:conversation /> (#3016) ... * Add <ostatus:conversation /> tag to Atom input/output Only uses ref attribute (not href) because href would be the alternate link that's always included also. Creates new conversation for every non-reply status. Carries over conversation for every reply. Keeps remote URIs verbatim, generates local URIs on the fly like the rest of them. * Fix conversation migration * More spec coverage for status before_create * Prevent n+1 query when generating Atom with the new conversations * Improve code style * Remove redundant local variable	8 years ago
Jack Jennings	2d000e9c4e	Add specs for current Status#permitted? implementation (#2982)	8 years ago
Matt Jankowski	bba537a7be	Improve allowed language handling (#2897) ... * Dont allow empty value in user allowed languages * Sanitize language input to reject blank values in array	8 years ago
Matt Jankowski	3f5b994ff0	Stream entry specs and refactor to use delegate (#2827) ... * Add coverage for stream entry delegated methods * Use delegate with allow_nil to clean up stream entry	8 years ago
Matt Jankowski	484c9709b6	Misc spec coverage improvements (#2821) ... * Dont use raise_error by itself (avoids warning) * Add coverage for AccountFilter * Improve coverage and refactor for Subscription#lease_seconds * Improve coverage and refactor for NotificationMailer * Simplify assignment of min/max threshold on subscription	8 years ago
masarakki	d08f1112d5	use Twitter::Extractor for creating links (#2502)	8 years ago
Kaylee	7880671f35	Add option to disable two factor auth in admin accounts panel. (#2584) ... * Add option to disable two factor auth in admin accounts panel. Closes #2578 * Add @mjankowski's suggestions. * Moves destroy actions behind User#disable_two_factor! * Adds spec coverage for Admin:TwoFactorAuthenticationsController and User#disable_two_factor!	8 years ago
Yamagishi Kazutoshi	6f75c8451d	Fix subscription expiration condition (#2715) ... * Fix subscription expiration condition * dry and add spec	8 years ago
Matt Jankowski	f025cc6782	Filter on allowed user language preferences (#2361) ... * Naive approached to timeline filtering * Convert allowed_languages into a db column * Allow users to choose languages to see statuses in * Style list items as two columns * Add a hint to explain language filtering preference	8 years ago
Matt Jankowski	5259319cf5	Reports spec for media attachments, clean up method (#2660) ... * Add coverage for Report#media_attachments * Direct query on media attachment	8 years ago
Akihiko Odaki	a6788662b0	Revert "Use PostgreSQL inheritance for blocks and mutes (#2520)" (#2634) ... This reverts commit 5135d609b7.	8 years ago
Akihiko Odaki	5135d609b7	Use PostgreSQL inheritance for blocks and mutes (#2520)	8 years ago
Joël Quenneville	27301312a6	Add tests to the Feed model (#2594) ... This adds a test for the `Feed#get` method. While the data transformations in `Feed#get` may seem redundant, they are important to maintain the order from Redis. The tests I wrote will fail if someone tries to refactor away this "redundancy" (as I tried to do in the first iteration of this change).	8 years ago
Matt Jankowski	effb08edbb	More status specs (#2564) ... * Add rough outline of coverage needed for public timeline * Specs for visibility, replies, boosts * Specs for silenced account * Specs for local_only option * Specs for blocks and mutes * Add tentative spec around including other silenced account statuses * Add with_public_visibility scope * Add simple coverage for tag_timeline * Tag timeline includes replies * Replace tag.statuses with a tagged_with scope in tag timeline method * Use with_public_visibility in tag timeline * Extract common scope between public and tag timelines to method * Extract local domain check to local_only scope * Extract local_only check to starting scope method * Move list of excluded from timeline account ids to account model * Simplify excluded accounts list on account model * Only join accounts when needed * Rename method for account specific filtering * Extract method for account exclusions * Fix bug where silenced accounts were not including statuses from other silenced accounts * DRY up filter application from account or no account * timeline_scope can be private * Add spec showing that account can find its excluded accounts ids * Add spec which fails if local_only does not have a left outer join * rubocop	8 years ago
Matt Jankowski	affd75936e	Add spec for Status.as_home_timeline (#2451)	8 years ago
Francis Chong	193dddb433	Add media dimensions (#2448) ... * Fixes #1985 - add migration AddMediaAttachmentMeta, which add meta field to media_attachments - before saving attachment, set file meta if needed - add meta in api * add spec * align the “size” format for image and video * fix code climate * fixes media_attachment_spec.rb	8 years ago
Guillaume Lo Re	7177e37b99	Stricter whitelist rules (#2213) ... * Stricter whitelist rules * Linting * Added spec for blacklisting * Test subdomain blacklist on domain whitelist * No need to split * Change spec name	8 years ago
Eugen	338df98ddf	Add more FeedManager#filter? tests (#2413)	8 years ago
Ash Furrow	723f25a999	Admin UI for confirming users (#2245) ... * Shows confirmed status in list. * Adds ability to confirm users in admin UI. * Added new english translations. * Addresses feedback from #2245. * More feedback.	8 years ago
Matt Jankowski	ee0c897bba	User settings mutation (#2270) ... * Add user spec for settings, highlight global default mutation issue * Fix mutation issue caused by settings/preferences spec	8 years ago
Eugen	2e4afccd9d	Fix #2108 - Fix gif uploads (#2171) ... * Fix #2108 - Fix gif uploads Add specs for media attachment gifv conversion * Add ffmpeg to travis * Make travis install ffmpeg, not libav * Switch travis to trusty	8 years ago
Matt Jankowski	55e1503522	Instances list in admin (#2095) ... * Add admin/instances index action * Add link to instances admin page * View lists instances * Instances, grouped by domain, ordered by count * Use Account.remote scope * Extract method: Account.by_domain_accounts	8 years ago
Matt Jankowski	66d8f99a30	Admin reports with accounts (#2092) ... * Add a ReportFilter class * Add reports and targeted_reports relationships to Account * Use ReportFilter from admin/reports controller * Link to admin/reports filtered views from admin account show view * Add indexes to reports.account_id and reports.target_account_id	8 years ago
Matt Jankowski	16d50f60d1	Remove unused methods (#1730) ... * Remove unused method #set_counters_maps from api controller * Remove unused method #set_account_counters_maps from api controller * Remove unused method Account#followers_domains * Remove unused User.prolific scope * Add mastodon:users:admins task to list all admin emails * Use interpolated query style in Account.triadic_closures * Coverage for Account.triadic_closures	8 years ago
Patrick Figel	df4ff9a8e1	Add recovery code support for two-factor auth (#1773) ... * Add recovery code support for two-factor auth When users enable two-factor auth, the app now generates ten single-use recovery codes. Users are encouraged to print the codes and store them in a safe place. The two-factor prompt during login now accepts both OTP codes and recovery codes. The two-factor settings UI allows users to regenerated lost recovery codes. Users who have set up two-factor auth prior to this feature being added can use it to generate recovery codes for the first time. Fixes #563 and fixes #987 * Set OTP_SECRET in test enviroment * add missing .html to view file names	8 years ago
Matt Jankowski	8b74aa4217	Admin reports controller improvements (#1714) ... * Simplify admin/reports controller filtering for index * Rename parameter to resolved * Fix issue where reports view could not access filter_link_to * Add coverage for admin/reports controller * DRY up resolution of related reports for target account * Clean up admin/reports routes * Add Report#statuses method * DRY up current account action taken params * Rubocop styles	8 years ago
Matt Jankowski	4fe5e04ea4	Fix csv export coverage in export spec (#1691)	8 years ago
Matt Jankowski	3a9eb81a80	Admin accounts controller cleanup (#1664) ... * Remove unused account_params method in admin/accounts controller * Introduce AccountFilter to find accounts * Use AccountFilter in admin/accounts controller * Use more restful routes admin silence and suspension area * Add admin/silences and admin/suspensions controllers	8 years ago
Matt Jankowski	f24daa399b	Remove pending specs for methods that dont exist (#1658) ... * Remote spec for non-existent entry_classes helper method This method no longer exists, and is handled by a local variable in a partial instead. * Remove spec for non-existent Account#ping! method	8 years ago
Matt Jankowski	3ddd936b03	Refactor exports controller (#1567) ... * Add basic coverage for settings/exports controller * Remove unused @account variable from settings/exports controller * Add coverage for download export actions * Remove deprecated `render :text` in favor of `send_data` for csv downloads * Add model to handle exports * Use Export class in settings/exports controller * Simplify settings/exports controller methods * Move settings/export to more restful routes	8 years ago
Eugen	12f72e1740	When avatar/header are GIF, generate static versions (#1428) ... * When avatar/header are GIF, generate static versions. Account API returns "avatar"/"avatar_static", "header"/"header_static" Static version is the same as original for other cases Web UI de-animates avatars in toots, lists of users Fix #441, fix #596, prerequisite for #1064 * Fix JS test * Add rake task to generate static avatars/headers from GIF ones, add test	8 years ago
Matt Jankowski	0687ab8ae3	Clean up generation of account webfinger string (#1477) ... * Consolidate webfinger string creation under Account#to_webfinger_s * Introduce Account#local_username_and_domain for consolidation	8 years ago
Matt Jankowski	388ec0d5b6	Search cleanup (#1333) ... * Clean up SQL output in Tag and Account search methods * Add basic coverage for Tag.search_for * Add coverage for Account.search_for * Add coverage for Account.advanced_search_for	8 years ago
Eugen	32748c0f71	Merge pull request #1184 from thoughtbot/extract-proper-status ... DRY up reblog vs original status check	8 years ago
Joël Quenneville	4fdeac21f4	Implement pending specs on Status ... Implement the two pending specs on `Status`: `reblogs_count` and `favourites_count`.	8 years ago
Joël Quenneville	d4c94fa004	DRY up reblog vs original status check ... Checking reblog vs original status was happening in multiple places across the app. For views, this logic was encapsulated in a helper method named `proper_status` but in the other layers of the app, the logic was duplicated. Because the logic is used at all layers of the app, we extracted it into a `Status#proper` method on the model and changed all uses of the logic to use this method. There is now a single source of truth for this condition. We added test coverage to untested methods that got refactored.	8 years ago
Eugen Rochko	667ffafef8	Fix spec	8 years ago