mastodon

Commit Graph

Author	SHA1	Message	Date
Nick Schonning	597767a9f7	Autofix Rubocop Rails/RedundantForeignKey (#23731 )	2 years ago
Nick Schonning	2177daeae9	Autofix Rubocop Style/RedundantBegin (#23703 )	2 years ago
Nick Schonning	ab7816a414	Autofix Rubocop Style/Lambda (#23696 )	2 years ago
Nick Schonning	e2a3ebb271	Autofix Rubocop Style/IfUnlessModifier (#23697 )	2 years ago
Nick Schonning	a6f77aa28a	Autofix Rubocop Lint/AmbiguousOperatorPrecedence (#23681 )	2 years ago
Nick Schonning	669f6d2c0a	Run rubocop formatting except line length (#23632 )	2 years ago
Aaron Patterson	fb8503e861	Upgrade to Ruby 3.2 (#22928 ) Co-authored-by: Matthew Ford <matt@bitzesty.com>	2 years ago
Claire	a9c220242b	Fix admin-set follow recommandations being case-sensitive (#23500 ) Fixes #23472	2 years ago
Claire	67de888bad	Fix server status URL being a required server setting (#23499 )	2 years ago
Nick Schonning	0592937264	Apply Rubocop Rails/WhereNot (#23448 ) * Apply Rubocop Rails/WhereNot * Update spec for where.not	2 years ago
Nick Schonning	0d1f192c54	Apply Rubocop Performance/BlockGivenWithExplicitBlock (#23441 ) * Apply Rubocop Performance/BlockGivenWithExplicitBlock * Unprefix used block parameter	2 years ago
Nick Schonning	f68bb52556	Apply Rubocop Style/NegatedIfElseCondition (#23451 )	2 years ago
Nick Schonning	8c1b65c7dd	Apply Rubocop Style/RedundantAssignment (#23452 )	2 years ago
Nick Schonning	cec005068f	Apply Rubocop Performance/RedundantBlockCall (#23440 )	2 years ago
Nick Schonning	ed570050c6	Autofix Rails/EagerEvaluationLogMessage (#23429 ) * Autofix Rails/EagerEvaluationLogMessage * Update spec for debug block syntax	2 years ago
Eugen Rochko	8f590b0a21	Add setting for status page URL (#23390 )	2 years ago
Claire	13a2abacc8	Add `roles` attribute to Account entities in REST API (#23255 )	2 years ago
Claire	6883fddb19	Fix account activation being triggered before email confirmation (#23245 ) * Add tests * Fix account activation being triggered before email confirmation Fixes #23098	2 years ago
Jeong Arm	a1abda39dd	Fix Account Strike causing PG not null validation error (#23178 )	2 years ago
Claire	3970a6f433	Add option to make the landing page be /about even when trends are enabled (#20808 ) * Add option to make the landing page be /about even when trends are enabled * Restablish /explore as landing page by default	2 years ago
Claire	343e1fe8e9	Add confirmation screen when handling reports (#22375 ) * Add confirmation screen on moderation actions * Add flash notice when a report has been processed * Refactor tests * Add tests	2 years ago
Claire	d1387579b9	Fix situations in which instance actor can be set to a Mastodon-incompatible name (#22307 ) * Validate internal actor * Use “internal.actor” by default for the server actor username * Fix instance actor username on the fly if it includes ':' * Change actor name from internal.actor to mastodon.internal	2 years ago
Claire	fcc4c9b34a	Change domain block CSV parsing to be more robust and handle more lists (#21470 ) * Change domain block CSV parsing to be more robust and handle more lists * Add some tests * Improve domain block import validation and reporting	2 years ago
David Freedman	ff70e50199	Don't crash on unobtainable avatars (#22462 )	2 years ago
Claire	21a1a8ee88	Fix crash when marking statuses as sensitive while some statuses are deleted (#22134 ) * Do not offer to mark statuses as sensitive if there is no undeleted status with media attachments * Fix crash when marking statuses as sensitive while some statuses are deleted Fixes #21910 * Fix multiple strikes being created for a single report when selecting “Mark as sensitive” * Add tests	2 years ago
Kaspar V	ae62e5fa53	Fix/remove calling private method with send in model (#22951 ) * fix(status): remove send usage for private unlink_from_conversations - make unlink_from_conversations public method - rename unlink_from_conversations to unlink_from_conversations! - fix send call on private method in statuses_vacuum and batched_remove_status_service * fix(feeds_vacuum): replace find_in_batches with in_batches because active record query results should be a little more efficient than itterating with map and each. Postgres can grasp such lists of ids much quicker than ruby can. Will probably make allmost no difference, but cannot hurt either.	2 years ago
Darius Kazemi	264655c53a	Fix account search not returning followed accounts first (#22956 ) * Make autosuggest for mentions return followed accounts first This makes it so that (when elasticsearch is disabled) when a user types '@foo' in the compose box, they are first going to get accounts they follow ordered by the ranking algorithm, and then second they will get accounts they do not follow, also ordered by the ranking algorithm. This makes behavior more consistent with user expectation and also with results when elasticsearch is enabled. * Fix ranking order to correct direction * One more fixup per @gargron suggestion * Tweak to ranking to no longer include following modifier	2 years ago
Claire	acec1fb745	Fix site upload validations (#22479 ) * Fix site settings media upload handling of DimensionsValidationError Fixes #22234 * Fix underlying validations not being performed for site uploads	2 years ago
Claire	3654c94583	Strip spaces around URL when adding a relay (#22655 ) * Strip spaces around URL when adding a relay Fixes #22650 * Gracefuly handle URL parsing errors in URL validator	2 years ago
Alexander Ivanov	8eb29741b4	Add webhook `account.approved` (#22938 ) * Webhook `account.approved` when preparing new user * Update Webhook.EVENTS	2 years ago
Partho Ghosh	115ab2869b	Fix ・ detection in hashtag regex to construct hashtag correctly (#22888 ) * Fix ・ detection in hashtag regex to construct hashtag correctly * Fixed rubocop liniting issues * More rubocop linting fix	2 years ago
Claire	70415714f1	Add follow request banner on account header (#20785 ) * Add requested_by to relationship maps * Display whether an account has requested to follow you on their profile	2 years ago
Claire	2644a28cb3	Change remote media files to be downloaded outside of transactions (#21796 )	2 years ago
Jeong Arm	3656a6b9cc	Add "disabled" user filter for admin/accounts UI (#21282 )	2 years ago
Jeong Arm	d412147d02	Save avatar or header correctly even if other one fails (#18465 ) * Save avatar or header correctly if other one fails * Fix test	2 years ago
Francis Murillo	5fb1c3e934	Revoke all authorized applications on password reset (#21325 ) * Clear sessions on password change * Rename User::clear_sessions to revoke_access for a clearer meaning * Add reset paassword controller test * Use User.find instead of User.find_for_authentication for reset password test * Use redirect and render for better test meaning in reset password Co-authored-by: Effy Elden <effy@effy.space>	2 years ago
Claire	ed07f10ca8	Fix failure when “Require a reason to join” is set with open registrations (#22127 )	2 years ago
Claire	b59fb28e90	Fix 500 error when trying to migrate to an invalid address (#21462 ) * Fix 500 error when trying to migrate to an invalid address * Add tests	2 years ago
Claire	c8849d6cee	Fix unbounded recursion in account discovery (#22025 ) * Fix trying to fetch posts from other users when fetching featured posts * Rate-limit discovery of new subdomains * Put a limit on recursively discovering new accounts	2 years ago
Claire	69137f4a90	Fix irreversible and whole_word parameters handling in /api/v1/filters (#21988 ) Fixes #21965	2 years ago
Claire	57b893d505	Fix spaces not being stripped in admin account search (#21324 ) Fixes #21058 Regression from #18641	2 years ago
Kaspar V	47f0d7021e	refactor(vacuum statuses): reduce amount of db queries and load for each query - improve performance (#21487 ) * refactor(statuses_vacuum): remove dead code - unused Method is not called inside class and private. Clean up dead code. * refactor(statuses_vacuum): make retention_period present test explicit This private method only hides functionality. It is best practice to be as explicit as possible. * refactor(statuses_vacuum): improve query performance - fix statuses_scope having sub-select for Account.remote scope by `joins(:account).merge(Account.remote)` - fix statuses_scope unnecessary use of `Status.arel_table[:id].lt` because it is inexplicit, bad practice and even slower than normal `.where('statuses.id < ?'` - fix statuses_scope remove select(:id, :visibility) for having reusable active record query batches (no re queries) - fix vacuum_statuses! to use in_batches instead of find_in_batches, because in_batches delivers a full blown active record query result, in stead of an array - no requeries necessary - send(:unlink_from_conversations) not to perform another db query, but reuse the in_batches result instead. - remove now obsolete remove_from_account_conversations method - remove_from_search_index uses array of ids, instead of mapping the ids from an array - this should be more efficient - use the in_batches scope to call delete_all, instead of running another db query for this - because it is again more efficient - add TODO comment for calling models private method with send * refactor(status): simplify unlink_from_conversations - add `has_many through:` relation mentioned_accounts - use model scope local instead of method call `Status#local?` - more readable add account to inbox_owners when account.local? * refactor(status): searchable_by way less sub selects These queries all included a sub-select. Doing the same with a joins should be more efficient. Since this method does 5 such queries, this should be significant, since it technically halves the query count. This is how it was: ```ruby [3] pry(main)> Status.first.mentions.where(account: Account.local, silent: false).explain Status Load (1.6ms) SELECT "statuses".* FROM "statuses" WHERE "statuses"."deleted_at" IS NULL ORDER BY "statuses"."id" DESC LIMIT $1 [["LIMIT", 1]] Mention Load (1.5ms) SELECT "mentions".* FROM "mentions" WHERE "mentions"."status_id" = $1 AND "mentions"."account_id" IN (SELECT "accounts"."id" FROM "accounts" WHERE "accounts"."domain" IS NULL) AND "mentions"."silent" = $2 [["status_id", 109382923142288414], ["silent", false]] => EXPLAIN for: SELECT "mentions".* FROM "mentions" WHERE "mentions"."status_id" = $1 AND "mentions"."account_id" IN (SELECT "accounts"."id" FROM "accounts" WHERE "accounts"."domain" IS NULL) AND "mentions"."silent" = $2 [["status_id", 109382923142288414], ["silent", false]] QUERY PLAN ------------------------------------------------------------------------------------------------------------------ Nested Loop (cost=0.15..23.08 rows=1 width=41) -> Seq Scan on accounts (cost=0.00..10.90 rows=1 width=8) Filter: (domain IS NULL) -> Index Scan using index_mentions_on_account_id_and_status_id on mentions (cost=0.15..8.17 rows=1 width=41) Index Cond: ((account_id = accounts.id) AND (status_id = '109382923142288414'::bigint)) Filter: (NOT silent) (6 rows) ``` This is how it is with this change: ```ruby [4] pry(main)> Status.first.mentions.joins(:account).merge(Account.local).active.explain Status Load (1.7ms) SELECT "statuses".* FROM "statuses" WHERE "statuses"."deleted_at" IS NULL ORDER BY "statuses"."id" DESC LIMIT $1 [["LIMIT", 1]] Mention Load (0.7ms) SELECT "mentions".* FROM "mentions" INNER JOIN "accounts" ON "accounts"."id" = "mentions"."account_id" WHERE "mentions"."status_id" = $1 AND "accounts"."domain" IS NULL AND "mentions"."silent" = $2 [["status_id", 109382923142288414], ["silent", false]] => EXPLAIN for: SELECT "mentions".* FROM "mentions" INNER JOIN "accounts" ON "accounts"."id" = "mentions"."account_id" WHERE "mentions"."status_id" = $1 AND "accounts"."domain" IS NULL AND "mentions"."silent" = $2 [["status_id", 109382923142288414], ["silent", false]] QUERY PLAN ------------------------------------------------------------------------------------------------------------------ Nested Loop (cost=0.15..23.08 rows=1 width=41) -> Seq Scan on accounts (cost=0.00..10.90 rows=1 width=8) Filter: (domain IS NULL) -> Index Scan using index_mentions_on_account_id_and_status_id on mentions (cost=0.15..8.17 rows=1 width=41) Index Cond: ((account_id = accounts.id) AND (status_id = '109382923142288414'::bigint)) Filter: (NOT silent) (6 rows) ```	2 years ago
afontenot	f17fc5742e	Clear voter count when poll is reset (#21700 ) When a poll is edited, we reset the poll and remove all previous votes. However, prior to this commit, the voter count on the poll was not reset. This leads to incorrect percentages being shown in poll results. Fixes #21696	2 years ago
Skyler Hawthorne	5b2ff8d32d	fix media uploads with ffmpeg 5 (#21191 )	2 years ago
David Leadbeater	69378eac99	Don't allow URLs that contain non-normalized paths to be verified (#20999 ) * Don't allow URLs that contain non-normalized paths to be verified This stops things like https://example.com/otheruser/../realuser where "/otheruser" appears to be the verified URL, but the actual URL being verified is "/realuser" due to the "/../". Also fix a test to use 'https', so it is testing the right thing, now that since #20304 https is required. * missing do	2 years ago
lenore gilbert	c373148b3d	Support for import/export of instance-level domain blocks/allows for 4.x w/ additional fixes (#20597 ) * Allow import/export of instance-level domain blocks/allows (#1754) * Allow import/export of instance-level domain blocks/allows. Fixes #15095 * Pacify circleci * Address simple code review feedback * Add headers to exported CSV * Extract common import/export functionality to AdminExportControllerConcern * Add additional fields to instance-blocked domain export * Address review feedback * Split instance domain block/allow import/export into separate pages/controllers * Address code review feedback * Pacify DeepSource * Work around Paperclip::HasAttachmentFile for Rails 6 * Fix deprecated API warning in export tests * Remove after_commit workaround (cherry picked from commit `94e98864e3`) * Add confirmation page when importing blocked domains (#1773) * Move glitch-soc-specific strings to glitch-soc-specific locale files * Add confirmation page when importing blocked domains (cherry picked from commit `b91196f4b7`) * Fix authorization check in domain blocks controller (cherry picked from commit `7527937758`) * Fix error strings for domain blocks and email-domain blocks Corrected issue with non-error message used for Mastodon:NotPermittedError in Domain Blocks Corrected issue Domain Blocks using the Email Domain Blocks message on ActionContoller::ParameterMissing Corrected issue with Email Domain Blocks using the not_permitted string from "custom emojii's" * Ran i18n-tasks normalize to address test failure * Removed unused admin.export_domain_blocks.not_permitted string Removing unused string as indicated by Check i18n * Fix tests (cherry picked from commit `9094c2f52c`) * Fix domain block export not exporting blocks with only media rejection (cherry picked from commit `26ff48ee48`) * Fix various issues with domain block import - stop using Paperclip for processing domain allow/block imports - stop leaving temporary files - better error handling - assume CSV files are UTF-8-encoded (cherry picked from commit cad824d8f501b95377e4f0a957e5a00d517a1902) Co-authored-by: Levi Bard <taktaktaktaktaktaktaktaktaktak@gmail.com> Co-authored-by: Claire <claire.github-309c@sitedethib.com>	2 years ago
Claire	00b2720ef0	Change automatic post deletion configuration to be accessible to redirected users (#20774 ) Fixes #20550	2 years ago
Claire	0cc77263fc	Change batch account suspension to create a strike (#20897 )	2 years ago
Eugen Rochko	552d69ad96	Fix error when invalid domain name is submitted (#19474 ) Fix #19175	2 years ago
Eugen Rochko	b31afc6294	Fix error when passing unknown filter param in REST API (#20626 ) Fix #19156	2 years ago

1 2 3 4 5 ...

1326 Commits (dbc6d7b276aa1ccc085f76caa43cc091311af6b7)