210 Commits (d9ae3db8d5543cf0b7fa44186c191c9bb2472d23)

Author	SHA1	Message	Date
Claire	0b36e3419d	Fix processing of remote Delete activities (#16084) ... * Add tests * Ensure deleted statuses are marked as such * Save some redis memory by not storing URIs in delete_upon_arrival values * Avoid possible race condition when processing incoming Deletes * Avoid potential duplicate Delete forwards * Lower lock durations to reduce issues in case of hard crash of the Rails process * Check for `lock.aquired?` and improve comment * Refactor RedisLock usage in app/lib/activitypub * Fix using incorrect or non-existent sender for relaying Deletes	4 years ago
Eugen Rochko	dde8739020	Fix reports of already suspended accounts being recorded (#16047)	4 years ago
Eugen Rochko	619fad6cf8	Remove spam check and dependency on nilsimsa gem (#16011)	4 years ago
Claire	1c4dee4554	Fix Mastodon not understanding as:Public and Public (#15948) ... Fixes #5551	4 years ago
Claire	be3b9f8151	Fix URI of repeat follow requests not being recorded (#15662) ... * Fix URI of repeat follow requests not being recorded In case we receive a “repeat” or “duplicate” follow request, we automatically fast-forward the accept with the latest received Activity `id`, but we don't record it. In general, a “repeat” or “duplicate” follow request may happen if for some reason (e.g. inconsistent handling of Block or Undo Accept activities, an instance being brought back up from the dead, etc.) the local instance thought the remote actor were following them while the remote actor thought otherwise. In those cases, the remote instance does not know about the older Follow activity `id`, so keeping that record serves no purpose, but knowing the most recent one is useful if the remote implementation at some point refers to it by `id` without inlining it. * Add tests	4 years ago
ThibG	a044ddac5b	Fix race conditions on account migration creation (#15597) ... * Atomically check for processing lock in Move handler * Prevent race condition when creating account migrations Fixes #15595 * Add tests Co-authored-by: Claire <claire.github-309c@sitedethib.com>	4 years ago
ThibG	7bed25f3ea	Fix processing of incoming Block activities (#15546) ... Unlike locally-issued blocks, they weren't clearing follow relationships in both directions, follow requests or notifications. Co-authored-by: Claire <claire.github-309c@sitedethib.com>	4 years ago
luigi	087ed84367	Optimize map { ... }.compact calls (#15513) ... * Optimize map { ... }.compact using Enumerable#filter_map, supported since Ruby 2.7 * Add poyfill for Enumerable#filter_map	4 years ago
Eugen Rochko	1045549f85	Add stoplight for object storage failures, return HTTP 503 (#13043)	4 years ago
ThibG	2f6831f318	Fix sending spurious Rejects when processing remote account deletion (#15104) ... * Fix sending spurious Rejects when processing remote account deletion * Make skip_side_effects imply skip_activitypub	4 years ago
ThibG	b0893291ef	Fix Move handler not being triggered when failing to fetch target (#15107) ... When failing to fetch the target account, the ProcessingWorker fails as expected, but since it hasn't cleared the `move_in_progress` flag, the next attempt at processing skips the `Move` activity altogether. This commit changes it to clear the flag when encountering any unexpected error on fetching the target account. This is likely to occur because, of, e.g., a timeout, when many instances query the same actor at the same time.	4 years ago
Eugen Rochko	3134691948	Add support for reversible suspensions through ActivityPub (#14989)	4 years ago
Takeshi Umeda	d6fe0c94ca	Add account sensitized (#14361) ... * Add account sensitized * Fix i18n normalize * Fix description and spec * Fix spec * Fix wording	4 years ago
ThibG	ca56527140	Add follower synchronization mechanism (#14510) ... * Add support for followers synchronization on the receiving end Check the `collectionSynchronization` attribute on `Create` and `Announce` activities and synchronize followers from provided collection if possible. * Add tests for followers synchronization on the receiving end * Add support for follower synchronization on the sender's end * Add tests for the sending end * Switch from AS attributes to HTTP header Replace the custom `collectionSynchronization` ActivityStreams attribute by an HTTP header (`X-AS-Collection-Synchronization`) with the same syntax as the `Signature` header and the following fields: - `collectionId` to specify which collection to synchronize - `digest` for the SHA256 hex-digest of the list of followers known on the receiving instance (where “receiving instance” is determined by accounts sharing the same host name for their ActivityPub actor `id`) - `url` of a collection that should be fetched by the instance actor Internally, move away from the webfinger-based `domain` attribute and use account `uri` prefix to group accounts. * Add environment variable to disable followers synchronization Since the whole mechanism relies on some new preconditions that, in some extremely rare cases, might not be met, add an environment variable (DISABLE_FOLLOWERS_SYNCHRONIZATION) to disable the mechanism altogether and avoid followers being incorrectly removed. The current conditions are: 1. all managed accounts' actor `id` and inbox URL have the same URI scheme and netloc. 2. all accounts whose actor `id` or inbox URL share the same URI scheme and netloc as a managed account must be managed by the same Mastodon instance as well. As far as Mastodon is concerned, breaking those preconditions require extensive configuration changes in the reverse proxy and might also cause other issues. Therefore, this environment variable provides a way out for people with highly unusual configurations, and can be safely ignored for the overwhelming majority of Mastodon administrators. * Only set follower synchronization header on non-public statuses This is to avoid unnecessary computations and allow Follow-related activities to be handled by the usual codepath instead of going through the synchronization mechanism (otherwise, any Follow/Undo/Accept activity would trigger the synchronization mechanism even if processing the activity itself would be enough to re-introduce synchronization) * Change how ActivityPub::SynchronizeFollowersService handles follow requests If the remote lists a local follower which we only know has sent a follow request, consider the follow request as accepted instead of sending an Undo. * Integrate review feeback - rename X-AS-Collection-Synchronization to Collection-Synchronization - various minor refactoring and code style changes * Only select required fields when computing followers_hash * Use actor URI rather than webfinger domain in synchronization endpoint * Change hash computation to be a XOR of individual hashes Makes it much easier to be memory-efficient, and avoid sorting discrepancy issues. * Marginally improve followers_hash computation speed * Further improve hash computation performances by using pluck_each	4 years ago
Takeshi Umeda	b4c4af18dc	Fix a bear check when the activity object is nil (#14981)	4 years ago
Eugen Rochko	974b1b79ce	Add option to be notified when a followed user posts (#13546) ... * Add bell button Fix #4890 * Remove duplicate type from post-deployment migration * Fix legacy class type mappings * Improve query performance with better index * Fix validation * Remove redundant index from notifications	5 years ago
Eugen Rochko	ed099d8bdc	Change account suspensions to be reversible by default (#14726)	5 years ago
Eugen Rochko	17340365bb	Add featured hashtags as an ActivityPub collection (#11595)	5 years ago
dependabot[bot]	8972e5f7f6	Bump rubocop from 0.86.0 to 0.88.0 (#14412) ... * Bump rubocop from 0.86.0 to 0.88.0 Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.86.0 to 0.88.0. - [Release notes](https://github.com/rubocop-hq/rubocop/releases) - [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md) - [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.86.0...v0.88.0) Signed-off-by: dependabot[bot] <support@github.com> * Fix for latest RuboCop Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh>	5 years ago
Eugen Rochko	52157fdcba	Add support for dereferencing objects through bearcaps (#14683)	5 years ago
ThibG	92319d7340	Fix dereferencing remote statuses not using the correct account (#14656) ... Follow-up to #14359 In the case of limited toots, the receiver may not be explicitly part of the audience. If a specific user's inbox URI was specified, it makes sense to dereference the toot from the corresponding user, instead of trying to find someone in the explicit audience.	5 years ago
ThibG	720214feb0	Add support for inlined objects in activity audience (#14514) ... * Add support for inlined objects in activity audience * Add tests	5 years ago
ThibG	bfd5aea206	Fix handling of Reject Follow when a matching follow relationship exists (#14479) ... * Add tests * Fix handling of Reject Follow when a matching follow relationship exists Regression from #12199	5 years ago
ThibG	5d9acc0ce4	Fix not handling Undo on some activity types when they aren't inlined (#14346) ... * Fix not handling Undo on some activity types when they aren't inlined When receiving an Undo for a non-inlined activity, try looking it up in database using the URI. The queries are ad-hoc because we don't have a global index of object URIs, and not all activity types are stored in database with an index on their URI. Announces are just statuses, and have an index on URIs, so this check can be done efficiently. Accepts cannot be handled at all because we don't record their URI at any point. Follows don't have an index on URI, but they have an index on the issuing account, which should make such queries largely manageable. Likes don't have an index on URI, they have an index on the issuing account, but the number of favs per account may be very high, so I decided not to handle that. Blocks don't have an index on URI, but they have an index on the issuing account, which should make such queries largely manageable. In all cases, if an Undo could not be handled properly, we call `delete_later!` because that does not require us to know more than the URI of the undone property. * Add tests * Make newer blocks overwrite older ones Allows re-synchronizing block info by re-blocking and un-blocking again when the original Undo Block has been lost.	5 years ago
ThibG	bcf85b5208	Dereference object URIs in Create and Update messages (#14359) ... * Dereference object URIs in Create and Update messages Fixes #14353 Signed-off-by: Thibaut Girka <thib@sitedethib.com> * Refactor, and perform origin check *before* attempting to fetch object Co-authored-by: Fire Demon <firedemon@creature.cafe>	5 years ago
Takeshi Umeda	fcb3f259e5	Fix to add RedisLock to handle Announce activity (#14365)	5 years ago
Takeshi Umeda	5c23ec2fa6	Improve group processing (#14279) ... * Fix the local group's followers collection * Fix to accept followed relayed_through_account * Add local delivery to the group's followers * Fix code style * Revert "Add local delivery to the group's followers" This reverts commit 3237effc19.	5 years ago
abcang	6a96af4d20	Fix rubocop warning (#14288) ... * Fix rubocop warning * use limit variable * use ContextCreatingMethods option	5 years ago
Eugen Rochko	6d23d40420	Change Redis#exists calls to Redis#exists? to avoid deprecation warning (#14191)	5 years ago
Eugen Rochko	64aac30733	Add customizable thumbnails for audio and video attachments (#14145) ... - Change audio files to not be stripped of metadata - Automatically extract cover art from audio if it exists - Add `thumbnail` parameter to `POST /api/v1/media`, `POST /api/v2/media` and `PUT /api/v1/media/:id` - Add `icon` to represent it in attachments in ActivityPub - Fix `preview_url` containing URL of missing missing image when there is no thumbnail instead of null - Fix duration of audio not being displayed on public pages until the file is loaded	5 years ago
Eugen Rochko	5d8398c8b8	Add E2EE API (#13820)	5 years ago
ThibG	a319c1e60f	Add support for `summary` field for media description (#13763)	5 years ago
Eugen Rochko	0c8945e5ff	Change `tootctl media remove-orphans` to work for all classes (#13316) ... Change `tootctl media lookup` to not use an interactive prompt	5 years ago
Daigo 3 Dango	206dfd7dad	Clarify keyword arguments with ** (#12769) ... This change is to suppress the warning below on on ruby-2.7.0: - warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/	5 years ago
ThibG	2ee5a9d9c3	Clean up OStatus-related codepaths (#12173) ... * Remove “protocol” argument and return value, as only ActivityPub is supported * Remove FetchRemoteAccountService, only use ActivityPub::FetchRemoteAccountService * Fix tests	5 years ago
ThibG	da2143b308	Fixes featured hashtag setting page erroring out instead of rejecting invalid tags (#12436) ... * Revert "Fix ignoring whole status because of one invalid hashtag (#11621)" This reverts commit dff46b260b. * Fix statuses being rejected because of invalid hashtag names * Add spec for invalid hashtag names in statuses * Add test for featured tags controller	5 years ago
Thomas Citharel	8094955461	Add Event activity-type support (#12637) ... This adds support for Event AP type in Mastodon. Events are converted into toots by taking their title (AS name) and their URL (AP ID). Event picture is also brought in if available. Testable by fetching event content from https://test.mobilizon.org Signed-off-by: Thomas Citharel <tcit@tcit.fr>	5 years ago
Takeshi Umeda	f43f1e0184	Add basic support for group actors (#12071) ... * Show badge on group actor in WebUI * Do not notify in case of by following group actor * If you mention group actor, also mention group actor followers * Relax characters that can be used in username (same as Application) * Revert "Relax characters that can be used in username (same as Application)" This reverts commit 7e10a137b8. * Delete display_name method	5 years ago
Yamagishi Kazutoshi	6be16d02cb	Update ESLint and RuboCop in Code Climate (#12534)	5 years ago
ThibG	f05b0463db	Fallback to Create audience when object has no defined audience (#12249) ... Fixes #11137	5 years ago
ThibG	e37358b3bc	Fix code referencing wrong class (#12263) ... For some reason, I have seen this only triggered here: https://circleci.com/gh/tootsuite/mastodon/98324?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link But Follow.find_by referenced the ActivityPub::Activity::Follow class instead of the model class.	5 years ago
puckipedia	d2919f7e94	Allow Accept/Reject with a non-embedded object (#12199) ... Some ActivityPub servers refuse to embed remote objects into their own output. This is because they are not the authoritative source for these objects, and as such embedding them is always a waste of space. The follow request and follow models contain a URI, so this can be used to match them.	5 years ago
ThibG	3babf8464b	Add voters count support (#11917) ... * Add voters count to polls * Add ActivityPub serialization and parsing of voters count * Add support for voters count in WebUI * Move incrementation of voters count out of redis lock * Reword “voters” to “people”	6 years ago
Eugen Rochko	368a87755b	Fix account migration not affecting followers on origin server (#11980)	6 years ago
ThibG	18b451c0e6	Change silences to always require approval on follow (#11975) ... * Change silenced accounts to require approval on follow * Also require approval for follows by people explicitly muted by target accounts * Do not auto-accept silenced or muted accounts when switching from locked to unlocked * Add `follow_requests_count` to verify_credentials * Show “Follow requests” menu item if needed even if account is locked * Add tests * Correctly reflect that follow requests weren't auto-accepted when local account is silenced * Accept follow requests from user-muted accounts to avoid leaking mutes	6 years ago
Eugen Rochko	4f6af87906	Change spam check to apply to local accounts and add a threshold (#11806) ... Instead of detecting spam on first duplicate message, add a threshold of 5 such messages to reduce false positives	6 years ago
Eugen Rochko	38dc51b2d6	Fix Move handler queuing jobs that will fail if account is suspended (#11864) ... Don't put Move handler on cooldown if it didn't run. Skip unmerging from timelines to save unnecessary work.	6 years ago
Eugen Rochko	c5d37f18cb	Change deletes to preserve soft-deleted statuses in unresolved reports (#11805) ... Change all account actions except "none" to resolve all unresolved reports Refactor `SuspendAccountService` to be more readable	6 years ago
Eugen Rochko	031ca25014	Add retry for failed media downloads and `tootctl media refresh` (#11775)	6 years ago
ThibG	692c5b439a	Fix ActivityPub context not being dynamically computed (#11746) ... * Fix contexts not being dynamically included Fixes #11649 * Refactor Note context in serializer * Refactor Actor serializer	6 years ago