245 Commits (d3b67461735f9a1c38a7eee655a8131bcf6a0cbf)

Author	SHA1	Message	Date
Matt Jankowski	f0634ba876	Coverage improvement and concern extraction for rate limit headers in API controller (#3625) ... * Coverage for rate limit headers * Move rate limit headers methods to concern * Move throttle check to condition on before_action * Move match_data variable into method * Move utc timestamp to separate method * Move header setting into smaller methods * specs cleanup	8 years ago
Daigo 3 Dango	2985d08951	Redirect to streaming_api_base_url (#3579) ... * Redirect to streaming_api_base_url When Rails receives a request to streaming API, it most likely means that there is another host which is configured to respond to it. This is to redirect clients to that host if `STREAMING_API_BASE_URL` is set as another host. * Use the new Ruby 1.9 hash syntax	8 years ago
Yamagishi Kazutoshi	e878ddb7c0	Fix spec for #2388 (#3526)	8 years ago
Akihiko Odaki (@fn_aki@pawoo.net)	10768aa204	Spec response for forgery (#3248) ... Remove protect_from_forgery in ApiController, which is disabled by the following skip_before_action, as well.	8 years ago
Matt Jankowski	5c63523972	Spec coverage and refactor for the api/v1/accounts controllers (#3451)	8 years ago
Matt Jankowski	de4681b2be	Move admin/pubsubhubbub controller to admin/subscriptions (#3442)	8 years ago
Matt Jankowski	5236a62861	Improve spec coverage and clean up api/v1/blocks controller (#3464)	8 years ago
Matt Jankowski	0f155829b7	Improve spec coverage and clean up api/v1/follow_requests controller (#3465)	8 years ago
Matt Jankowski	84dda45df9	Improve spec coverage and clean up api/v1/domain_blocks controller (#3466)	8 years ago
Matt Jankowski	75cad1d9d6	Improve spec coverage and clean up api/v1/favourites controller (#3472)	8 years ago
Matt Jankowski	bf811e4d4a	Improve spec coverage and clean up api/v1/mutes controller (#3481)	8 years ago
Yamagishi Kazutoshi	41fa53253c	Keep ENV['LOCAL_HTTPS'] with ApplicationControllerSpec (fix random fail) (#3479) ... * Keep ENV['LOCAL_HTTPS'] with ApplicationControllerSpec (fix random fail) * use climate_control	8 years ago
Matt Jankowski	8235623362	Improve spec coverage and clean up api/v1/media controller (#3467)	8 years ago
Matt Jankowski	83435c49ea	Clean up api/subscriptions controller (#3448)	8 years ago
Matt Jankowski	3576fa0d59	Improve api oembed controller (#3450) ... * Add StreamEntryFinder class to parse URLs * Use StreamEntryFinder and clean up api/oembed controller	8 years ago
Matt Jankowski	1dcfb90202	Clean up api/salmon controller (#3449)	8 years ago
Matt Jankowski	0ebe7d6d23	Remove exports/base controller in favor of shared concern (#3444)	8 years ago
Akihiko Odaki	67bc58dd60	Use around hook to restore context in Admin::SettingsController spec (#3428)	8 years ago
Jack Jennings	3a2003ba86	Extract authorization policy for viewing statuses (#3150)	8 years ago
Akihiko Odaki	922fb74197	Remove methods from ObfuscateFilename and spec (#3347) ... * Remove methods from ObfuscateFilename * Spec ObfuscateFilename	8 years ago
Akihiko Odaki	7bf2d6cb06	Spec Auth::ConfirmationsController (#3348)	8 years ago
Akihiko Odaki	11e5c965c3	Spec AccountControllerConcern (#3349)	8 years ago
Akihiko Odaki	34157d118c	Cover Admin::ReportsController more (#3346)	8 years ago
Akihiko Odaki	7b92950f1c	Cover InstancesController more (#3342)	8 years ago
Akihiko Odaki	97d7028c31	Cover Admin::SuspensionsController more (#3350)	8 years ago
Akihiko Odaki	a7f2961621	Spec Auth::PasswordsController (#3352)	8 years ago
Akihiko Odaki	00dda99789	Spec Admin::ResetsController calls send_reset_password_instructions (#3354)	8 years ago
Akihiko Odaki	2e27ce3b61	Spec #destroy feature of Admin::TwoFactorAuthenticationsController (#3355)	8 years ago
Akihiko Odaki	2c10c5a069	Coever Admin::SilencesController more (#3356)	8 years ago
Akihiko Odaki	bd4dd4c4a0	Cover Settings::ExportsController more (#3358)	8 years ago
Akihiko Odaki	7d33b60f3f	Cover Oauth::AuthorizedApplicationsController (#3359)	8 years ago
Akihiko Odaki	aecce5694b	Cover Oauth::AuthorizationsController more (#3361)	8 years ago
Akihiko Odaki	0e4ca51951	Cover Settings::TwoFactorAuthenticationsController more (#3376)	8 years ago
Akihiko Odaki	dde043f6cd	Cover WellKnown::HostMetaController more (#3382)	8 years ago
Akihiko Odaki	c778a60e4f	Cover Settings::TwoFactorAuthentication::RecoveryCodesController more (#3383)	8 years ago
Akihiko Odaki	c347327d54	Spec Settings::Exports (#3384) ... * Spec output of Settings::Exports::BlockedAccountsController * Spec output of Settings::Exports::FollowingAccountsController * Spec output of Settings::Exports::MutedAccountsController * Spec Settings::Exports::BaseController This commit removes duplicate specs in classes inheriting Settings::Exports::BaseController as well.	8 years ago
Akihiko Odaki	fd328cf6e8	Cover WellKnown::WebfingerController more (#3385)	8 years ago
Akihiko Odaki	7b473d7514	Cover Settings::TwoFactorAuthentication::ConfirmationsController more (#3386)	8 years ago
Akihiko Odaki	7a281c477a	Cover Admin::PubSubHubHubController more (#3343)	8 years ago
Atsushi Yamamoto	402c19a924	Add preference setting for delete toot modal (#3368) ... * Set delete_modal preference to true by default * Does not show confirmation modal if delete_modal is false * Add ja translation for preference setting page	8 years ago
Akinori MUSHA	f6a93fc150	Go to root after login in single user mode (#3289) ... In single user mode, visitors are redirected to the single user's profile page. So, if you are the owner without a session, you start from that page, click the login button and authenticate yourself expecting you'll soon get started with the home page, but in reality you'll get redirected back to where you started from -- your own profile page. This fixes the behavior by redirecting you home after login if you have started from your own profile page.	8 years ago
Akihiko Odaki	019f3377bb	Spec Admin::BaseController (#3328)	8 years ago
Akihiko Odaki	a8736aab7a	Cover TagsController more (#3306)	8 years ago
Akihiko Odaki	5d9f479538	Cover HomeController more (#3258)	8 years ago
Eugen Rochko	2ca1f0737a	Fix Devise destroy method being available to delete user record (#3266) ... (You may think that we need account deletions, but this way would've just orphaned the db records)	8 years ago
alpaca-tc	7ee5fc5d68	Toggle sensitive from admin page (#3261)	8 years ago
Matt Jankowski	4289ed1d13	Refactor of API timeline actions (#3263) ... - Increase coverage to exercise all parts of each action - Move into namespace to share common code - Misc refactor of each action for smaller methods, simpler code	8 years ago
Akihiko Odaki	152b4d54e8	Cover StatusesController more (#3259)	8 years ago
Akihiko Odaki	ea2ef16ea4	Cover StreamEntriesController more and remove redundant instructions (#3257) ... * Cover StreamEntriesController more * Remove redundant instructions in StreamEntriesController	8 years ago
Akihiko Odaki	1d3e0a5060	Spec AuthorizeFollowsController assigns @account (#3246) ... @account is used by the view.	8 years ago
Akihiko Odaki	bf575a1f5e	Introduce recent to Follow (#3247) ... Introduce recent to Follow, as Account and other models have. This change also adds specs for the scope and the dependents.	8 years ago
Akihiko Odaki	8fd174298d	Cover AccountsController more in spec (#3229) ... * Introduce recent scope to Status and StreamEntry Introduce recent scope to Status and StreamEntry as Account has. * Cover AccountsController more in AccountsController	8 years ago
Matt Jankowski	a28ce13b3e	Coverage for api/web/settings controller (#3238)	8 years ago
Akihiko Odaki	bda7391221	Cover ApplicationController more in spec (#3230)	8 years ago
Akihiko Odaki	b9e8ffbd12	Cover AccountUnfollowController more in spec (#3228)	8 years ago
Akihiko Odaki	422e4d897b	Cover AccountFollowController more in spec (#3227)	8 years ago
Akihiko Odaki	cb2707776f	Cover AboutController more in spec (#3226)	8 years ago
Immae	a94c152fd3	Allow alternate domains for mastodon handlers (#3187)	8 years ago
Akihiko Odaki	aa662cecad	single_user_mode? always returns boolean (#3215) ... This change also adds a specification for the method.	8 years ago
Matt Jankowski	8f4b7c1820	Filter languages with opt out (#3175) ... * Remove allowed_languages and add filtered_languages * Use filtered_languages instead of allowed_languages	8 years ago
Jack Jennings	8c5eaf7ae9	Enable and fill in JSON response test in API::AccountsController (#3157)	8 years ago
Matt Jankowski	b6f6152e26	Add coverage for api/v1 controllers (#3155)	8 years ago
Eugen Rochko	620d0d8029	Account domain blocks (#2381) ... * Add <ostatus:conversation /> tag to Atom input/output Only uses ref attribute (not href) because href would be the alternate link that's always included also. Creates new conversation for every non-reply status. Carries over conversation for every reply. Keeps remote URIs verbatim, generates local URIs on the fly like the rest of them. * Conversation muting - prevents notifications that reference a conversation (including replies, favourites, reblogs) from being created. API endpoints /api/v1/statuses/:id/mute and /api/v1/statuses/:id/unmute Currently no way to tell when a status/conversation is muted, so the web UI only has a "disable notifications" button, doesn't work as a toggle * Display "Dismiss notifications" on all statuses in notifications column, not just own * Add "muted" as a boolean attribute on statuses JSON For now always false on contained reblogs, since it's only relevant for statuses returned from the notifications endpoint, which are not nested Remove "Disable notifications" from detailed status view, since it's only relevant in the notifications column * Up max class length * Remove pending test for conversation mute * Add tests, clean up * Rename to "mute conversation" and "unmute conversation" * Raise validation error when trying to mute/unmute status without conversation * Adding account domain blocks that filter notifications and public timelines * Add tests for domain blocks in notifications, public timelines Filter reblogs of blocked domains from home * Add API for listing and creating account domain blocks * API for creating/deleting domain blocks, tests for Status#ancestors and Status#descendants, filter domain blocks from them * Filter domains in streaming API * Update account_domain_block_spec.rb	8 years ago
Eugen Rochko	d0dd9eb5b5	Feature conversations muting (#3017) ... * Add <ostatus:conversation /> tag to Atom input/output Only uses ref attribute (not href) because href would be the alternate link that's always included also. Creates new conversation for every non-reply status. Carries over conversation for every reply. Keeps remote URIs verbatim, generates local URIs on the fly like the rest of them. * Conversation muting - prevents notifications that reference a conversation (including replies, favourites, reblogs) from being created. API endpoints /api/v1/statuses/:id/mute and /api/v1/statuses/:id/unmute Currently no way to tell when a status/conversation is muted, so the web UI only has a "disable notifications" button, doesn't work as a toggle * Display "Dismiss notifications" on all statuses in notifications column, not just own * Add "muted" as a boolean attribute on statuses JSON For now always false on contained reblogs, since it's only relevant for statuses returned from the notifications endpoint, which are not nested Remove "Disable notifications" from detailed status view, since it's only relevant in the notifications column * Up max class length * Remove pending test for conversation mute * Add tests, clean up * Rename to "mute conversation" and "unmute conversation" * Raise validation error when trying to mute/unmute status without conversation	8 years ago
Eugen Rochko	65f9db73b0	Fix #2027 - Accept own ID for remote follow with and without preceding @ (#2991) ... * Fix #2027 - Accept own ID for remote follow with and without preceding @ Fix #2177 - Omit leading "acct:" in remote follow redirect template expansion * Fix test	8 years ago
Matt Jankowski	04166c4a35	Specs for API push controller, with refactor (#2926) ... * Coverage for api push controller * Refactor the api/push controller	8 years ago
Matt Jankowski	bba537a7be	Improve allowed language handling (#2897) ... * Dont allow empty value in user allowed languages * Sanitize language input to reject blank values in array	8 years ago
Matt Jankowski	84eb425f38	Remove redis clear from before in spec (#2795)	8 years ago
Matt Jankowski	2bd132d458	Replace best_in_place editor on admin settings page (#2789) ... * Remove best_in_place * Replace best_in_place usage with rails helpers * Move admin/settings#index to #edit action * Remove click_to__edit from i18n	8 years ago
Eugen Rochko	bafd22ecf4	Fix #2706 - Always respond with 200 to PuSH payloads (#2733) ... Fix #2196 - Respond with 201 when Salmon accepted, 400 when unverified Fix #2629 - Correctly handle confirm_domain? for local accounts Unify rules for extracting author acct from XML, prefer <email>, fall back to <name> + <uri> (see also #2017, #2172)	8 years ago
Eugen Rochko	f5bf5ebb82	Replace sprockets/browserify with Webpack (#2617) ... * Replace browserify with webpack * Add react-intl-translations-manager * Do not minify in development, add offline-plugin for ServiceWorker background cache updates * Adjust tests and dependencies * Fix production deployments * Fix tests * More optimizations * Improve travis cache for npm stuff * Re-run travis * Add back support for custom.scss as before * Remove offline-plugin and babili * Fix issue with Immutable.List().unshift(...values) not working as expected * Make travis load schema instead of running all migrations in sequence * Fix missing React import in WarningContainer. Optimize rendering performance by using ImmutablePureComponent instead of React.PureComponent. ImmutablePureComponent uses Immutable.is() to compare props. Replace dynamic callback bindings in <UI /> * Add react definitions to places that use JSX * Add Procfile.dev for running rails, webpack and streaming API at the same time	8 years ago
Matt Jankowski	268dd32d76	Auth sign out (#2511) ... * Add a spec for signing out * Add spec showing that suspended user gets a 403 forbidden on sign out * Allow suspended account users to sign out	8 years ago
Kaylee	7880671f35	Add option to disable two factor auth in admin accounts panel. (#2584) ... * Add option to disable two factor auth in admin accounts panel. Closes #2578 * Add @mjankowski's suggestions. * Moves destroy actions behind User#disable_two_factor! * Adds spec coverage for Admin:TwoFactorAuthenticationsController and User#disable_two_factor!	8 years ago
Matt Jankowski	a4859446ab	Coverage for remote follows (#2694) ... * Add coverage for create with empty acct value * Add coverage for create with webfinger failure * Add coverage for create with webfinger providing bad values * Add coverage for create when webfinger is good * Add coverage for session[:remote_follow] having data * Simplify how remote follow pulls acct from session * Remote follow behaves more like model * Move the discovery portions of remote follow out of controller * Check for suspended accounts	8 years ago
Matt Jankowski	f025cc6782	Filter on allowed user language preferences (#2361) ... * Naive approached to timeline filtering * Convert allowed_languages into a db column * Allow users to choose languages to see statuses in * Style list items as two columns * Add a hint to explain language filtering preference	8 years ago
Matt Jankowski	fdcf884cf7	Extract user tracking into concern (#2600)	8 years ago
Matt Jankowski	f48cb3eb17	More coverage yes more even more (#2627) ... * Add coverage for admin/confirmations controller * Coverage for statuses controller show action * Add coverage for admin/domain_blocks controller * Add coverage for settings/profiles#update	8 years ago
Matt Jankowski	9566893cc9	More controller specs (#2561) ... * Add render_views in more places * Delegate methods from account to user with allow nil true, so that admin accounts show view renders when missing a user * Use actual account instances in authorize follow controller spec	8 years ago
Matt Jankowski	429480bb77	Return missing page when tag does not exist (#2563)	8 years ago
Matt Jankowski	a39e719b39	Add render_views to admin/reports controller spec (#2548)	8 years ago
Matt Jankowski	9736753985	Fix remote follow (#2547) ... * Add coverage for remote_follow#new * Fix reference to authorize_follows/card partial	8 years ago
Matt Jankowski	b48f2cbc8b	Catch error when server decryption fails on 2FA (#2512)	8 years ago
Matt Jankowski	0618f09939	Add spec coverage and refactor authorize_follows controller (#2505)	8 years ago
alpaca-tc	9317ec8eb1	Localize with i18n for Devise::FailureApp (#2309) ... This PR fixes I18n.locale for rake middlewares. Mastodon uses Devise that depends on Warden. Warden::Manager can be found in rake middleware. It is outside of the controller. In the case of authentication failed, warden calls throw(:warden). At the time Warden::Manager delegates request to failure_app to generate response and flash[:alert] after catching it. Unfortunately, I18n.locale is already reset then because I18n.with_locale is enabled only inside the controller. If we used I18n.locale=, Devise::FailureApp could get the current locale.	8 years ago
Evan Minto	122d59ac41	Change ActivityPub paging to match spec. Clean up ActivityPub outbox changes. (#2410) ... * Change ActivityPub paging to match spec. Clean up ActivityPub outbox changes. * Fix code style and test failures for OutboxController. * Attempt to fix CI errors.	8 years ago
Matt Jankowski	092fdc89fa	Fix flashes partial render error for controllers which don't inherit from application controller (#2400) ... * Add failing spec for oauth/authorized_applications controller * Use explicit reference to flashes partial from admin layout Because some of the controllers which use the admin layout do not inherit from application controller, this partial is not in their view path.	8 years ago
Eugen	501514960a	Followers-only post federation (#2111) ... * Make private toots get PuSHed to subscription URLs that belong to domains where you have approved followers * Authorized followers controller, stub for bulk action * Soft block in the background * Add simple test for new controller * Rename Settings::FollowersController to Settings::FollowerDomainsController, paginate results, rename "private" post setting to "followers-only", fix pagination style, improve post privacy preferences style, improve warning style * Extract compose form warnings into own container, show warning when posting to followers-only with unlocked account	8 years ago
Matt Jankowski	948dd26931	Fix deprecation warnings on activitypub controller specs (#2357)	8 years ago
Evan Minto	66fd8e7821	ActivityPub: Add basic, read-only support for Outboxes, Notes, and Create/Announce Activities (#2197) ... * Clean up collapsible components * Expose user Outboxes and AS2 representations of statuses * Save work thus far. * Fix bad merge. * Save my work * Clean up pagination. * First test working. * Add tests. * Add Forbidden error template. * Revert yarn.lock changes. * Fix code style deviations and use localized instead of hardcoded English text.	8 years ago
Matt Jankowski	67dea31b0f	2FA controller cleanup (#2296) ... * Add spec coverage for settings/two_factor_auth area * extract setup method for qr code * Move otp required check to before action * Merge method only used once * Remove duplicate view * Consolidate creation of @codes for backup * Move settings/2fq#recovery_codes to settings/recovery_codes#create * Rename settings/two_factor_auth#disable to #destroy * Add coverage for the otp required path on 2fa#show * Clean up the recovery codes list styles * Move settings/two_factor_auth to settings/two_factor_authentication * Reorganize the settings two factor auth area Updated to use a flow like: - settings/two_factor_authentication goes to a #show view which has a button either enable or disable 2fa on the account - the disable button turns off the otp requirement for the user - the enable button cycles the user secret and redirects to a confirmation page - the confirmation page is a #new view which shows the QR code for user - that page posts to #create which verifies the code, and creates the recovery codes - that create action shares a view with a recovery codes controller which can be used separately to reset codes if needed	8 years ago
Matt Jankowski	ee0c897bba	User settings mutation (#2270) ... * Add user spec for settings, highlight global default mutation issue * Fix mutation issue caused by settings/preferences spec	8 years ago
Matt Jankowski	2dda356e3f	Clean up settings/preferences controller (#2237) ... * Add missing fields group on preferences page * Clean up settings/preferences controller * Extract a UserSettingsDecorator	8 years ago
Matt Jankowski	1ada494bb2	Admin settings controller refactor, add specs, cleanup (#2225) ... * Add render_views for admin/settings spec * Add coverage for admin/settings#update * Add coverage for admin/settings typecasting open_registrations setting * Simplify how admin/settings finds the value for updating * Rely on activerecord to not update a value that hasnt changed * Add coverage for non-existent setting * Use a constant for boolean settings	8 years ago
Marcin Cieślak	59a77923b3	Add static gif for upload testing (#2168)	8 years ago
Matt Jankowski	8bac0350d1	Restful refactor of accounts/ routes (#2133) ... * Add routing specs for accounts followers and following actions * Use more restful route naming for public account follow pages Moves two actions: - accounts#followers to accounts/follower_accounts#index - accounts#following to accounts/following_accounts#index Adds routing spec to ensure prior URLs are preserved.	8 years ago
happycoloredbanana	0a7588282a	Remove API authentication for public statuses (after review) (#1919)	8 years ago
Matt Jankowski	55e1503522	Instances list in admin (#2095) ... * Add admin/instances index action * Add link to instances admin page * View lists instances * Instances, grouped by domain, ordered by count * Use Account.remote scope * Extract method: Account.by_domain_accounts	8 years ago
Matt Jankowski	cc1361c149	Media controller specs (#2022) ... * Add spec for media controller * Add MediaAttachment.attached scope * Simplify methods in media controller	8 years ago
saturday06	d87ee1167e	Assign user locale on signup (#1982)	8 years ago
Matt Jankowski	6670e6d33f	Add password reset for users from admin accounts area (#1841)	8 years ago