mastodon

Commit Graph

Author	SHA1	Message	Date
Matt Jankowski	2d9808f648	Reformat large key values in service specs (#26181 )	2 years ago
Matt Jankowski	6c5a2233a8	Fix `RSpec/StubbedMock` cop (#25552 ) Co-authored-by: Claire <claire.github-309c@sitedethib.com>	2 years ago
Matt Jankowski	658742b3cd	Fix `Lint/AmbiguousBlockAssociation` cop (#25921 )	2 years ago
Matt Jankowski	c75df62ccc	Fix `RSpec/SubjectDeclaration` cop (#25312 )	2 years ago
Matt Jankowski	4c5aa0e470	Update rubocop-rspec to version 2.22.0, fix `RSpec/IndexedLet` cop (#24698 )	2 years ago
Matt Jankowski	c42591356d	Fix `RSpec/DescribedClass` cop (#25104 )	2 years ago
Nick Schonning	99e2e9b81f	Fix minor typos in comments and spec names (#21831 )	2 years ago
Matt Jankowski	a610a02d4f	Fix RSpec/ScatteredSetup cop (#24848 )	2 years ago
Matt Jankowski	710745e16b	Fix RSpec/ContextWording cop (#24739 )	2 years ago
Nick Schonning	a3393d0d07	Autofix Rubocop RSpec/MatchArray (#24050 )	2 years ago
Nick Schonning	84cc805cae	Enable Style/FrozenStringLiteralComment for specs (#23790 )	2 years ago
Nick Schonning	5116347eb7	Autofix Rubocop RSpec/BeEq (#23740 )	2 years ago
Nick Schonning	bf785df9fe	Audofix Rubocop Style/WordArray (#23739 )	2 years ago
Nick Schonning	4552685f6b	Autofix Rubocop RSpec/LeadingSubject (#23670 )	2 years ago
Nick Schonning	5179c47087	Autofix Rubocops RSpec/ScatteredLet (#23725 )	2 years ago
Nick Schonning	65ba0d92ef	Enable Rubocop RSpec/NotToNot (#23723 )	2 years ago
Nick Schonning	81ad6c2e39	Autofix Rubocop Style/StringLiterals (#23695 )	2 years ago
Nick Schonning	08289a38fa	Autofix Rubocop Style/TrailingCommaInArrayLiteral (#23692 )	2 years ago
Nick Schonning	5069769cbe	Autofix Rubocop Style/TrailingCommaInHashLiteral (#23693 )	2 years ago
Nick Schonning	634368c491	Autofix Rubocop Lint/SymbolConversion (#23683 )	2 years ago
Nick Schonning	669f6d2c0a	Run rubocop formatting except line length (#23632 )	2 years ago
Nick Schonning	37914c8757	Autofix Rubocop Style/MethodCallWithoutArgsParentheses (#23645 )	2 years ago
Claire	0c9eac80d8	Fix unbounded recursion in post discovery (#23506 ) * Add a limit to how many posts can get fetched as a result of a single request * Add tests * Always pass `request_id` when processing `Announce` activities --------- Co-authored-by: nametoolong <nametoolong@users.noreply.github.com>	2 years ago
Claire	c8849d6cee	Fix unbounded recursion in account discovery (#22025 ) * Fix trying to fetch posts from other users when fetching featured posts * Rate-limit discovery of new subdomains * Put a limit on recursively discovering new accounts	2 years ago
Claire	625216d8e1	Fix attachments of edited statuses not being fetched (#21565 ) * Fix attachments of edited statuses not being fetched * Fix tests	2 years ago
Claire	bbf74498f5	Fix validation error in SynchronizeFeaturedTagsCollectionWorker (#20018 ) * Fix followers count not being updated when migrating follows Fixes #19900 * Fix validation error in SynchronizeFeaturedTagsCollectionWorker Also saves remote user's chosen case for hashtags * Limit remote featured tags before validation	2 years ago
Yamagishi Kazutoshi	94feb2b93f	Fix `FetchFeaturedCollectionService` spec (#19401 ) Regression from #19380	2 years ago
Claire	7165e89362	Add tests to ActivityPub::FetchRemoteKeyService (#19226 )	2 years ago
Claire	8cf7006d4e	Refactor ActivityPub handling to prepare for non-Account actors (#19212 ) * Move ActivityPub::FetchRemoteAccountService to ActivityPub::FetchRemoteActorService ActivityPub::FetchRemoteAccountService is kept as a wrapper for when the actor is specifically required to be an Account * Refactor SignatureVerification to allow non-Account actors * fixup! Move ActivityPub::FetchRemoteAccountService to ActivityPub::FetchRemoteActorService * Refactor ActivityPub::FetchRemoteKeyService to potentially return non-Account actors * Refactor inbound ActivityPub payload processing to accept non-Account actors * Refactor inbound ActivityPub processing to accept activities relayed through non-Account * Refactor how Account key URIs are built * Refactor Request and drop unused key_id_format parameter * Rename ActivityPub::Dereferencer `signature_account` to `signature_actor`	2 years ago
Claire	1145dbd327	Improve error reporting and logging when processing remote accounts (#15605 ) * Add a more descriptive PrivateNetworkAddressError exception class * Remove unnecessary exception class to rescue clause * Remove unnecessary include to JsonLdHelper * Give more neutral error message when too many webfinger redirects * Remove unnecessary guard condition * Rework how “ActivityPub::FetchRemoteAccountService” handles errors Add “suppress_errors” keyword argument to avoid raising errors in ActivityPub::FetchRemoteAccountService#call (default/previous behavior). * Rework how “ActivityPub::FetchRemoteKeyService” handles errors Add “suppress_errors” keyword argument to avoid raising errors in ActivityPub::FetchRemoteKeyService#call (default/previous behavior). * Fix Webfinger::RedirectError not being a subclass of Webfinger::Error * Add suppress_errors option to ResolveAccountService Defaults to true (to preserve previous behavior). If set to false, errors will be raised instead of caught, allowing the caller to be informed of what went wrong. * Return more precise error when failing to fetch account signing AP payloads * Add tests * Fixes * Refactor error handling a bit * Fix various issues * Add specific error when provided Digest is not 256 bits of base64-encoded data * Please CodeClimate * Improve webfinger error reporting	2 years ago
Claire	e0bdaeab65	Fix NoMethodError when resolving a link that redirects to a local post (#18314 ) * Fix NoMethodError when resolving a link that redirects to a local post * Fix tests	3 years ago
Claire	71d02ffcf3	Fix compatibility with Friendica regarding pinned posts (#18254 ) * Fix multiple database queries when fetching pinned posts for remote account * Fix compatibility with Friendica regarding pinned posts Fixes #18066 * Add tests	3 years ago
Claire	8f91e304a5	Fix spurious edits and require incoming edits to be explicitly marked as such (#17918 ) * Change post text edit to not be considered significant if it's identical after reformatting * We don't need to clear previous change information anymore * Require status edits to be explicit, except for poll tallies * Fix tests * Add some tests * Add poll-related tests * Add HTML-formatting related tests	3 years ago
Eugen Rochko	71f2b95106	Fix edits with no actual changes being allowed (#17843 ) * Fix edits with no actual changes being allowed locally * Fix edits with no actual changes being allowed through ActivityPub * Fix false positive changes caused by description processing in model * Fix not recording poll expiration update * Fix test * Revert changes to ProcessStatusUpdateService * Various fixes and improvements * Fix code style issues * Various changes and improvements * Add guard clause	3 years ago
Claire	92a86b958e	Fix issues with processing toot edits (#17748 ) * Fix searching for an already-known status by URL not working * Fix Update processing from statuses prior to 20220302232632 `ordered_media_attachment_ids_changed?` would return `true` when going from `nil` to anything (including `[]`). * Add tests	3 years ago
Eugen Rochko	ddbe906c25	Fix not updating a status when newer version is fetched manually (#17745 )	3 years ago
Claire	63c9d2bc28	Add tests for CVE-2022-24307 (#17733 ) Follow-up to #17426	3 years ago
Eugen Rochko	d17fb70131	Change how changes to media attachments are stored for edits (#17696 ) * Change how changes to media attachments are stored for edits Fix not being able to re-order media attachments * Fix not broadcasting updates when polls/media is changed through ActivityPub * Various fixes and improvements * Update app/models/report.rb Co-authored-by: Claire <claire.github-309c@sitedethib.com> * Add tracking of media attachment description changes * Change poll in status edit to have a structure closer to the real one Co-authored-by: Claire <claire.github-309c@sitedethib.com>	3 years ago
Claire	2af03164cb	Improve tests involving push_bulk (#17508 ) sidekiq-bulk's push_bulk can either accept arguments directly or run them through a block. Setting expectations on the result of evaluating the blocks allows testing more code (the block itself) and the test is moved closer to the interface of the tested code than its precise implementation.	3 years ago
Eugen Rochko	63002cde03	Add editing for published statuses (#17320 ) * Add editing for published statuses * Fix change of multiple-choice boolean in poll not resetting votes * Remove the ability to update existing media attachments for now	3 years ago
Eugen Rochko	1060666c58	Add support for editing for published statuses (#16697 ) * Add support for editing for published statuses * Fix references to stripped-out code * Various fixes and improvements * Further fixes and improvements * Fix updates being potentially sent to unauthorized recipients * Various fixes and improvements * Fix wrong words in test * Fix notifying accounts that were tagged but were not in the audience * Fix mistake	3 years ago
Eugen Rochko	7de0ee7aba	Remove Keybase integration (#17045 )	3 years ago
Claire	3f9b28ce26	Add support for fetching Create and Announce activities by URI (#16383 ) * Add support for fetching Create and Announce activities by URI This should improve compatibility with ZAP and offer a way to fetch boosts, which is currently not possible. * Add tests	3 years ago
Claire	13b08610a0	Fix crash when encountering invalid account fields (#16598 ) * Add test * Fix crash when encountering invalid account fields	4 years ago
Eugen Rochko	3134691948	Add support for reversible suspensions through ActivityPub (#14989 )	4 years ago
ThibG	ca56527140	Add follower synchronization mechanism (#14510 ) * Add support for followers synchronization on the receiving end Check the `collectionSynchronization` attribute on `Create` and `Announce` activities and synchronize followers from provided collection if possible. * Add tests for followers synchronization on the receiving end * Add support for follower synchronization on the sender's end * Add tests for the sending end * Switch from AS attributes to HTTP header Replace the custom `collectionSynchronization` ActivityStreams attribute by an HTTP header (`X-AS-Collection-Synchronization`) with the same syntax as the `Signature` header and the following fields: - `collectionId` to specify which collection to synchronize - `digest` for the SHA256 hex-digest of the list of followers known on the receiving instance (where “receiving instance” is determined by accounts sharing the same host name for their ActivityPub actor `id`) - `url` of a collection that should be fetched by the instance actor Internally, move away from the webfinger-based `domain` attribute and use account `uri` prefix to group accounts. * Add environment variable to disable followers synchronization Since the whole mechanism relies on some new preconditions that, in some extremely rare cases, might not be met, add an environment variable (DISABLE_FOLLOWERS_SYNCHRONIZATION) to disable the mechanism altogether and avoid followers being incorrectly removed. The current conditions are: 1. all managed accounts' actor `id` and inbox URL have the same URI scheme and netloc. 2. all accounts whose actor `id` or inbox URL share the same URI scheme and netloc as a managed account must be managed by the same Mastodon instance as well. As far as Mastodon is concerned, breaking those preconditions require extensive configuration changes in the reverse proxy and might also cause other issues. Therefore, this environment variable provides a way out for people with highly unusual configurations, and can be safely ignored for the overwhelming majority of Mastodon administrators. * Only set follower synchronization header on non-public statuses This is to avoid unnecessary computations and allow Follow-related activities to be handled by the usual codepath instead of going through the synchronization mechanism (otherwise, any Follow/Undo/Accept activity would trigger the synchronization mechanism even if processing the activity itself would be enough to re-introduce synchronization) * Change how ActivityPub::SynchronizeFollowersService handles follow requests If the remote lists a local follower which we only know has sent a follow request, consider the follow request as accepted instead of sending an Undo. * Integrate review feeback - rename X-AS-Collection-Synchronization to Collection-Synchronization - various minor refactoring and code style changes * Only select required fields when computing followers_hash * Use actor URI rather than webfinger domain in synchronization endpoint * Change hash computation to be a XOR of individual hashes Makes it much easier to be memory-efficient, and avoid sorting discrepancy issues. * Marginally improve followers_hash computation speed * Further improve hash computation performances by using pluck_each	4 years ago
Thomas Citharel	8094955461	Add Event activity-type support (#12637 ) This adds support for Event AP type in Mastodon. Events are converted into toots by taking their title (AS name) and their URL (AP ID). Event picture is also brought in if available. Testable by fetching event content from https://test.mobilizon.org Signed-off-by: Thomas Citharel <tcit@tcit.fr>	5 years ago
ThibG	915c619394	Add support for Audio activities (#11189 ) Fixes #11127	6 years ago
ThibG	2acd8940de	Fix more keybase-related test failures (#10443 )	6 years ago
ThibG	abecaba317	Fix failing keybase-related test (#10428 )	6 years ago

1 2

70 Commits (9dff838edc3da9e8722adb08f72815ab88607853)