mastodon

Commit Graph

Author	SHA1	Message	Date
santiagorodriguez96	e8d41bc2fe	Add WebAuthn as an alternative 2FA method (#14466 ) * feat: add possibility of adding WebAuthn security keys to use as 2FA This adds a basic UI for enabling WebAuthn 2FA. We did a little refactor to the Settings page for editing the 2FA methods – now it will list the methods that are available to the user (TOTP and WebAuthn) and from there they'll be able to add or remove any of them. Also, it's worth mentioning that for enabling WebAuthn it's required to have TOTP enabled, so the first time that you go to the 2FA Settings page, you'll be asked to set it up. This work was inspired by the one donde by Github in their platform, and despite it could be approached in different ways, we decided to go with this one given that we feel that this gives a great UX. Co-authored-by: Facundo Padula <facundo.padula@cedarcode.com> * feat: add request for WebAuthn as second factor at login if enabled This commits adds the feature for using WebAuthn as a second factor for login when enabled. If users have WebAuthn enabled, now a page requesting for the use of a WebAuthn credential for log in will appear, although a link redirecting to the old page for logging in using a two-factor code will also be present. Co-authored-by: Facundo Padula <facundo.padula@cedarcode.com> * feat: add possibility of deleting WebAuthn Credentials Co-authored-by: Facundo Padula <facundo.padula@cedarcode.com> * feat: disable WebAuthn when an Admin disables 2FA for a user Co-authored-by: Facundo Padula <facundo.padula@cedarcode.com> * feat: remove ability to disable TOTP leaving only WebAuthn as 2FA Following examples form other platforms like Github, we decided to make Webauthn 2FA secondary to 2FA with TOTP, so that we removed the possibility of removing TOTP authentication only, leaving users with just WEbAuthn as 2FA. Instead, users will have to click on 'Disable 2FA' in order to remove second factor auth. The reason for WebAuthn being secondary to TOPT is that in that way, users will still be able to log in using their code from their phone's application if they don't have their security keys with them – or maybe even lost them. * We had to change a little the flow for setting up TOTP, given that now it's possible to setting up again if you already had TOTP, in order to let users modify their authenticator app – given that now it's not possible for them to disable TOTP and set it up again with another authenticator app. So, basically, now instead of storing the new `otp_secret` in the user, we store it in the session until the process of set up is finished. This was because, as it was before, when users clicked on 'Edit' in the new two-factor methods lists page, but then went back without finishing the flow, their `otp_secret` had been changed therefore invalidating their previous authenticator app, making them unable to log in again using TOTP. Co-authored-by: Facundo Padula <facundo.padula@cedarcode.com> * refactor: fix eslint errors The PR build was failing given that linting returning some errors. This commit attempts to fix them. * refactor: normalize i18n translations The build was failing given that i18n translations files were not normalized. This commits fixes that. * refactor: avoid having the webauthn gem locked to a specific version * refactor: use symbols for routes without '/' * refactor: avoid sending webauthn disabled email when 2FA is disabled When an admins disable 2FA for users, we were sending two mails to them, one notifying that 2FA was disabled and the other to notify that WebAuthn was disabled. As the second one is redundant since the first email includes it, we can remove it and send just one email to users. * refactor: avoid creating new env variable for webauthn_origin config * refactor: improve flash error messages for webauthn pages Co-authored-by: Facundo Padula <facundo.padula@cedarcode.com>	5 years ago
Eugen Rochko	81a3db1564	Change rate limits for various paths (#14253 ) - Rate limit login attempts by target account - Rate limit password resets and e-mail re-confirmations by target account - Rate limit sign-up/login attempts, password resets, and e-mail re-confirmations by IP like before	5 years ago
ThibG	a783bdf4ad	Fix hashtag column options styling (#14247 ) * Enable nonces for stylesheets * Pass nonce to react-select	5 years ago
Eugen Rochko	6d23d40420	Change Redis#exists calls to Redis#exists? to avoid deprecation warning (#14191 )	5 years ago
Eugen Rochko	7aaf2b44ec	Fix remote files not using Content-Type header, streaming (#14184 )	5 years ago
Eugen Rochko	8c04e37b03	Remove the terms blacklist and whitelist from UX (#14149 ) Localization strings: - "Whitelist mode" -> "Limited federation mode" - "Blacklist e-mail domain" -> "Block e-mail domain" - "Whitelist domain" -> "Allow domain for federation" ...And so on Environment variables (backwards-compatible): - `WHITELIST_MODE` -> `LIMITED_FEDERATION_MODE` - `EMAIL_DOMAIN_BLACKLIST` -> `EMAIL_DOMAIN_DENYLIST` - `EMAIL_DOMAIN_WHITELIST` -> `EMAIL_DOMAIN_ALLOWLIST` tootctl: - `tootctl domains purge --whitelist-mode` -> `tootctl domains purge --limited-federation-mode` Removed badly maintained and no longer relevant .env.production.sample file	5 years ago
mayaeh	f56129a947	Suppress Redis#exists(key) warning (#14067 )	5 years ago
Eugen Rochko	5d8398c8b8	Add E2EE API (#13820 )	5 years ago
Takeshi Umeda	8e056bd82e	Fix csv upload (#13835 )	5 years ago
Takeshi Umeda	1c434615b3	Fix workaround for Elasticsearch 7.x (#13828 )	5 years ago
Eugen Rochko	4b766f9846	Refactor monkey-patching of Goldfinger (#12561 )	5 years ago
ThibG	34756cc4e0	Fix "tootctl media remove-orphans" crashing on “Import” files (#13685 ) * Fix "tootctl media remove-orphans" crashing on “Import” files * Also remove empty directories when removing orphaned media	5 years ago
ThibG	e1629a7758	Remove 'unsafe-inline' from Content-Security-Policy style-src (#13679 ) * Make sure wicg-inert doesn't rely on inline CSS * Remove unsafe-inline from style-src	5 years ago
ThibG	dea5db0e25	Fix PgHero Content-Security-Policy when CDN_HOST is used (#13595 )	5 years ago
mayaeh	acc367fd14	Fix naming issue (#13551 )	5 years ago
Eugen Rochko	c3ca3801f2	Add separate cache directory for non-local uploads (#12821 )	5 years ago
Eugen Rochko	d18d6c29f3	Fix search not working due to proxy settings when using hidden services (#13488 ) Fix #13484	5 years ago
Eugen Rochko	f65568f1d4	Add ability to filter audit log in admin UI (#13381 )	5 years ago
Eugen Rochko	9014367bd8	Fix background jobs not using locks like they are supposed to (#13361 ) Also: - Fix locks not being removed when jobs go to the dead job queue - Add UI for managing locks to the Sidekiq dashboard - Remove unused Sidekiq workers Fix #13349	5 years ago
Eugen Rochko	9241cbf861	Fix re-sending of e-mail confirmation not being rate limited (#13360 ) Fix #13330	5 years ago
ThibG	7ddbbdea6d	Fix OCR not working on Safari because of unsupported worker-src CSP (#13323 ) Fixes #13321	5 years ago
dependabot-preview[bot]	56531d646e	Bump sidekiq from 5.2.7 to 6.0.4 (#11727 ) * Bump sidekiq from 5.2.7 to 6.0.0 Bumps [sidekiq](https://github.com/mperham/sidekiq) from 5.2.7 to 6.0.0. - [Release notes](https://github.com/mperham/sidekiq/releases) - [Changelog](https://github.com/mperham/sidekiq/blob/master/Changes.md) - [Commits](https://github.com/mperham/sidekiq/compare/v5.2.7...v6.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Sidekiq::Logger.logger -> Sidekiq.logger * Drop support Ruby 2.4 * update Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh>	5 years ago
Eugen Rochko	339ce1c4e9	Add specific rate limits for posting and following (#13172 )	5 years ago
Eugen Rochko	f52c988e12	Add announcements (#12662 ) * Add announcements Fix #11006 * Add reactions to announcements * Add admin UI for announcements * Add unit tests * Fix issues - Add `with_dismissed` param to announcements API - Fix end date not being formatted when time range is given - Fix announcement delete causing reactions to send streaming updates - Fix announcements container growing too wide and mascot too small - Fix `all_day` being settable when no time range is given - Change text "Update" to "Announcement" * Fix scheduler unpublishing announcements before they are due * Fix filter params not being passed to announcements filter	5 years ago
ThibG	a8e46cf7a1	Add support for magnet: URIs (#12905 )	5 years ago
ThibG	ea436b355b	Add support for linking XMPP URIs in toots (#12709 ) * Fix wrong grouping in Twitter valid_url regex * Add support for xmpp URIs Fixes #9776 The difficult part is autolinking, because Twitter-text's extractor does some pretty ad-hoc stuff to find things that “look like” URLs, and XMPP URIs do not really match the assumptions of that lib, so it doesn't sound wise to try to shoehorn it into the existing regex. This is why I used a specific regex (very close, although slightly more permissive than the RFC), and a specific scan function (a simplified version of the generalized one from Twitter). * Remove leading “xmpp:” from auto-linked text	5 years ago
Eugen Rochko	49b2f7c0a2	Fix base64-encoded file uploads not being possible (#12748 ) Fix #3804, Fix #5776	5 years ago
Eugen Rochko	59c697a30c	Fix resource_owner_from_credentials in Doorkeeper initializer (#12743 ) - Nil error when e-mail not found - LDAP authentication used in place of PAM authentication	5 years ago
Eugen Rochko	09d54d1f62	Fix uncaught query param encoding errors (#12741 )	5 years ago
Eugen Rochko	17159625b3	Add `S3_OVERRIDE_PATH_STYLE` environment variable (#12594 ) To support Exoscale	5 years ago
Eugen Rochko	f3d232381d	Add `tootctl media remove-orphans` (#12568 )	5 years ago
tateisu	f1ef777d40	add S3_OPEN_TIMEOUT environment variable (#12459 )	5 years ago
Mathieu Brunot	bd8dc9bd0c	✨ Add an LDAP Mail attribute config (#12053 ) Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io>	5 years ago
Mathieu Brunot	d70268f099	✨ Convert LDAP username (#12461 ) * ✨ Convert LDAP username #12021 Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io> * 🐛 Fix conversion var use Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io> * 🐛 Fix LDAP uid conversion test Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io> * 👌 Remove comments with ref to PR Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io> * 👌 Remove unnecessary paranthesis Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io> * 🔧 Move space in conversion string Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io>	5 years ago
ntl-purism	f3a93987b6	LDAP & PAM added to OAuth password grant strategy (#7999 ) (#12390 ) When authenticating via OAuth, the resource owner password grant strategy is allowed by Mastodon, but (without this PR), it does not attempt to authenticate against LDAP or PAM. As a result, LDAP or PAM authenticated users cannot sign in to Mastodon with their email/password credentials via OAuth (for instance, for native/mobile app users). This PR fleshes out the authentication strategy supplied to doorkeeper in its initializer by looking up the user with LDAP and/or PAM when devise is configured to use LDAP/PAM backends. It attempts to follow the same logic as the Auth::SessionsController for handling email/password credentials. Note #1: Since this pull request affects an initializer, it's unclear how to add test automation. Note #2: The PAM authentication path has not been manually tested. It was added for completeness sake, and it is hoped that it can be manually tested before merging.	5 years ago
ThibG	dfea7368c9	Add bookmarks (#7107 ) * Add backend support for bookmarks Bookmarks behave like favourites, except they aren't shared with other users and do not have an associated counter. * Add spec for bookmark endpoints * Add front-end support for bookmarks * Introduce OAuth scopes for bookmarks * Add bookmarks to archive takeout * Fix migration * Coding style fixes * Fix rebase issue * Update bookmarked_statuses to latest UI changes * Update bookmark actions to properly reflect status changes in state * Add bookmarks item to single-column layout * Make active bookmarks red	5 years ago
Eugen Rochko	45eccaf8c5	Fix preloaded JSON-LD context for identity not being used (#12138 ) Regression from #11316	5 years ago
Eugen Rochko	354fdd317e	Fix attachment not being re-downloaded even if file is not stored (#12125 ) Change the behaviour of remotable concern. Previously, it would skip downloading an attachment if the stored remote URL is identical to the new one. Now it would not be skipped if the attachment is not actually currently stored by Paperclip.	5 years ago
Eugen Rochko	086fc7ed77	Fix S3 adapter retrying failing uploads with exponential backoff (#12085 ) The default limit of 10 retries with exponential backoff meant that if the S3 server was timing out, you would be stuck with it for much, much longer than the 5 second read timeout we expect. The uploading happens within a database transaction, which means a failing S3 server could negatively affect database performance	5 years ago
Eugen Rochko	5c42f47617	Fix records not being indexed sometimes (#12024 ) It's possible that after commit callbacks were not firing when exceptions occurred in the process. Also, the default Sidekiq strategy does not push indexing jobs immediately, which is not necessary and could be part of the issue too.	5 years ago
Eugen Rochko	5f69eb89e2	Add a nodeinfo endpoint (#12002 ) * Add nodeinfo endpoint * dont commit stuff from my local dev * consistant naming since we implimented 2.1 schema * Add some additional node info stuff * Add nodeinfo endpoint * dont commit stuff from my local dev * consistant naming since we implimented 2.1 schema * expanding this to include federation info * codeclimate feedback * CC feedback * using activeserializers seems like a good idea... * get rid of draft 2.1 version * Reimplement 2.1, also fix metaData -> metadata * Fix metaData -> metadata here too * Fix nodeinfo 2.1 tests * Implement cache for monthly user aggregate * Useless * Remove ostatus from the list of supported protocols * Fix nodeinfo's open_registration reading obsolete setting variable * Only serialize domain blocks with user-facing limitations * Do not needlessly list noop severity in nodeinfo * Only serialize domain blocks info in nodeinfo when they are set to be displayed to everyone * Enable caching for nodeinfo endpoints * Fix rendering nodeinfo * CodeClimate fixes * Please CodeClimate * Change InstancePresenter#active_user_count_months for clarity * Refactor NodeInfoSerializer#metadata * Remove nodeinfo 2.1 support as the schema doesn't exist * Clean-up	5 years ago
Yamagishi Kazutoshi	a5c558f052	Hide error message on /heath (#11947 ) * Hide error message on /heath * update health_check	5 years ago
Yamagishi Kazutoshi	b02169f124	Cast multipart threshold to integer (#11944 )	5 years ago
Eugen Rochko	a1f04c1e34	Fix authentication before 2FA challenge (#11943 ) Regression from #11831	5 years ago
Yamagishi Kazutoshi	172eaeba3f	Add config of multipart threshold for S3 (#11924 )	5 years ago
Eugen Rochko	c707ef49d9	Fix 2FA challenge and password challenge for non-database users (#11831 ) * Fix 2FA challenge not appearing for non-database users Fix #11685 * Fix account deletion not working when using external login Fix #11691	5 years ago
Yamagishi Kazutoshi	4e1b742cb2	Change rate limit for media proxy (#11814 )	5 years ago
Yamagishi Kazutoshi	d7268befa8	Add healthcheck endpoint for web (#11770 )	6 years ago
ThibG	692c5b439a	Fix ActivityPub context not being dynamically computed (#11746 ) * Fix contexts not being dynamically included Fixes #11649 * Refactor Note context in serializer * Refactor Actor serializer	6 years ago
ThibG	8203e24cf4	Fix CSP needlessly allowing blob URLs in script-src (#11620 )	6 years ago

1 2 3 4 5 ...

310 Commits (8f630552dfec6afae3b7c071a0c88e4ca28d3340)