141 Commits (85973f4f37c8b94422f267654018d0d7f88ba32b)

Author	SHA1	Message	Date
ThibG	1ee675d68b	Use correct activity id in Accept when receiving duplicate Follow (fixes #8218) (#8244)	7 years ago
Eugen Rochko	39e361a56d	Expect relays to answer with accept/reject (#8179)	7 years ago
Eugen Rochko	07b799468d	Fix incorrect context definition for the "featured" keyword (#8090) ... * Fix incorrect context definition for the "featured" keyword Fix #8077 * Adjust context definition for movedTo	7 years ago
Eugen Rochko	6ba7d9d0d9	Do not accept ActivityPub follow requests from blocked user (#7756) ... * Do not accept ActivityPub follow requests from blocked user Fix #7745 * Deliver auto-rejection immediately when follow-requested by blocked account * Fix trailing whitespace	7 years ago
Eugen Rochko	1e938b966e	Exclude unlisted, private and direct toots from affecting trends (#7686)	7 years ago
Eugen Rochko	ab36e0ef72	Record trending tags from ActivityPub, too (#7647)	7 years ago
ThibG	cdbdf7f98b	Ignore multiple occurrences of a hashtag within a status (fixes #7585) (#7606)	7 years ago
Eugen Rochko	57b503d4ef	Resolve unknown status from Add activity, skip Remove if unknown (#7526) ... Fix #7518	7 years ago
Akihiko Odaki	55fd55714a	Raise Mastodon::RaceConditionError if Redis lock failed (#7511) ... An explicit error allows user agents to know the error and Sidekiq to retry.	7 years ago
ThibG	7467361d70	Fetch boosted statuses on behalf of a follower (fixes #7426) (#7459) ... When an ActivityPub Announce is processed and the boosted toot is not known, fetch it on behalf of one of the booster's followers. This is to allow fetching self-boosts of previously-unknown private toots. If fetching on behalf of a user fails, try fetching it anonymously: the selected follower of a boosting user may be banned by the boosted toot's author.	7 years ago
Eugen Rochko	c947e2e4c5	Fix handling of malformed ActivityPub payloads when URIs are nil (#7370) ... * Fix handling of malformed ActivityPub payloads when URIs are nil * Gracefully handle JSON-LD canonicalization failures	7 years ago
Eugen Rochko	6793bec4c6	Store URIs of follows, follow requests and blocks for ActivityPub (#7160) ... Same URI passed between follow request and follow, since they are the same thing in ActivityPub. Local URIs are generated during creation using UUIDs and are passed to serializers.	7 years ago
ThibG	a24605961a	Fixes/do not override timestamps (#7336) ... * Revert "Fixes/do not override timestamps (#7331)" This reverts commit 581a5c9d29. * Document Snowflake ID corner-case a bit more Snowflake IDs are used for two purposes: making object identifiers harder to guess and ensuring they are in chronological order. For this reason, they are based on the `created_at` attribute of the object. Unfortunately, inserting items with older snowflakes IDs will break the assumption of consumers of the paging APIs that new items will always have a greater identifier than the last seen one. * Add `override_timestamps` virtual attribute to not correlate snowflake ID with created_at	7 years ago
ThibG	581a5c9d29	Fixes/do not override timestamps (#7331) ... * Do not override timestamps for incoming toots * Remove every reference to override_timestamps Statuses are now created with the announced publishing date and are only pushed to timelines if that date is at most 6 hours earlier than the time at which it is processed.	7 years ago
ThibG	d0cdd5cf94	Accept actor object updates from all supported actor types (#7312)	7 years ago
Surinna Curtis	dc786c0cf4	Support Actors/Statuses with multiple types (#7305) ... * Add equals_or_includes_any? helper in JsonLdHelper * Support arrays in JSON-LD type fields for actors/tags/objects. * Spec for resolving accounts with extension types * Style tweaks for codeclimate	7 years ago
Eugen Rochko	78ed4ab75f	Add bio fields (#6645) ... * Add bio fields - Fix #3211 - Fix #232 - Fix #121 * Display bio fields in web UI * Fix output of links and missing fields * Federate bio fields over ActivityPub as PropertyValue * Improve how the fields are stored, add to Edit profile form * Add rel=me to links in fields Fix #121	7 years ago
Eugen Rochko	b5726def55	Forward deletes on the same path as reply forwarding (#7058) ... * Forward deletes on the same path as reply forwarding * Remove trailing whitespace	7 years ago
ThibG	e573bb0990	Fix compatibility with PeerTube (#6968) ... * Support fetching objects of convertible types by URL (fixes #6924) * Ignore invalid hashtags	7 years ago
ThibG	9ed5eebd7c	Do not ignore unknown media attachments, only skip them (#6948) ... That way, they are displayed in a list below the corresponding toot.	7 years ago
Eugen Rochko	f02411da40	Ignore media validation when attaching to status during processing (#6822) ... Fix #6821	7 years ago
MitarashiDango	6dcf96271e	fix validation error (media only status) (#6684) ... * fix validation error (media only status) * Incorporating review suggestions * Reflect similar fix to OStatus side * Fix not to include media in transaction * Restore the limit of the number of media * Fix not to return nil	7 years ago
Eugen Rochko	e6520c0270	Fix #6657 - Use target instead of origin in Remove activity (#6664)	7 years ago
Eugen Rochko	9110db41c5	Federate pinned statuses over ActivityPub (#6610) ... * Federate pinned statuses over ActivityPub * Display pinned toots in web UI Fix #6117 * Fix migration * Fix tests * Update outbox_serializer.rb * Update remove_serializer.rb * Update add_serializer.rb * Update fetch_featured_collection_service.rb	7 years ago
Eugen Rochko	e852872846	Fix #5708: Reject->Follow will remove the follow if it exists (#6571)	7 years ago
Eugen Rochko	41a01bec23	Federated reports (#6570) ... * Fix #2176: Federated reports * UI for federated reports * Add spec for ActivityPub Flag handler * Add spec for ReportService	7 years ago
Eugen Rochko	90f12f2e5a	Focal points (#6520) ... * Add focus param to media API, center thumbnails on focus point * Add UI for setting a focal point * Improve focal point icon on upload item * Use focal point in upload preview * Add focalPoint property to ActivityPub * Don't show focal point button for non-image attachments	7 years ago
Eugen Rochko	a71af98401	Push discovered status through streaming API within a time window (#6484) ... Time window of 6 hours	7 years ago
Akihiko Odaki	0be9a1e321	Accept ActivityPub announce from the author of the original note (#6236)	7 years ago
ThibG	b1e03197fa	Process mentions and reblogs even from resolved threads (#6299) ... This may lead to out-of-order notifications, but this is better than not having notifications at all.	7 years ago
Eugen Rochko	35b84985a8	Skip ActivityPub Announces of non-public objects (#6230) ... * Skip ActivityPub Announces of non-public objects * Skip OStatus reblogs of non-public statuses	7 years ago
puckipedia	628358aeea	Add the author of a status to cc if reblogged (#6226) ... This makes slightly more sense, and ensures that the author of a post is always referenced in the audience (which some servers might rely on). And the announce is POSTed to the author's inbox anyways.	7 years ago
Eugen Rochko	dbda87c31f	Revert #5772 (#6221)	7 years ago
Eugen Rochko	e4a241abef	Fix bad URL schemes being accepted (#6219) ... * Fix actors accepting invalid URI schemes or different host between URI and URL * Fix statuses accepting invalid URI scheme or different host to actor * Adjust tests to new requirements * Improve readability of mismatching_origin?/invalid_origin? methods	7 years ago
puckipedia	0eff42d688	Move Article from supported to converted types (#6218)	7 years ago
Akihiko Odaki	161c72d66d	Allow to dereference Follow object for ActivityPub (#5772) ... * Allow to dereference Follow object for ActivityPub * Accept IRI as object representation for Accept activity	7 years ago
Eugen Rochko	d60fd87e01	Don't leave behind husk of remotely-deleted profile (#6159) ... There's no reason for an Account record to persist after Delete->Actor is received. SuspendAccountService is necessary to make sure deleted toots get sent over streaming API properly and home feeds get cleaned up. By removing Account record, we can ensure that if in the future the account is restored remotely (or username reused), it can start with a clean slate.	7 years ago
abcang	3caec1ecc2	Save media outside transaction (#5959)	7 years ago
Yamagishi Kazutoshi	b21db9bbde	Using double splat operator (#5859)	7 years ago
Eugen Rochko	4c6b5dbe96	Add semi-support for Video/Image objects in ActivityPub (#5848) ... * Add semi-support for Video/Image objects in ActivityPub Video and Image objects will create corresponding status records with manually crafted text contents (title + URL) * Extract html-url-finding logic into JsonLdHelper * Fallback to id when url missing, extract supported object types	7 years ago
Eugen Rochko	85e97ecab6	Fix too many forwards (#5854) ... * Avoid sending explicit Undo->Announce when original deleted * Do not forward a reply back to the server that sent it * Deduplicate inboxes of rebloggers' followers for delete forwarding * Adjust test * Fix wrong class, bad SQL, wrong variable, outdated comment	7 years ago
Eugen Rochko	58cede4808	Profile redirect notes (#5746) ... * Serialize moved accounts into REST and ActivityPub APIs * Parse federated moved accounts from ActivityPub * Add note about moved accounts to public profiles * Add moved account message to web UI * Fix code style issues	7 years ago
Renato "Lond" Cerqueira	ad207456d6	Improve language filter (#5724) ... * Scrub text of html before detecting language. * Detect language on statuses coming from activitypub. * Fix rubocop comments. * Remove custom emoji from text before language detection	7 years ago
puckipedia	0cb329f63a	Allow ActivityPub Note's tag and attachment to be single objects (#5534)	7 years ago
Eugen Rochko	484208ce12	When status is fetched instead of delivered, do not stream it (#5437)	7 years ago
unarist	8125fdc19f	Use atomUri in Undo activity of Announce (#5376) ... This allows deletion of reblogs which delivered before with OStatus URI.	7 years ago
Eugen Rochko	0717d9b3e6	Set snowflake IDs for backdated statuses (#5260) ... - Rename Mastodon::TimestampIds into Mastodon::Snowflake for clarity - Skip for statuses coming from inbox, aka delivered in real-time - Skip for statuses that claim to be from the future	7 years ago
Eugen Rochko	3a3475450e	Encode custom emojis as resolveable objects in ActivityPub (#5243) ... * Encode custom emojis as resolveable objects in ActivityPub * Improve code style	7 years ago
Akihiko Odaki	63f0979799	Validate id of ActivityPub representations (#5114) ... Additionally, ActivityPub::FetchRemoteStatusService no longer parses activities. OStatus::Activity::Creation no longer delegates to ActivityPub because the provided ActivityPub representations are not signed while OStatus representations are.	7 years ago
Eugen Rochko	4ec1771165	Add ability to specify alternative text for media attachments (#5123) ... * Fix #117 - Add ability to specify alternative text for media attachments - POST /api/v1/media accepts `description` straight away - PUT /api/v1/media/:id to update `description` (only for unattached ones) - Serialized as `name` of Document object in ActivityPub - Uploads form adjusted for better performance and description input * Add tests * Change undo button blend mode to difference	7 years ago
Eugen Rochko	cf7fbf2c56	Fix #5059 - Stop processing payload if it's from local account (#5100)	7 years ago
Akihiko Odaki	98936bfcdf	Add missing validations in ActivityPub::Activity::Create (#5096)	7 years ago
Akihiko Odaki	bb4d005a83	Introduce OStatus::TagManager (#5008)	7 years ago
Eugen Rochko	dce869dfc7	Define emoji context for ActivityPub (#5004) ... * Define emoji context for ActivityPub * Fix the emojo * Use general Mastodon context instead	7 years ago
Eugen Rochko	81cec35dbf	Custom emoji (#4988) ... * Custom emoji - In OStatus: `<link rel="emoji" name="coolcat" href="http://..." />` - In ActivityPub: `{ type: "Emoji", name: ":coolcat:", href: "http://..." }` - In REST API: Status object includes `emojis` array (`shortcode`, `url`) - Domain blocks with reject media stop emojis - Emoji file up to 50KB - Web UI handles custom emojis - Static pages render custom emojis as `<img />` tags Side effects: - Undo #4500 optimization, as I needed to modify it to restore shortcode handling in emojify() - Formatter#plaintext should now make sure stripped out line-breaks and paragraphs are replaced with newlines * Fix emoji at the start not being converted	7 years ago
unarist	17bf3363ac	Add published property to ActivityPub activity for reblogs (#5000) ... Since reblogs are serialized as Announce activity, its published property can be used for the creation time of reblog.	7 years ago
unarist	3f07f1b2b1	Raise an error on getting activity uri for remote status (#4984) ... We had returned `nil` for that case, but this raises an error instead, as a wrong usage of the method. This method is currently only used in ActivitySerializer.	8 years ago
ThibG	4a73615193	Fix race condition when receiving an ActivityPub Create multiple times (#4930) ... * Fix race condition when receiving an ActivityPub Create multiple times * Use a RedisLock to avoid concurrent processing of a same Create activity	8 years ago
Eugen Rochko	881856553e	Fix #4894 - Merge context hash into final JSON hash after key transform (#4898)	8 years ago
unarist	a12572e074	Handle stream_entry URL correctly in ActivityPub (#4854) ... In before, the method uses stream_entry id as status id, so replied status was wrongly selected. This PR uses StatusFinder which was introduced with `Api::Web::EmbedsController`.	8 years ago
Eugen Rochko	9b50a9dd83	Fix some ActivityPub JSON bugs (#4796) ... - Fix assumption that `url` is always a string. Handle it if it's an array of strings, array of objects, object, or string, both for accounts and for objects - `sharedInbox` is actually supposed to be under `endpoints`, handle both cases and adjust the serializer	8 years ago
Eugen Rochko	37fdddd927	Rename "locked" to "manuallyApprovesFollowers" in ActivityPub (#4779) ... See: <https://www.w3.org/wiki/Activity_Streams_extensions#as:manuallyApprovesFollowers>	8 years ago
Eugen Rochko	d3b6746173	Make "unfollow" undo pending outgoing follow request too (#4781) ... * Make "unfollow" undo pending outgoing follow request too * Add cancel button to web UI when awaiting follow request approval * Make the hourglass button do the cancelling	8 years ago
Eugen Rochko	1b5806b744	Define missing JSON-LD properties (#4767) ... Using _: property names is discouraged, as in the future, canonicalization may throw an error when encountering that instead of discarding it silently like it does now. We are defining some ActivityStreams properties which we expect to land in ActivityStreams eventually, to ensure that future versions of Mastodon will remain compatible with this even once that happens. Those would be `locked`, `sensitive` and `Hashtag` We are defining a custom context inline for some properties which we do not expect to land in any other context. `atomUri`, `inReplyToAtomUri` and `conversation` are part of the custom defined OStatus context.	8 years ago
Eugen Rochko	e482595a5d	Add ActivityPub handler for Delete->Actor activities (#4761)	8 years ago
Eugen Rochko	c2980d5b17	Do not rely on activity arriving exactly once after delete arrived (#4754)	8 years ago
unarist	8fd8f81ae7	Deduplicate with local status on Create activity (#4763)	8 years ago
Eugen Rochko	9a5ae09620	Remove identity context from output of LinkedDataSignature (#4753)	8 years ago
Eugen Rochko	7b8f262840	Forward ActivityPub creates that reply to local statuses (#4709) ... * Forward ActivityPub creates that reply to local statuses * Fix test * Fix wrong signers	8 years ago
unarist	938cd2875b	Fix Delete activity handling when the status has been reblogged (#4729)	8 years ago
unarist	f095a9f8a5	Allow Symbol keyed Hash in LinkedDataSignature (#4715) ... SerializarbleResource#as_json serializes to Symbol keyed Hash, but current implementation of LinkedDataSignature expects String keyed Hash. So it generates broken payload.	8 years ago
Eugen Rochko	0d5d11eeff	Add _:inReplyToAtomUri to ActivityPub (#4702)	8 years ago
Eugen Rochko	0397c58b61	Forward ActivityPub deletes to followers of rebloggers (#4706)	8 years ago
Eugen Rochko	884b085f53	Use Tombstone and _:atomUri in Delete activities as fallback (#4704)	8 years ago
Eugen Rochko	00840f4f2e	Add handling of Linked Data Signatures in payloads (#4687) ... * Add handling of Linked Data Signatures in payloads * Add a way to sign JSON, fix canonicalization of signature options * Fix signatureValue encoding, send out signed JSON when distributing * Add missing security context	8 years ago
unarist	b01a19fe39	Fetch reblogs as Announce activity instead of Note object (#4672) ... * Process Create / Announce activity in FetchRemoteStatusService * Use activity URL in ActivityPub for reblogs * Redirect to the original status on StatusesController#show	8 years ago
unarist	d63de55ef8	Fix bugs which OStatus accounts may detected as ActivityPub ready (#4662) ... * Fallback to OStatus in FetchAtomService * Skip activity+json link if that activity is Person without inbox * If unsupported activity was detected and all other URLs failed, retry with ActivityPub-less Accept header * Allow mention to OStatus account in ActivityPub * Don't update profile with inbox-less Person object	8 years ago
Eugen Rochko	72bb3e03fd	Support more variations of ActivityPub keyId in signature (#4630) ... - Tries to avoid performing HTTP request if the keyId is an actor URI - Likewise if the URI is a fragment URI on top of actor URI - Resolves public key, returns owner if the owner links back to the key	8 years ago
Eugen Rochko	fe5b66aa08	Handle duplicate ActivityPub activities (#4639) ... * Handle duplicate ActivityPub activities Only perform side-effects when record processed for the first time * Fast-forward repeat follow requests	8 years ago
Eugen Rochko	412ea87306	Improve ActivityPub/OStatus compatibility (#4632) ... *Note: OStatus URIs are invalid for ActivityPub. But we have them for as long as we want to keep old OStatus-sourced content and as long as we remain OStatus-compatible.* - In Announce handling, if object URI is not a URL, fallback to object URL - Do not use specialized ThreadResolveWorker, rely on generalized handling - When serializing notes, if parent's URI is not a URL, use parent's URL	8 years ago
Eugen Rochko	c7d2619ab1	Parse OStatus tag URIs in ActivityPub handlers when those are local (#4631)	8 years ago
Eugen Rochko	4edf9d849f	Make ActivityPub::TagManager#local_uri? recognize local URIs with ports (#4628)	8 years ago
Eugen Rochko	10489b4e4a	If url attribute not present in Note, fallback to id attribute (#4629)	8 years ago
Eugen Rochko	40c45f5dd9	Put ActivityPub alternate link into Atom, prefer it when processing Atom (#4623)	8 years ago
Eugen Rochko	ad892dbc0c	Add _:atomUri property for deduplicating OStatus/ActivityPub legacy records (#4593)	8 years ago
unarist	a855956185	Fix ActivityPub follow interaction and add more specs (#4601)	8 years ago
Eugen Rochko	b7370ac8ba	ActivityPub delivery (#4566) ... * Deliver ActivityPub Like * Deliver ActivityPub Undo-Like * Deliver ActivityPub Create/Announce activities * Deliver ActivityPub creates from mentions * Deliver ActivityPub Block/Undo-Block * Deliver ActivityPub Accept/Reject-Follow * Deliver ActivityPub Undo-Follow * Deliver ActivityPub Follow * Deliver ActivityPub Delete activities Incidentally fix #889 * Adjust BatchedRemoveStatusService for ActivityPub * Add tests for ActivityPub workers * Add tests for FollowService * Add tests for FavouriteService, UnfollowService and PostStatusService * Add tests for ReblogService, BlockService, UnblockService, ProcessMentionsService * Add tests for AuthorizeFollowService, RejectFollowService, RemoveStatusService * Add tests for BatchedRemoveStatusService * Deliver updates to a local account to ActivityPub followers * Minor adjustments	8 years ago
Eugen Rochko	ccdd5a9576	Add serializing/unserializing of "locked" actor attribute (#4585)	8 years ago
Eugen Rochko	81c1303cd6	Handle ActivityPub follows correctly (#4571) ... * Handle ActivityPub follows correctly ActivityPub follows are follow-requests. Always require an Accept. If account is not locked, auto-accept. * Handle ActivityPub Accept/Reject-Follow * Fix wrong method * Fix wrong class	8 years ago
Eugen Rochko	dd7ef0dc41	Add ActivityPub inbox (#4216) ... * Add ActivityPub inbox * Handle ActivityPub deletes * Handle ActivityPub creates * Handle ActivityPub announces * Stubs for handling all activities that need to be handled * Add ActivityPub actor resolving * Handle conversation URI passing in ActivityPub * Handle content language in ActivityPub * Send accept header when fetching actor, handle JSON parse errors * Test for ActivityPub::FetchRemoteAccountService * Handle public key and icon/image when embedded/as array/as resolvable URI * Implement ActivityPub::FetchRemoteStatusService * Add stubs for more interactions * Undo activities implemented * Handle out of order activities * Hook up ActivityPub to ResolveRemoteAccountService, handle Update Account activities * Add fragment IDs to all transient activity serializers * Add tests and fixes * Add stubs for missing tests * Add more tests * Add more tests	8 years ago
Eugen Rochko	8c45cd0e36	Improve ActivityPub representations (#3844) ... * Improve webfinger templates and make tests more flexible * Clean up AS2 representation of actor * Refactor outbox * Create activities representation * Add representations of followers/following collections, do not redirect /users/:username route if format is empty * Remove unused translations * ActivityPub endpoint for single statuses, add ActivityPub::TagManager for better URL/URI generation * Add ActivityPub::TagManager#to * Represent all attachments as Document instead of Image/Video specifically (Because for remote ones we may not know for sure) Add mentions and hashtags representation to AP notes * Add AP-resolvable hashtag URIs * Use ActiveModelSerializers for ActivityPub * Clean up unused translations * Separate route for object and activity * Adjust cc/to matrices * Add to/cc to activities, ensure announce activity embeds target status and not the wrapper status, add "id" to all collections	8 years ago