mastodon

Commit Graph

Author	SHA1	Message	Date
ThibG	3aaac4f134	Do not allow adding votes to expired polls (#10214 ) * Do not allow adding votes to expired polls * Only validate expires_at on create	6 years ago
ThibG	34f261e6af	Avoid unnecessarily fetching the replies collection when it is empty (#10201 )	6 years ago
ThibG	efd0fb8088	Fix newlines in OStatus and RSS serializations (#10183 )	6 years ago
ThibG	636db1f54f	When serializing polls over OStatus, serialize poll options to text (#10160 ) * When serializing polls over OStatus, serialize poll options to text * Do the same for RSS feeds * Use “[ ] ” as a prefix for poll options instead of “- ”	6 years ago
ThibG	833ffce2df	Store remote votes URI (#10158 ) * Store remote votes URI * Add spec for accepting remote votes * Make poll vote id generation work the same way as follows	6 years ago
Eugen Rochko	0e6998da3c	Add tests for ActivityPub poll processing (#10143 )	6 years ago
Eugen Rochko	ae1b9cf70a	Fix remote poll expiration time (#10144 )	6 years ago
Eugen Rochko	230a012f00	Add polls (#10111 ) * Add polls Fix #1629 * Add tests * Fixes * Change API for creating polls * Use name instead of content for votes * Remove poll validation for remote polls * Add polls to public pages * When updating the poll, update options just in case they were changed * Fix public pages showing both poll and other media	6 years ago
ThibG	d8498b3983	Give the `replies` collection an identifier and enable pagination (#10128 )	6 years ago
ThibG	9d3c6f1849	Improved remote thread fetching (#10106 ) * Fetch up to 5 replies when discovering a new remote status This is used for resolving threads downwards. The originating server must add a “replies” attributes with such replies for it to be useful. * Add some tests for ActivityPub::FetchRepliesWorker * Add specs for ActivityPub::FetchRepliesService * Serialize up to 5 public self-replies for ActivityPub notes * Add specs for ActivityPub::NoteSerializer * Move exponential backoff logic to a worker concern * Fetch first page of paginated collections when fetching thread replies * Add specs for paginated collections in replies * Move Note replies serialization to a first CollectionPage The collection isn't actually paginable yet as it has no id nor a `next` field. This may come in another PR. * Use pluck(:uri) instead of map(&:uri) to improve performances * Fix fetching replies when they are in a CollectionPage	6 years ago
ThibG	9edab46368	Fix mention processing for unknwon accounts on incoming ActivityPub Notes (#10125 ) `::FetchRemoteAccountService` is not `ActivityPub::FetchRemoteAccountService`, its second argument is the pre-fetched body. Passing `id: false` actually passed a `Hash` as the prefetched body, instead of properly resolving unknown remote accounts.	6 years ago
Eugen Rochko	1a1b8170bb	Fix Announce activities of unknown statuses not fetching those statuses (#10065 ) Regression from #9998	6 years ago
Eugen Rochko	147b4c2c3a	Add logging for rejected ActivityPub payloads and add tests (#10062 )	6 years ago
Eugen Rochko	c417e8c198	Filter incoming Announce activities by relation to local activity (#10041 ) * Filter incoming Announce activities by relation to local activity Reject if announcer is not followed by local accounts, and is not from an enabled relay, and the object is not a local status Follow-up to #10005 * Fix tests	6 years ago
Eugen Rochko	dad339da6d	Filter incoming Create activities by relation to local activity (#10005 ) Reject those from accounts with no local followers, from relays that are not enabled, which do not address local accounts and are not replies to accounts that do have local followers	6 years ago
ThibG	6a5307a573	Alternative handling of private self-boosts (#9998 ) * When self-boosting, embed original toot into Announce serialization * Process unknown self-boosts from Announce object if it is more than an URI * Add some self-boost specs * Only serialize private toots in self-Announces	6 years ago
Eugen Rochko	016ad37bc8	Fix URL linkifier grabbing full-width spaces and quotations (#9997 ) Fix #9993 Fix #5654	6 years ago
Hinaloe	157d3af46c	Only URLs extract with pre-escaped text (#9991 ) * [test] add japanese hashtag testcase * Only URLs extract with pre-escaped text ( https://github.com/tootsuite/mastodon/issues/9989 )	6 years ago
ThibG	ed30110618	Make displaying application used to toot opt-in (#9897 ) * Make storing and displaying application used to toot opt-in * Revert to storing application info, and display it to the author via API	6 years ago
ysksn	bcfff65195	Create Redisable#redis (#9633 ) * Create Redisable * Use #redis instead of Redis.current	6 years ago
Jakub Mendyk	6a5e3da6b0	Allow most kinds of characters in URL query (fixes #8408 ) (#8447 ) * Allow unicode characters in URL query strings Fixes #8408 * Alternative approach to unicode support in urls Adds PoC/idea to approch this problem.	6 years ago
ThibG	75b1488cf4	Add tombstones for remote statuses (#9830 ) * Add Tombstone model to remember object deletion * Do not recreate a status if it has been deleted * Record Tombstone for remote deleted items Also, only record deleted items from same-host actors * Clear an user's tombstones when their key change	6 years ago
Eugen Rochko	31f396b57d	Add support for non-public reblogs from ActivityPub (#9841 ) Fix #9838	6 years ago
Eugen Rochko	4ab42287c0	Use summary as summary for converted ActivityPub objects (#9823 ) Fix #8609	6 years ago
ThibG	a4f07bad95	Reduce chances of race conditions when processing deleted toots (#9815 ) * Reduce chances of race conditions when processing deleted toots * Prevent race condition when processing deleted toots	6 years ago
ThibG	70be301d69	Ensure blocked user unfollows blocker if Block/Undo Block are processed out of order (#9687 ) * Ensure blocked user unfollows blocker if Block/Undo Block are processed out of order * Add specs for Block causing unfollow and for out-of-order Block + Undo	6 years ago
ThibG	b2f4114550	Do not ignore federated reports targetting already-reported accounts (#9534 )	6 years ago
ThibG	290932602b	Reduce usage of LD signatures (#9659 ) * Do not LDS-sign Follow, Accept, Reject, Undo, Block * Do not use LDS for Create activities of private toots * Minor cleanup * Ignore unsigned activities instead of misattributing them * Use status.distributable? instead of querying visibility directly	6 years ago
Eugen Rochko	0f938ff29c	Add handler for Move activity (#9629 )	6 years ago
Eugen Rochko	aa9a20cde0	Fix ThreadResolveWorker getting queued with invalid URLs (#9628 )	6 years ago
ThibG	81bda7d67c	Add setting to not aggregate reblogs (#9248 ) * Add setting to not aggregate reblogs Fixes #9222 * Handle cases where user is nil in add_to_home and add_to_list * Add hint for setting_aggregate_reblogs option * Reword setting_aggregate_reblogs label	6 years ago
Eugen Rochko	c39d7e7b2b	Fix TLS handshake timeout not being enforced (#9381 ) Follow-up to #9329	6 years ago
Eugen Rochko	43c311b3a1	Fix nil error when no DNS addresses are found for host (#9379 )	6 years ago
Eugen Rochko	fd8145d232	Fix connect timeout not being enforced (#9329 ) * Fix connect timeout not being enforced The loop was catching the timeout exception that should stop execution, so the next IP would no longer be within a timed block, which led to requests taking much longer than 10 seconds. * Use timeout on each IP attempt, but limit to 2 attempts * Fix code style issue * Do not break Request#perform if no block given * Update method stub in spec for Request * Move timeout inside the begin/rescue block * Use Resolv::DNS with timeout of 1 to get IP addresses * Update Request spec to stub Resolv::DNS instead of Addrinfo * Fix Resolve::DNS stubs in Request spec	6 years ago
ThibG	466e3d710c	Include replies to list owner and replies to list members in list statuses (#9324 )	6 years ago
Eugen Rochko	384e953b75	Revert connect timeout from 1s to 10s (#9319 ) The failure rate in Sidekiq is too high	6 years ago
Eugen Rochko	9311430ed7	Prevent multiple handlers for Delete of Actor from running (#9292 )	6 years ago
Eugen Rochko	8069fd636b	Remove intermediary arrays when creating hash maps from results (#9291 )	6 years ago
ThibG	7f5a4be580	Fix emoji update date processing (#9255 )	6 years ago
Eugen Rochko	4615512285	Reduce connect timeout limit and limit signature failures by source IP (#9236 ) * Reduce connect timeout from 10s to 1s * Limit failing signature verifications per source IP	6 years ago
Eugen Rochko	be202f9377	Accept the same payload in multiple inboxes and deliver (#9150 )	6 years ago
m.b	2b18f5f85d	Add Page AP type support (#9121 )	6 years ago
ThibG	e53cc673e7	Ignore invalid hashtags on remote statuses instead of rejecting them (#9118 ) Fixes #9115	6 years ago
ThibG	82e7988afc	Fix missing `mention` argument when processing incoming Create activities (#9114 ) * Fix missing `mention` argument when processing incoming Create activities * Fix typo (param → params)	6 years ago
Eugen Rochko	d4cf963749	Allow inbox owner to view implicitly targeted ActivityPub payload (#9093 ) Fix #9091	6 years ago
Eugen Rochko	fd5285658f	Add option to block reports from domain (#8830 )	6 years ago
Eugen Rochko	ddd30f331c	Improve support for aspects/circles (#8950 ) * Add silent column to mentions * Save silent mentions in ActivityPub Create handler and optimize it Move networking calls out of the database transaction * Add "limited" visibility level masked as "private" in the API Unlike DMs, limited statuses are pushed into home feeds. The access control rules between direct and limited statuses is almost the same, except for counter and conversation logic * Ensure silent column is non-null, add spec * Ensure filters don't check silent mentions for blocks/mutes As those are "this person is also allowed to see" rather than "this person is involved", therefore does not warrant filtering * Clean up code * Use Status#active_mentions to limit returned mentions * Fix code style issues * Use Status#active_mentions in Notification And remove stream_entry eager-loading from Notification	6 years ago
Eugen Rochko	21ad21cb50	Improve signature verification safeguards (#8959 ) * Downcase signed_headers string before building the signed string The HTTP Signatures draft does not mandate the “headers” field to be downcased, but mandates the header field names to be downcased in the signed string, which means that prior to this patch, Mastodon could fail to process signatures from some compliant clients. It also means that it would not actually check the Digest of non-compliant clients that wouldn't use a lowercased Digest field name. Thankfully, I don't know of any such client. * Revert "Remove dead code (#8919)" This reverts commit `a00ce8c92c`. * Restore time window checking, change it to 12 hours By checking the Date header, we can prevent replaying old vulnerable signatures. The focus is to prevent replaying old vulnerable requests from software that has been fixed in the meantime, so a somewhat long window should be fine and accounts for timezone misconfiguration. * Escape users' URLs when formatting them Fixes possible HTML injection * Escape all string interpolations in Formatter class Slightly improve performance by reducing class allocations from repeated Formatter#encode calls * Fix code style issues	6 years ago
Eugen Rochko	61d44dd11f	Fix typo in ActivityPub Create handler (#8952 ) Regression from #8951	6 years ago
Eugen Rochko	790d3bc637	Move network calls out of transaction in ActivityPub handler (#8951 ) Mention and emoji code may perform network calls, but does not need to do that inside the database transaction. This may improve availability of database connections when using pgBouncer in transaction mode.	6 years ago

1 2 3 4 5 ...

427 Commits (3aaac4f134eb092baeb0ba5979bdb3abd702a4ee)