677 Commits (20dda5cca0a4015a743250b4e584a3101e7675f2)

Author	SHA1	Message	Date
Renato "Lond" Cerqueira	5c5e14c816	Fix undefined method error in sidekiq (#9807) ... * Fix undefined method error in sidekiq Body can be not nil but still be empty, which causes a `NoMethodError: undefined method `[]' for nil:NilClass` further in the code. This checks for an empty body to avoid the issue. * Fix codeclimate issue	6 years ago
ThibG	28b482874a	Improvements to signature verification (#9667) ... * Refactor signature verification a bit * Rescue signature verification if recorded public key is invalid Fixes #8822 * Always re-fetch AP signing key when HTTP Signature verification fails But when the account is not marked as stale, avoid fetching collections and media, and avoid webfinger round-trip. * Apply stoplight to key/account update as well as initial key retrieval	6 years ago
Eugen Rochko	43c61bca60	Add locale param to sign-up API (#9747) ... Fix #9627	6 years ago
Eugen Rochko	1cbdf8d218	Fix wrong param name in scheduled statuses and return params in API (#9725) ... The database column and API param are called in_reply_to_id, not in_reply_to_status_id, so it makes no sense to encode it that way	6 years ago
Eugen Rochko	a49d43d112	Add scheduled statuses (#9706) ... Fix #340	6 years ago
Naoki Kosaka	fae32634b1	Use Contact User as Relay, Report, Subscribe. (#9661) ... * Use Contact User as Relay, Report, Subscribe. * Use Account.representative to fetch contact user. * Use find_local. * No reason to use Account.representative in subscribe_service. * Don't required representative! * Fallback is included in Account.representative method.	6 years ago
kodai	6a090db4c9	Fix links not being verified (#9673) ... Fix #9365	6 years ago
Jeong Arm	511231ce57	Skip full text search if failed (#9654) ... * Skip full text search if failed * Move rescue block to "perform_statuses_search!"	6 years ago
ThibG	6fb6a53938	Avoid duplicate work by merging ReplyDistributionWorker into DistributionWorker (#9660)	6 years ago
ThibG	290932602b	Reduce usage of LD signatures (#9659) ... * Do not LDS-sign Follow, Accept, Reject, Undo, Block * Do not use LDS for Create activities of private toots * Minor cleanup * Ignore unsigned activities instead of misattributing them * Use status.distributable? instead of querying visibility directly	6 years ago
Eugen Rochko	0f938ff29c	Add handler for Move activity (#9629)	6 years ago
Eugen Rochko	6e49907ecf	Improve admin UI for account view (#9643)	6 years ago
Eugen Rochko	5d2fc6de32	Add REST API for creating an account (#9572) ... * Add REST API for creating an account The method is available to apps with a token obtained via the client credentials grant. It creates a user and account records, as well as an access token for the app that initiated the request. The user is unconfirmed, and an e-mail is sent as usual. The method returns the access token, which the app should save for later. The REST API is not available to users with unconfirmed accounts, so the app must be smart to wait for the user to click a link in their e-mail inbox. The method is rate-limited by IP to 5 requests per 30 minutes. * Redirect users back to app from confirmation if they were created with an app * Add tests * Return 403 on the method if registrations are not open * Require agreement param to be true in the API when creating an account	6 years ago
ThibG	5f387995d9	Limit maximum visibility of local silenced users to unlisted (#9583) ... Fixes #9580	6 years ago
ThibG	e709b8da0d	Ignore low-confidence CharlockHolmes guesses when parsing link cards (#9510) ... * Add failing test for windows-1251 link cards * Ignore low-confidence CharlockHolmes guesses Fixes #9466 * Fix no method error when charlock holmes cannot detect charset	6 years ago
Sumit Khanna	769c2d2680	Error message for avatar image that's too large. #9204 (#9518) ... * Error message for avatar image that's too large. #9204 * Code climate/formatting * Removed avatar error message * Moved valid image dimentions check to update service * removed unnescessary begin block * code climate formatting * code climate indent fix	6 years ago
ysksn	83975a2394	Remove redundant (#9503)	6 years ago
ysksn	351ed12b2f	Use find_or_initialize_by (#9504)	6 years ago
Eugen Rochko	73be8f38c1	Add profile directory (#9427) ... Fix #5578	6 years ago
Eugen Rochko	6ddf0432e7	Improve account suspension speed and completeness (#9290) ... - Some associations were missing from the clean-up - Some attributes were not reset on suspension - Skip federation and streaming deletes when purging a dead domain - Move account association definitions to concern	6 years ago
valerauko	824497fbce	Ignore JSON-LD profile in mime type comparison (#9179) ... Ignore JSON-LD profile in mime type comparison	6 years ago
James Kiesel	6a65d87f4d	Simplify hashtag query service, perf increase for 'any' tags (#9298)	6 years ago
Eugen Rochko	8069fd636b	Remove intermediary arrays when creating hash maps from results (#9291)	6 years ago
ThibG	7f5a4be580	Fix emoji update date processing (#9255)	6 years ago
ThibG	9b89c62d43	Check that twitter:player is valid before using it (#9254) ... Fixes #9251	6 years ago
Eugen Rochko	6d59dfa15d	Optimize the process of following someone (#9220) ... * Eliminate extra accounts select query from FollowService * Optimistically update follow state in web UI and hide loading bar Fix #6205 * Asynchronize NotifyService in FollowService And fix failing test * Skip Webfinger resolve routine when called from FollowService if possible If an account is ActivityPub, then webfinger re-resolving is not necessary when called from FollowService. Improve options of ResolveAccountService	6 years ago
m.b	cd41c2c6ad	Update resolve_url_service.rb (#9188)	6 years ago
James Kiesel	4c03e05a4e	Allow joining several hashtags in a single column (#8904) ... * Nascent tag menu on frontend * Hook up frontend to search * Tag intersection backend first pass * Update yarnlock * WIP * Fix for tags not searching correctly * Make radio buttons function * Simplify radio buttons with modeOption * Better naming * Rearrange options * Add all/any/none functionality on backend * Small PR cleanup * Move to service from scope * Small cleanup, add proper service tests * Don't use send with user input :D * Set appropriate column header * Handle auto updating timeline * Fix up toggle function * Use tag value correctly * A bit more correct to use 'self' rather than 'all' in status scope * Fix some style issues * Fix more code style issues * Style select dropdown more better * Only use to_id'ed value to ensure no SQL injection * Revamp frontend to allow for multiple selects * Update backend / col header to account for more flexible tagging * Update brakeman ignore * Codeclimate suggestions * Fix presenter tag_url * Implement initial PR feedback * Handle additional tag streaming * CodeClimate tweak	6 years ago
Eugen Rochko	ce2ee68b64	Revert "Fix FetchAtomService content type handling (#9132)" (#9171) ... This reverts commit c36a4a1617.	6 years ago
valerauko	c36a4a1617	Fix FetchAtomService content type handling (#9132) ... * Add profile to json+ld in Accept It's required by the ActivityPub spec * Use headers['Content-type'] instead of mime_type mime_type strips the profile from the content type, but it's still available raw in the headers hash * Add test for ld+json with profile	6 years ago
Eugen Rochko	be202f9377	Accept the same payload in multiple inboxes and deliver (#9150)	6 years ago
Eugen Rochko	47b8d195e6	Always let through notifications from staff (#9152) ... * Always let through notifications from staff Follow-up to #8993 * Let messages from staff through, but no other notifications	6 years ago
ThibG	a03d506626	Fix Pleroma mentions being fetched as preview cards (#9158)	6 years ago
ThibG	33a71e8f7c	Do not hide boost notifications from followed people with hidden boosts (#9147) ... * Do not hide boost notifications from followed people with hidden boosts Not displaying boosts from a followed user in the Home timeline and not having notifications when they reblog your own content are two very separate concerns, tying them together seem counter-intuitive and unwanted. * Update specs accordingly	6 years ago
Eugen Rochko	795f0107d2	Include preview cards in status entity in REST API (#9120) ... * Include preview cards in status entity in REST API * Display preview card in-stream * Improve in-stream display of preview cards	6 years ago
Eugen Rochko	eef8d9a5f7	Add locality check to ActivityPub::FetchRemoteAccountService (#9109) ... * Add locality check to ActivityPub::FetchRemoteAccountService Fix #8643 Because there are a few places where it is called, it is difficult to confirm if they all previously checked it for locality. It's better to make sure within the service. * Remove faux-remote duplicates of local accounts	6 years ago
abcang	1e2695198a	Skip link-back check if body is nil (#9107)	6 years ago
ThibG	7fee968e9f	Do not fetch preview card for mentioned users (#6934)	6 years ago
Eugen Rochko	ddd30f331c	Improve support for aspects/circles (#8950) ... * Add silent column to mentions * Save silent mentions in ActivityPub Create handler and optimize it Move networking calls out of the database transaction * Add "limited" visibility level masked as "private" in the API Unlike DMs, limited statuses are pushed into home feeds. The access control rules between direct and limited statuses is almost the same, except for counter and conversation logic * Ensure silent column is non-null, add spec * Ensure filters don't check silent mentions for blocks/mutes As those are "this person is also allowed to see" rather than "this person is involved", therefore does not warrant filtering * Clean up code * Use Status#active_mentions to limit returned mentions * Fix code style issues * Use Status#active_mentions in Notification And remove stream_entry eager-loading from Notification	6 years ago
Quint Guvernator	f5e2e96e95	always allow DMs from staff (#8993)	6 years ago
Eugen Rochko	87fdd139b8	Do not push DMs into the home feed (#8940) ... * Do not push DMs into the home feed * Show DMs column after sending a DM, if DMs column is not already shown	6 years ago
Eugen Rochko	774ac47373	Add conversations API (#8832) ... * Add conversations API * Add web UI for conversations * Add test for conversations API * Add tests for ConversationAccount * Improve web UI * Rename ConversationAccount to AccountConversation * Remove conversations on block and mute * Change last_status_id to be a denormalization of status_ids * Add optimistic locking	6 years ago
Eugen Rochko	7fe137d2f7	Fix link verification for remote accounts (#8868)	6 years ago
Eugen Rochko	f92f1ee80a	Support link verification with redirects (#8735) ... (e.g. URL shortener)	6 years ago
Yamagishi Kazutoshi	3da1cc7d5e	Fix failed profile verification when rel attribute including values other than me (#8733)	6 years ago
Eugen Rochko	68833a50d4	Fix VerifyAccountLinksWorker not being queued (#8721) ... UX-wise, people expect that saving the profile will re-check links even without changing fields content. Bug-wise, `@account` was undefined. Regression from #8703	6 years ago
Eugen Rochko	f4d549d300	Redesign forms, verify link ownership with rel="me" (#8703) ... * Verify link ownership with rel="me" * Add explanation about verification to UI * Perform link verifications * Add click-to-copy widget for verification HTML * Redesign edit profile page * Redesign forms * Improve responsive design of settings pages * Restore landing page sign-up form * Fix typo * Support <link> tags, add spec * Fix links not being verified on first discovery and passive updates	6 years ago
ThibG	bd9e47e9be	Handle relative URLs when fetching OEmbed/OpenGraph cards (#8669)	7 years ago
Eugen Rochko	c593d6df9c	Add preference for report notification e-mails, skip for duplicates (#8559) ... If an unresolved report for the same target account already exists, no new notification is generated	7 years ago
Eugen Rochko	cabdbb7f9c	Add CLI task for rotating keys (#8466) ... * If an Update is signed with known key, skip re-following procedure Because it means the remote actor did *not* lose their database * Add CLI method for rotating keys bin/tootctl accounts rotate [USERNAME] Generates a new RSA key per account and sends out an Update activity signed with the old key. * Key rotation: Space out Update fan-outs every 5 minutes per 1000 accounts * Skip suspended accounts in key rotation	7 years ago
Eugen Rochko	8adf485c0f	Bump interactions count when a follow happens (#8468)	7 years ago
Eugen Rochko	55c856c522	Delay e-mail notifications by 2 minutes (#8438) ... Fix #8430	7 years ago
ThibG	42573b76f1	Do not crash if remote custom emoji does not define updated date (fixes #8376) (#8377)	7 years ago
Eugen Rochko	802cf6a4c5	Improve federated ID validation (#8372) ... * Fix URI not being sufficiently validated with prefetched JSON * Add additional id validation to OStatus documents, when possible	7 years ago
Eugen Rochko	1b282299df	Add favourites to archive takeout (#8351) ... Remove experimental key export	7 years ago
Eugen Rochko	d98de8ada7	Get rid of all batch order warnings (#8334)	7 years ago
Eugen Rochko	6226aa83d7	Increase reach of Delete->Actor activities (#8305) ... Fix #7316	7 years ago
ThibG	abc5548cca	Do not process outgoing mentions to suspended accounts (#8272)	7 years ago
ThibG	1ee675d68b	Use correct activity id in Accept when receiving duplicate Follow (fixes #8218) (#8244)	7 years ago
ThibG	af912fb308	Allow accessing local private/DM messages by URL (#8196) ... * Allow accessing local private/DM messages by URL (Provided the user pasting the URL is authorized to see the toot, obviously) * Fix SearchServiceSpec tests	7 years ago
Eugen Rochko	cc94b1d95a	Prevent ActivityPub movedTo recursion (#8092) ... Fix #8051	7 years ago
Eugen Rochko	a23ac107e4	Fix activity:interactions counter to count all interactions (#8037)	7 years ago
Eugen Rochko	e55dce3176	Add federation relay support (#7998) ... * Add federation relay support * Add admin UI for managing relays * Include actor on relay-related activities * Fix i18n	7 years ago
Eugen Rochko	8461cd4bb5	Send undo of boost to original poster if reblog (#7959) ... Fix #7874	7 years ago
Eugen Rochko	b0968623fa	Fix check for PotentialFriendshipTracker when replying (#7933)	7 years ago
Eugen Rochko	da8fe8079e	Re-add follow recommendations API (#7918) ... * Re-add follow recommendations API GET /api/v1/suggestions Removed in 8efa081f21 due to Neo4J dependency. The algorithm uses triadic closures, takes into account suspensions, blocks, mutes, domain blocks, excludes locked and moved accounts, and prefers more recently updated accounts. * Track interactions with people you don't follow Replying to, favouriting and reblogging someone you're not following will make them show up in follow recommendations. The interactions have different weights: - Replying is 1 - Favouriting is 10 (decidedly positive interaction, but private) - Reblogging is 20 Following them, muting or blocking will remove them from the list, obviously. * Remove triadic closures, ensure potential friendships are trimmed	7 years ago
Eugen Rochko	a58ec29631	Allow selecting default posting language instead of auto-detect (#7828) ... * Allow selecting default posting language instead of auto-detect * Enable default language setting in credentials API * Fix form saving	7 years ago
Eugen Rochko	ca85658975	Add autofollow option to invites (#7805) ... * Add autofollow option to invites * Trigger CodeClimate rebuild	7 years ago
Eugen Rochko	c3b3594305	Remove placeholder text for media-only toots (#7806) ... Ref: cfa9b6e13a This breaks compatibility with pre-2.3.0 Mastodon and older software, but at the time of writing the network is >80% above that version. Compatibility broken only for toots with no text.	7 years ago
Eugen Rochko	10f51c9886	Fix domain hiding logic (#7765) ... * Send rejections to followers when user hides domain they're on * Use account domain blocks for "authorized followers" action Replace soft-blocking (block & unblock) behaviour with follow rejection * Split sync and async work of account domain blocking Do not create domain block when removing followers by domain, that is probably unexpected from the user's perspective. * Adjust confirmation message for domain block * yarn manage:translations	7 years ago
Yamagishi Kazutoshi	e3fb528d12	Skip processing when HEAD method returns 501 (#7730)	7 years ago
Akihiko Odaki	5bf5003384	Do not mark remote status sensitive even if spoiler text is present (#7395) ... Old statuses and statuses from Pawoo, which runs a modified version of Mastodon, may not have been marked sensitive even if spoiler text is present. Such statuses are still not marked sensitve if they are local or arrived before version upgrade. Marking recently fetched remote status sensitive contradicts the behavior. Considering what people expected when they authored such statuses, this change removes the sensitivity enforcement.	7 years ago
Eugen Rochko	1e938b966e	Exclude unlisted, private and direct toots from affecting trends (#7686)	7 years ago
Eugen Rochko	a7d726c383	Improve counter caches on Status and Account (#7644) ... Do not touch statuses_count on accounts table when mass-destroying statuses to reduce load when removing accounts, same for reblogs_count and favourites_count Do not count statuses with direct visibility in statuses_count Fix #828	7 years ago
Eugen Rochko	461542784b	Reduce wasted work in RemoveStatusService due to inactive followers (#7672)	7 years ago
Eugen Rochko	9bd23dc4e5	Track trending tags (#7638) ... * Track trending tags - Half-life of 1 day - Historical usage in daily buckets (last 7 days stored) - GET /api/v1/trends Fix #271 * Add trends to web UI * Don't render compose form on search route, adjust search results header * Disqualify tag from trends if it's in disallowed hashtags setting * Count distinct accounts using tag, ignore silenced accounts	7 years ago
Eugen Rochko	32d4372381	Use #any? instead of #exists? when checking media attachments (#7570) ... If media_attachments are not loaded, SQL query is the same, but the #exists? method performs SQL query even if preloaded	7 years ago
Yamagishi Kazutoshi	7403e5d306	Add media timeline (#6631)	7 years ago
Akihiko Odaki	55fd55714a	Raise Mastodon::RaceConditionError if Redis lock failed (#7511) ... An explicit error allows user agents to know the error and Sidekiq to retry.	7 years ago
unarist	d47091eb97	Fix custom emoji handling in UpdateRemoteProfileService (OStatus) (#7501) ... This patch fixes NoMethodError and others in RemoteProfileUpdateWorker.	7 years ago
Wiktor	7fe2993b87	Fix account URI when updating ActivityPub account (#7488) ... Updates account `uri` field on each call to `update_account` instead of only once during `create_account` to mirror the same behavior in OStatus `ResolveAccountService` class [0]. ActivityPub accounts are identified using `@username` and `@domain` pair instead of URI since #6842. This fixes #7479: a bug when the account identified by `@username` and `@domain` changes its URI. [0]: 03b69ebc45/app/services/resolve_account_service.rb (L121)	7 years ago
abcang	3793e598d0	Call media.present? because media may be nil (#7474)	7 years ago
ThibG	7467361d70	Fetch boosted statuses on behalf of a follower (fixes #7426) (#7459) ... When an ActivityPub Announce is processed and the boosted toot is not known, fetch it on behalf of one of the booster's followers. This is to allow fetching self-boosts of previously-unknown private toots. If fetching on behalf of a user fails, try fetching it anonymously: the selected follower of a boosting user may be banned by the boosted toot's author.	7 years ago
Eugen Rochko	b4fb766b23	Add REST API for Web Push Notifications subscriptions (#7445) ... - POST /api/v1/push/subscription - PUT /api/v1/push/subscription - DELETE /api/v1/push/subscription - New OAuth scope: "push" (required for the above methods)	7 years ago
Yamagishi Kazutoshi	d2ee48977c	Rescue Mastodon::LengthValidationError in FetchLinkCardService (#7424)	7 years ago
Surinna Curtis	01dfd6dbc8	Take the first recognized actor_type. (#7410)	7 years ago
ThibG	993e68a7dd	Fix hashtags not being federated on mentions (fixes #6900) (#7406)	7 years ago
Eugen Rochko	42cd363542	Bot nameplates (#7391) ... * Store actor type in database * Add bot nameplate to web UI, add setting to preferences, API, AP Fix #7365 * Fix code style issues	7 years ago
Eugen Rochko	0f0cc3f2eb	Support explicitly supplying language code for status via REST API (#7389)	7 years ago
Eugen Rochko	c947e2e4c5	Fix handling of malformed ActivityPub payloads when URIs are nil (#7370) ... * Fix handling of malformed ActivityPub payloads when URIs are nil * Gracefully handle JSON-LD canonicalization failures	7 years ago
Eugen Rochko	c73ce7b695	Store home feeds for 7 days instead of 14 (#7354) ... * Store home feeds for 7 days instead of 14 Reduces workload for status fan-out to active followers * Fix test for user model	7 years ago
Eugen Rochko	658cbc9425	Improve PostStatusService performance (#7317) ... Offload creation of local notifications to a worker. Remove two redundant SQL queries from ProcessMentionsService, remove n+1 XML/JSON serialization via memoization	7 years ago
Eugen Rochko	cb5b5cb5f7	Slightly reduce RAM usage (#7301) ... * No need to re-require sidekiq plugins, they are required via Gemfile * Add derailed_benchmarks tool, no need to require TTY gems in Gemfile * Replace ruby-oembed with FetchOEmbedService Reduce startup by 45382 allocated objects * Remove preloaded JSON-LD in favour of caching HTTP responses Reduce boot RAM by about 6 MiB * Fix tests * Fix test suite by stubbing out JSON-LD contexts	7 years ago
abcang	71a7cea73f	Keep notification when muting_notifications is true (#7311) ... * Keep notification when muting_notifications is true * Retrun mute object * Fix test	7 years ago
Eugen Rochko	f62539ce5c	Remove most behaviour disparities between blocks and mutes (#7231) ... * Remove most behaviour disparities between blocks and mutes The only differences between block and mute should be: - Mutes can optionally NOT affect notifications - Mutes should not be visible to the muted Fix #7230 Fix #5713 * Do not allow boosting someone you blocked Fix #7248 * Do not allow favouriting someone you blocked * Fix nil error in StatusPolicy	7 years ago
Eugen Rochko	965345316f	Guard against nil URLs in Request class (#7284) ... Fix #7265	7 years ago
Surinna Curtis	dc786c0cf4	Support Actors/Statuses with multiple types (#7305) ... * Add equals_or_includes_any? helper in JsonLdHelper * Support arrays in JSON-LD type fields for actors/tags/objects. * Spec for resolving accounts with extension types * Style tweaks for codeclimate	7 years ago
Emelia Smith	495303d9b8	Prevent suspended accounts from appearing in AccountSearchService (#7246)	7 years ago
Eugen Rochko	75c4ab9d12	Remove "nsfw" category for sensitive statuses in OStatus serializer (#7048) ... Fix #7011	7 years ago
Eugen Rochko	ff87d1bc3e	Rescue SSL errors when processing mentions, remove useless line (#7184)	7 years ago