944 Commits (011b476d38663656988ae21ca29689aae01cb7c2)

Author	SHA1	Message	Date
ysksn	dd85700a3e	Add spec for AccountableConcern#log_action (#9559)	6 years ago
ThibG	e709b8da0d	Ignore low-confidence CharlockHolmes guesses when parsing link cards (#9510) ... * Add failing test for windows-1251 link cards * Ignore low-confidence CharlockHolmes guesses Fixes #9466 * Fix no method error when charlock holmes cannot detect charset	6 years ago
ysksn	0c80715235	Add spec for Api::V1::Timelines::DirectController (#9547)	6 years ago
ysksn	351938520d	Add specs for Api::V1::Instances::PeersController (#9546)	6 years ago
ysksn	2d871feb10	Add spec for Api::V1::EndorsementsController (#9543)	6 years ago
ysksn	3fa9615cb3	Add spec for Api::V1::Instances::ActivityController (#9545)	6 years ago
ysksn	a3dcbfddd6	Add specs for Accounts::PinsController (#9542)	6 years ago
ysksn	3c31c28605	Add spec for Admin::ActionLogsController#index (#9522)	6 years ago
ysksn	458e2b0c5b	Add specs for RemoteInteractionController (#9524)	6 years ago
ysksn	c1600a0f69	Add spec for Admin::DashboardController#index (#9523)	6 years ago
Sumit Khanna	769c2d2680	Error message for avatar image that's too large. #9204 (#9518) ... * Error message for avatar image that's too large. #9204 * Code climate/formatting * Removed avatar error message * Moved valid image dimentions check to update service * removed unnescessary begin block * code climate formatting * code climate indent fix	6 years ago
ysksn	795bac44fd	Add spec for Settings::ExportsController#create (#9512)	6 years ago
Adam Copp	7d00e4edbd	Make custom emoji domains case insensitive #9351 (#9474) ... * Make custom emoji domains case sensitive #9351 * Fixup style in downcase_domain to comply with codeclimate. * switch if! to unless * Don't use transactions, operate in batches. Also revert spurious schema change.	6 years ago
Eugen Rochko	dbb1ee269f	Improve e-mail MX validator and add tests (#9489)	6 years ago
ysksn	ed24bb2c3e	Add specs for activitypub collections controller (#9484) ... * Add specs for ActivityPub::CollectionsController#show * Raise ActiveRecord::RecordNotFound Raising ActiveRecord::NotFound raises NameError: uninitialized constant ActiveRecord::NotFound.	6 years ago
ysksn	6eae8f77af	Add spec for Admin::SuspentionsController#new (#9483)	6 years ago
ysksn	361818e931	Fix Admin::TagsController#unhide (#9481)	6 years ago
ysksn	ae3d2f446a	Add specs for Admin::InvitesController (#9471)	6 years ago
ysksn	dfd123d5b3	Remove pending spec (#9453)	6 years ago
ysksn	d3547fa005	Add specs for ActivityPub::InboxesController (#9456)	6 years ago
ysksn	88b3eed16f	Add specs for Admin::AccountModerationNotesHelper (#9455)	6 years ago
ysksn	57bb62d5cf	Remove pending spec (#9454) ... Since dots are not allowed in username, this spec is no longer needed.	6 years ago
ysksn	51cbd045da	Add specs for AccountTagStat model (#9452)	6 years ago
Eugen Rochko	73be8f38c1	Add profile directory (#9427) ... Fix #5578	6 years ago
ysksn	155cf12680	Remove pending spec (#9442) ... `#from_account` isn't defined.	6 years ago
ysksn	e2910dff12	Add spec for Identity.find_for_oauth (#9441)	6 years ago
ThibG	e88c6a5c3c	Fix thread depth computation in statuses_controller (#9426) ... * Add test that should currently fail * Fix depth computation (will still fail if statuses have been filtered out) * Fix handling of broken threads	6 years ago
ThibG	395615d9f3	Allow hyphens in the middle of remote user names (#9345) ... Fixes #9309 This only allows hyphens in the middle of a username, much like dots, although I don't have a compelling reason to do so other than keeping the changes minimal.	6 years ago
Eugen Rochko	73faadad28	Redesign admin accounts index (#9340) ... * Improve overview of accounts in admin UI - Display suspended status, role, last activity and IP prominently - Default to showing local accounts - Default to not showing suspended accounts * Remove unused strings * Fix tests * Allow filtering accounts by IP mask	6 years ago
valerauko	db9aea34de	Ensure replied-to is a status not a boost (#9129) ... * Ensure replied-to is a status not a boost * Consider case of not a reply * Add test case for replying to boost * Move reblog-reply resolution to model * Remove unnecessary comment	6 years ago
Eugen Rochko	0eaf6d7693	Sort self-replies to the top of descendants (#9320) ... Fix #6463	6 years ago
Eugen Rochko	fd8145d232	Fix connect timeout not being enforced (#9329) ... * Fix connect timeout not being enforced The loop was catching the timeout exception that should stop execution, so the next IP would no longer be within a timed block, which led to requests taking much longer than 10 seconds. * Use timeout on each IP attempt, but limit to 2 attempts * Fix code style issue * Do not break Request#perform if no block given * Update method stub in spec for Request * Move timeout inside the begin/rescue block * Use Resolv::DNS with timeout of 1 to get IP addresses * Update Request spec to stub Resolv::DNS instead of Addrinfo * Fix Resolve::DNS stubs in Request spec	6 years ago
valerauko	824497fbce	Ignore JSON-LD profile in mime type comparison (#9179) ... Ignore JSON-LD profile in mime type comparison	6 years ago
Eugen Rochko	d6b9a62e0a	Extract counters from accounts table to account_stats table (#9295)	6 years ago
Eugen Rochko	8069fd636b	Remove intermediary arrays when creating hash maps from results (#9291)	6 years ago
Eugen Rochko	6d59dfa15d	Optimize the process of following someone (#9220) ... * Eliminate extra accounts select query from FollowService * Optimistically update follow state in web UI and hide loading bar Fix #6205 * Asynchronize NotifyService in FollowService And fix failing test * Skip Webfinger resolve routine when called from FollowService if possible If an account is ActivityPub, then webfinger re-resolving is not necessary when called from FollowService. Improve options of ResolveAccountService	6 years ago
James Kiesel	4c03e05a4e	Allow joining several hashtags in a single column (#8904) ... * Nascent tag menu on frontend * Hook up frontend to search * Tag intersection backend first pass * Update yarnlock * WIP * Fix for tags not searching correctly * Make radio buttons function * Simplify radio buttons with modeOption * Better naming * Rearrange options * Add all/any/none functionality on backend * Small PR cleanup * Move to service from scope * Small cleanup, add proper service tests * Don't use send with user input :D * Set appropriate column header * Handle auto updating timeline * Fix up toggle function * Use tag value correctly * A bit more correct to use 'self' rather than 'all' in status scope * Fix some style issues * Fix more code style issues * Style select dropdown more better * Only use to_id'ed value to ensure no SQL injection * Revamp frontend to allow for multiple selects * Update backend / col header to account for more flexible tagging * Update brakeman ignore * Codeclimate suggestions * Fix presenter tag_url * Implement initial PR feedback * Handle additional tag streaming * CodeClimate tweak	6 years ago
Eugen Rochko	ce2ee68b64	Revert "Fix FetchAtomService content type handling (#9132)" (#9171) ... This reverts commit c36a4a1617.	6 years ago
valerauko	c36a4a1617	Fix FetchAtomService content type handling (#9132) ... * Add profile to json+ld in Accept It's required by the ActivityPub spec * Use headers['Content-type'] instead of mime_type mime_type strips the profile from the content type, but it's still available raw in the headers hash * Add test for ld+json with profile	6 years ago
ThibG	33a71e8f7c	Do not hide boost notifications from followed people with hidden boosts (#9147) ... * Do not hide boost notifications from followed people with hidden boosts Not displaying boosts from a followed user in the Home timeline and not having notifications when they reblog your own content are two very separate concerns, tying them together seem counter-intuitive and unwanted. * Update specs accordingly	6 years ago
Eugen Rochko	b40ea6d1d4	Bump sanitize from 4.6.6 to 5.0.0 (#9140)	6 years ago
takayamaki	33976c8ecc	fix: Execute PAM authentication tests on CircleCI (#9029) ... and use 'if' option of context block	6 years ago
Eugen Rochko	d5bfba3262	Do not test PAM authentication by default (#9027) ... * Do not test PAM authentication by default * Disable PAM tests if PAM is not enabled	6 years ago
Eugen Rochko	ddd30f331c	Improve support for aspects/circles (#8950) ... * Add silent column to mentions * Save silent mentions in ActivityPub Create handler and optimize it Move networking calls out of the database transaction * Add "limited" visibility level masked as "private" in the API Unlike DMs, limited statuses are pushed into home feeds. The access control rules between direct and limited statuses is almost the same, except for counter and conversation logic * Ensure silent column is non-null, add spec * Ensure filters don't check silent mentions for blocks/mutes As those are "this person is also allowed to see" rather than "this person is involved", therefore does not warrant filtering * Clean up code * Use Status#active_mentions to limit returned mentions * Fix code style issues * Use Status#active_mentions in Notification And remove stream_entry eager-loading from Notification	6 years ago
Eugen Rochko	21ad21cb50	Improve signature verification safeguards (#8959) ... * Downcase signed_headers string before building the signed string The HTTP Signatures draft does not mandate the “headers” field to be downcased, but mandates the header field names to be downcased in the signed string, which means that prior to this patch, Mastodon could fail to process signatures from some compliant clients. It also means that it would not actually check the Digest of non-compliant clients that wouldn't use a lowercased Digest field name. Thankfully, I don't know of any such client. * Revert "Remove dead code (#8919)" This reverts commit a00ce8c92c. * Restore time window checking, change it to 12 hours By checking the Date header, we can prevent replaying old vulnerable signatures. The focus is to prevent replaying old vulnerable requests from software that has been fixed in the meantime, so a somewhat long window should be fine and accounts for timezone misconfiguration. * Escape users' URLs when formatting them Fixes possible HTML injection * Escape all string interpolations in Formatter class Slightly improve performance by reducing class allocations from repeated Formatter#encode calls * Fix code style issues	6 years ago
ashleyhull-versent	f194857ac9	rubocop issues - Cleaning up (#8912) ... * cleanup pass * undo mistakes * fixed. * revert	6 years ago
ashleyhull-versent	2dba313100	Replace SVG asset with Custom mascot (#8766)	6 years ago
Eugen Rochko	774ac47373	Add conversations API (#8832) ... * Add conversations API * Add web UI for conversations * Add test for conversations API * Add tests for ConversationAccount * Improve web UI * Rename ConversationAccount to AccountConversation * Remove conversations on block and mute * Change last_status_id to be a denormalization of status_ids * Add optimistic locking	6 years ago
Jeong Arm	144d73730d	Leave unknown language as nil if account is remote (#8861) ... * Force use language detector if account is remote * Set unknown remote toot's language as nil	6 years ago
aus-social	0a4739c732	lint pass 2 (#8878) ... * Code quality pass * Typofix * Update applications_controller_spec.rb * Update applications_controller_spec.rb	6 years ago
Eugen Rochko	a46ab86adf	Limit the number of people that can be followed from one account (#8807) ... Configurable soft limit of 7,500, and above that, configurable ratio of 1.1 * followers, controlled by: - MAX_FOLLOWS_THRESHOLD - MAX_FOLLOWS_RATIO Fix #2311	6 years ago
Eugen Rochko	e645ae9561	Change admin accounts default sort to most recent (#8813)	6 years ago
Eugen Rochko	7fe137d2f7	Fix link verification for remote accounts (#8868)	6 years ago
aus-social	1f98eae1cf	Lint pass (#8876)	6 years ago
Eugen Rochko	f0fff3eb10	Support min_id-based pagination in REST API (#8736) ... * Allow min_id pagination in Feed#get * Add min_id pagination to home and list timeline APIs * Add min_id pagination to account statuses, public and tag APIs * Remove unused stub in reports API * Use min_id pagination in notifications, favourites, and fix order * Fix HomeFeed#from_database not using paginate_by_id	6 years ago
Eugen Rochko	3d7f68c273	Revert Font Awesome 5 upgrade (#8810) ... * Revert "Fix some icon names changed by the Font Awesome 5. (#8796)" This reverts commit 3f9ec3de82. * Revert "Migrate to font-awesome 5.0. (#8799)" This reverts commit 8bae14591b. * Revert "Fix some icons names, unavailable in fontawesome5 (free license). (#8792)" This reverts commit b9c727a945. * Revert "Update the icon name changed by the Font Awesome 5. (#8776)" This reverts commit 17af4d27da. * Revert "Add bot icon to bot avatars and migrate to newer version of Font Awesome (#8484)" This reverts commit 4b794e134d.	6 years ago
Naoki Kosaka	8bae14591b	Migrate to font-awesome 5.0. (#8799)	6 years ago
ThibG	c39183cc62	Refactor active_nav_class for use with multiple paths (#8757)	6 years ago
Eugen Rochko	f92f1ee80a	Support link verification with redirects (#8735) ... (e.g. URL shortener)	6 years ago
Yamagishi Kazutoshi	3da1cc7d5e	Fix failed profile verification when rel attribute including values other than me (#8733)	6 years ago
Eugen Rochko	f4d549d300	Redesign forms, verify link ownership with rel="me" (#8703) ... * Verify link ownership with rel="me" * Add explanation about verification to UI * Perform link verifications * Add click-to-copy widget for verification HTML * Redesign edit profile page * Redesign forms * Improve responsive design of settings pages * Restore landing page sign-up form * Fix typo * Support <link> tags, add spec * Fix links not being verified on first discovery and passive updates	6 years ago
luzpaz	40dd19be37	Misc. typos (#8694) ... Found via `codespell -q 3 --skip="./app/javascript/mastodon/locales,./config/locales"`	6 years ago
Eugen Rochko	2288d50a7b	Add force_login option to OAuth authorize page (#8655) ... * Add force_login option to OAuth authorize page For when a user needs to sign into an app from multiple accounts on the same server * When logging out from modal header, redirect back after re-login	7 years ago
Sorin Davidoi	6f3d934bc1	feat(cookies): Use the same-site attribute to lax (#8626) ... CSFR-prevention is already implemented but adding this doesn't hurt. A brief introduction to Same-Site cookies (and the difference between strict and lax) can be found at https://blog.mozilla.org/security/2018/04/24/same-site-cookies-in-firefox-60/ TLDR: We use lax since we want the cookies to be sent when the user navigates safely from an external site.	7 years ago
Eugen Rochko	c593d6df9c	Add preference for report notification e-mails, skip for duplicates (#8559) ... If an unresolved report for the same target account already exists, no new notification is generated	7 years ago
Renato "Lond" Cerqueira	fe56d26f7b	Fix autoplay issue with spoiler tag (#8540) ... Add tests to avoid similar issues in the future	7 years ago
Renato "Lond" Cerqueira	11658d8653	Add animate custom emoji param to embed pages (#8507) ... * Add animate custom emoji param to embed pages * Rename param, use it for avatars and gifs * Fix issues pointed by codeclimate and breaking test * Ignore brakeman warning	7 years ago
Renato "Lond" Cerqueira	5b2b493a90	Fix nil host in remotable (#8508) ... Host can be nil in urls like 'https:https://example.com/path/file.png'	7 years ago
sundevour	4bfd786550	formatter spec fixes & clarification (#8481) ... updates some "context" and "it" lines to have clearer explanations updates "context" lines to properly describe function input, and "it" lines to describe results	7 years ago
Eugen Rochko	5e1767173f	Display pending message on admin relays UI (#8494) ... * Add missing specs for relay accept/reject * Display pending message on admin relays UI	7 years ago
Jakub Mendyk	f3a12ddfd0	Make Api::V1::MutesController paginate properly (#8472) ... Fixes #8463	7 years ago
Eugen Rochko	22e46ebad8	Add theme identifier to body classes for easier custom CSS styling (#8439) ... Add forgotten custom CSS admin setting strings	7 years ago
Eugen Rochko	2f34b747b3	Allow mods to disable login, improve message when login disabled (#8329) ... * Allow moderators to disable/enable login * Instead of rejecting login, show forbidden error when login disabled Avoid confusion because when login is rejected, the message is that the account is not activated, which is wrong. * Fix tests	7 years ago
Jakub Mendyk	6cb3514d64	Add ability to change an instance default theme from the administration panel (#7092) (#8381) ... * Add default_settings class method to ScopedSettings ScopedSettings was extended to use value of unscoped setting instead of only using defaults set in config/settings.yml for selected settings. This adds possibility for admins to set default values of users' settings, for example default theme (as requested in #7092). * Add ability to change an instance default theme Closes #7092	7 years ago
Eugen Rochko	802cf6a4c5	Improve federated ID validation (#8372) ... * Fix URI not being sufficiently validated with prefetched JSON * Add additional id validation to OStatus documents, when possible	7 years ago
masarakki	4bdab203ac	exclude-other-silenced-accounts (#7528)	7 years ago
Eugen Rochko	2374a00c10	Add confirmation step to account suspensions (#8353) ... * Add confirmation page for suspensions * Suspension confirmation closes reports, linked from report UI * Fix tests	7 years ago
Eugen Rochko	6226aa83d7	Increase reach of Delete->Actor activities (#8305) ... Fix #7316	7 years ago
Eugen Rochko	d010816ba8	Fix error when trying to update counters for statuses that are gone (#8251)	7 years ago
Eugen Rochko	78fa926ed5	Add remote interaction dialog for toots (#8202) ... * Add remote interaction dialog for toots * Change AuthorizeFollow into AuthorizeInteraction, support statuses * Update brakeman.ignore * Adjust how interaction buttons are display on public pages * Fix tests	7 years ago
ThibG	59f7f4c923	Implement Undo { Accept { Follow } } (fixes #8234) (#8245) ... * Add Follow#revoke_request! * Implement Undo { Accept { Follow } } (fixes #8234)	7 years ago
ThibG	af912fb308	Allow accessing local private/DM messages by URL (#8196) ... * Allow accessing local private/DM messages by URL (Provided the user pasting the URL is authorized to see the toot, obviously) * Fix SearchServiceSpec tests	7 years ago
Eugen Rochko	aaac14b8ad	Show exact number of followers/statuses on export page/in tooltip (#8199) ... * Show exact number of followers/statuses on export page/in tooltip * Fix tests	7 years ago
Eugen Rochko	8e111b753a	Move status counters to separate table, count replies (#8104) ... * Move status counters to separate table, count replies * Migration to remove old counter columns from statuses table * Fix schema file	7 years ago
S.H	2aeeffc3ec	Update Rails (#8141) ... * Update Rails * fix Update Rails	7 years ago
Eugen Rochko	0dcc1950d1	Update /terms and /about/more to use public layout (#8142)	7 years ago
Eugen Rochko	f2404de871	Public profile endorsements (accounts picked by profile owner) (#8146)	7 years ago
Eugen Rochko	cc56f2230a	Add separate setting for sidebar text (site_short_description) (#8107) ... * Add separate setting for sidebar text (site_short_description) * Fix tests	7 years ago
Eugen Rochko	60df87f6f0	Compensate for scrollbar disappearing when media modal visible (#8100) ... * Compensate for scrollbar disappearing when media modal visible Make auth pages backgrounds lighter * Fix typo	7 years ago
Eugen Rochko	e7e577dd6e	Enforce username format for remote users, too (#8102) ... Initially I thought there might be valid reasons for remote users to have a different, unpredicted username format. However, I now realize such a difference would be unusable and unexpected within Mastodon. Fix #8058	7 years ago
Eugen Rochko	bb71538bb5	Redesign public profiles and toots (#8068)	7 years ago
Eugen Rochko	0fb0037ca7	Resize images by area instead of fixed dimensions (#8083) ... To improve the way super tall or super ride images are treated, the numbers remain the same, 1280x1280 and 400x400, but if an image is less in one dimension than the other, the other can become larger Thanks to @WAHa_06x36@mastodon.social for the tip	7 years ago
Eugen Rochko	2a176514be	Display full acct on public status pages, always (#8011)	7 years ago
Eugen Rochko	38e9662d78	Disable language detection for texts shorter than 140 characters (#8010) ... If the input text is blank after preparation (only mention, or only URL, or empty as in a media post), then use nil as language, since it's OK to show to everyone. Otherwise, always fall back to the server's default locale	7 years ago
Eugen Rochko	e55dce3176	Add federation relay support (#7998) ... * Add federation relay support * Add admin UI for managing relays * Include actor on relay-related activities * Fix i18n	7 years ago
ThibG	1ca4e51eb3	Add option to not consider word boundaries when processing keyword filtering (#7975) ... * Add option to not consider word boundaries when filtering phrases * Add a few tests for keyword/phrase filtering	7 years ago
Eugen Rochko	cd509d2146	Remove .p-name microformat class (#7961) ... Fix #7926	7 years ago
Eugen Rochko	1f6ed4f86a	Add more granular OAuth scopes (#7929) ... * Add more granular OAuth scopes * Add human-readable descriptions of the new scopes * Ensure new scopes look good on the app UI * Add tests * Group scopes in screen and color-code dangerous ones * Fix wrong extra scope	7 years ago
Eugen Rochko	da8fe8079e	Re-add follow recommendations API (#7918) ... * Re-add follow recommendations API GET /api/v1/suggestions Removed in 8efa081f21 due to Neo4J dependency. The algorithm uses triadic closures, takes into account suspensions, blocks, mutes, domain blocks, excludes locked and moved accounts, and prefers more recently updated accounts. * Track interactions with people you don't follow Replying to, favouriting and reblogging someone you're not following will make them show up in follow recommendations. The interactions have different weights: - Replying is 1 - Favouriting is 10 (decidedly positive interaction, but private) - Reblogging is 20 Following them, muting or blocking will remove them from the list, obviously. * Remove triadic closures, ensure potential friendships are trimmed	7 years ago
Eugen Rochko	cdb101340a	Keyword/phrase filtering (#7905) ... * Add keyword filtering GET|POST /api/v1/filters GET|PUT|DELETE /api/v1/filters/:id - Irreversible filters can drop toots from home or notifications - Other filters can hide toots through the client app - Filters use a phrase valid in particular contexts, expiration * Make sure expired filters don't get applied client-side * Add missing API methods * Remove "regex filter" from column settings * Add tests * Add test for FeedManager * Add CustomFilter test * Add UI for managing filters * Add streaming API event to allow syncing filters * Fix tests	7 years ago