Commit Graph

693 Commits (stable-4.4)

Author SHA1 Message Date
Matt Jankowski dea6c454fd
Contribute more coverage for `Account` model (#32474) 9 months ago
Matt Jankowski b16435e79f
Explore more resplendent model validation specs for `Form::AdminSettings` (#32465) 9 months ago
Matt Jankowski 67504dbf9c
Simplify uniqueness validation spec for `IpBlock` (#32066) 9 months ago
Matt Jankowski 2f906ed55a
Constants for account refresh (#32420) 9 months ago
Matt Jankowski bd0c826a3d
Simplify model validation specs for `Announcement` (#32481) 9 months ago
Matt Jankowski c0f46e9031
Fortify coverage for `Follow` model (#32472) 9 months ago
Matt Jankowski 1f3722904f
Top off coverage for `Appeal` model (#32464) 9 months ago
Matt Jankowski 6d2f865862
Add coverage for `AccountAlias` validations (#31936) 9 months ago
Matt Jankowski 27f05e9016
Expand coverage for `User#token_for_app` (#32434) 9 months ago
Matt Jankowski bfb41e61a3
Expand coverage for `Block` model (#32480) 9 months ago
Matt Jankowski 92bb19773a
Use `context` for repeated scenarios in `AccountStatusCleanupPolicy` spec (#32489) 9 months ago
Matt Jankowski d1d2278e70
Reduce factory creation (73 -> 64) in `PublicFeed` spec (#32491) 9 months ago
Matt Jankowski d74c2c583a
Extend spec coverage for `Poll` model (#32500) 9 months ago
Matt Jankowski cc70acc11c
Augment coverage for `Status` model (#32468) 9 months ago
Matt Jankowski d8eab3d81f
Reinforce coverage for `DomainBlock` model (#32473) 9 months ago
Claire d9fbb071da
Fix notification requests from suspended accounts still being listed (#32354) 10 months ago
Matt Jankowski d95f6f4410
Extract `ExportSummary` class for account object counts (#32227) 10 months ago
Matt Jankowski 2151dfb8d6
Add `relevant_params` to ReportFilter (matches account filter) (#32136) 10 months ago
Matt Jankowski ebab3b80c7
Expand coverage for `Export` utility class (#32212) 10 months ago
Matt Jankowski bbf7752256
Combine assertions in `Notification` model spec (#32015) 10 months ago
Matt Jankowski cd7b670cd8
Reduce factory creation in `User#reset_password!` spec (#32021) 10 months ago
Matt Jankowski 04a939d640
Add `reviewed` and `unreviewed` scopes to `Reviewable` model concern (#31988) 10 months ago
renovate[bot] 6801afa12f
Update dependency devise-two-factor to v6 [SECURITY] (#31957)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: David Roetzel <david@roetzel.de>
10 months ago
Matt Jankowski e3baa1cdda
Add coverage for `AccountDeletionRequest` class (#31937) 10 months ago
Matt Jankowski 5405bdd344
Remove unused E2EE messaging code (#31193) 10 months ago
Matt Jankowski c54cbf7943
Remove `follow` creation from `ListAccount` fabricator (#31902) 10 months ago
Matt Jankowski abd2f5654a
Add validation coverage for `CustomEmoji` shortcode value (#31906) 10 months ago
Matt Jankowski 822e918a56
Add coverage for `Bookmark` validation and reblog/status check callback (#31907) 10 months ago
Claire 4b40d13cb3
Increase preview card image size limit from 2MB to 8MB when using libvips (#31904) 10 months ago
David Roetzel c1b2c4fd9a
Strip protocol from attribution domains (#31900) 10 months ago
Claire ba81e4e019
Fix inability to locally suspend remotely-suspended accounts in moderation interface (#31899) 10 months ago
Matt Jankowski a2c4f5f5c0
Add coverage for `ListAccount` follow/follow_request set up (#31896) 10 months ago
Matt Jankowski 17c57c46e7
Add coverage for title/limit validations in `List` model (#31869) 11 months ago
Eugen Rochko e0c27a5047
Add ability to manage which websites can credit you in link previews (#31819) 11 months ago
Matt Jankowski d0ab94c4d2
Add `FeaturedTag` coverage, use `pick` in model (#31828) 11 months ago
Emelia Smith c88ba523ee
Fix sort order of moderation notes on Reports and Accounts (#31528) 11 months ago
Matt Jankowski 5acec087ca
Simplify basic presence validations (#29664) 11 months ago
Matt Jankowski ba9fd1c32e
Add coverage for `Account#prepare_contents` callback (#31748) 11 months ago
Matt Jankowski 14af5b47ac
Add coverage for model normalizations (#31734) 11 months ago
Matt Jankowski f1003b2560
Enable "zero monkey patching" mode in RSpec (#31614) 11 months ago
Matt Jankowski 7c26e5e4a1
Add `Reviewable` model concern (#31152) 11 months ago
Matt Jankowski 67faaf5557
Simplify account model username presence validation spec (#31013) 11 months ago
Matt Jankowski fcb83be8b2
Improve coverage specificity for Webhook enable/disable/secret specs (#31194) 11 months ago
Edward Moulsdale d4f135bc6d
Fix in memoriam accounts appearing in follow recommendations (#31474)
Co-authored-by: Utkarsh Wankar <46633523+kernal053@users.noreply.github.com>
11 months ago
Jeong Arm 95c11d365d
Don't push to cache buster if attachment path is nil (#31414) 11 months ago
Matt Jankowski 02df1b4e4a
Finish email allow/deny list naming migration (#30530) 12 months ago
Claire 994ef16b72
Bust CDN cache on media deletion (#31353) 12 months ago
Claire af2aec1a82
Change notification requests to only count mentions (#31322) 12 months ago
Emelia Smith c40e481169
Implement UI for Admin Search of Hashtags (#30880) 1 year ago
Adam Niedzielski 337a7fcf30
Fix ß bug in regexp for mentions and tags (#31122) 1 year ago
Matt Jankowski 6e4305de69
Fix spec descriptions around configurable limit values (#31079) 1 year ago
kyori19 3a00f89aa1
Respect `Account::DISPLAY_NAME_LENGTH_LIMIT` in account spec correctly (#31075) 1 year ago
Matt Jankowski 848b59c8ae
Reduce factory creation in `MediaAttachment` model spec (#31058) 1 year ago
Matt Jankowski 91ef4a6fc5
Add assertion about key columns to account key generate spec (#30635) 1 year ago
David Roetzel 35a437a03f
Destroy `NotificationRequest`s that are dismissed (#31008) 1 year ago
Matt Jankowski f1300ad284
Rename jobs/attachments rspec tag names (#29762) 1 year ago
Claire d41b43ed4f
Limit attachments to `MEDIA_ATTACHMENTS_LIMIT` when returning posts through the API (#30932) 1 year ago
Matt Jankowski 836c0477ac
Use vips setting instead of env var in media processing spec (#30859) 1 year ago
Matt Jankowski d818ddd687
Extract `SIGN_COUNT_LIMIT` constant in `WebauthnCredential` class (#30636) 1 year ago
Matt Jankowski 62d070c438
Check both before/after state in `AccountDomainBlock` spec (#30640) 1 year ago
Matt Jankowski 1622f7aeb9
Remove duplicate fabricator validity checks (#29667) 1 year ago
Matt Jankowski cfd4823b65
Use fabricator in follow_spec (#30642) 1 year ago
Matt Jankowski 9bf2e2eda0
Extract `TEXT_LENGTH_LIMIT` constant in `Appeal` class (#30638) 1 year ago
Matt Jankowski 3e3f3d7580
Match report validation spec to extracted constant (#30633) 1 year ago
Matt Jankowski 92b3004bf3
Reference constants from account validation specs (#30634) 1 year ago
Daniel M Brasil 28f9a8f2ec
Add Specs for Scheduled Status Model Validations (#30585) 1 year ago
Claire 1408733386
Fix Mastodon relying on ImageMagick even with `MASTODON_USE_LIBVIPS` (#30590) 1 year ago
Matt Jankowski a662c6d1d8
Use `sidekiq_inline` in admin/account_action model spec (#30565) 1 year ago
Eugen Rochko 5f15a892fa
Add support for libvips in addition to ImageMagick (#30090)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
1 year ago
Claire 974335e414
Add experimental server-side notification grouping (#29889) 1 year ago
Claire 30ef9fccf0
Fix hashtag matching pattern matching some link anchors (#30190) 1 year ago
Claire e5062b7135
Fix post deletion not being deferred when those are part of an account warning (#30163) 1 year ago
Matt Jankowski 1e7d5d2957
Update `devise-two-factor` to version 5.0.0 (#28325)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
1 year ago
Claire e845594878
Fix moderator account being exposed in account moderation notification (#30082) 1 year ago
Claire 4ef0b48b95
Add in-app notifications for moderation actions/warnings (#30065) 1 year ago
Matt Jankowski 11e0049b08
Use enum-generated scopes/queries for `BulkImport` (#29975) 1 year ago
Matt Jankowski 650c548c31
Add `not_featured_by` scope to Tag (#28815) 1 year ago
Matt Jankowski 6fed108703
Use Rails `upsert` to generate update_count! query in Counters concern (#28738)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
1 year ago
Matt Jankowski 285f63c02e
Use composable query in `User.active` scope (#29775) 1 year ago
Claire babbf6017d
Remove caching in `cache_collection` (#29862) 1 year ago
Claire 38b9d31f63
Improve email address validation (#29838) 1 year ago
Claire 44bf7b8128
Add notifications of severed relationships (#27511) 1 year ago
Claire d5063072c3
Revert friends-of-friends follow recommendation query to using a CTE (#29619) 1 year ago
Matt Jankowski 6262ceeb70
Fix `RSpec/DescribedClass` cop (#29472) 1 year ago
Matt Jankowski c09b8a7164
Add `Account.without_internal` scope (#29559)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
1 year ago
Matt Jankowski 01b624c4a0
Use `normalizes` on `CustomFilter#context` value (#27602) 1 year ago
Matt Jankowski 216cea1e27
Fix incorrect frequency value in `FriendsOfFriendsSource` data (#29550) 1 year ago
Eugen Rochko c10bbf5fe3
Add notification policies and notification requests in web UI (#29433) 1 year ago
Jeong Arm 4a6ddbc9c0
Normalize idna domain before account unblock domain (#29530) 1 year ago
Eugen Rochko 50b17f7e10
Add notification policies and notification requests (#29366) 1 year ago
Claire ee8d0b9447
Fix follow suggestions potentially including silenced or blocked accounts (#29306) 1 year ago
Daniel M Brasil a25014de8f
Improve `IpBlock` model test coverage (#29460) 1 year ago
Matt Jankowski 3389c41b58
Move `nobody` position in `UserRole` magic number to constant (#29465) 1 year ago
Matt Jankowski 1f648fdf1a
Remove erroneous service type on `TagFeed` model spec (#29302) 1 year ago
Matt Jankowski 64f9939e39
Use `capture_emails` helper to improve email assertions in specs (#29245) 1 year ago
Matt Jankowski 245064bb98
Move "everyone" role and "instance actor" account magic number IDs to constants (#29260) 1 year ago
Matt Jankowski 117b507df5
Extract `subject` from `User#mark_email_as_confirmed!` spec (#29231) 1 year ago
Matt Jankowski bba488c189
Reduce `RSpec/MultipleExpectations` in media_attachment spec (#29228) 1 year ago
Claire b31af34c97
Merge pull request from GHSA-vm39-j3vx-pch3
* Prevent different identities from a same SSO provider from accessing a same account

* Lock auth provider changes behind `ALLOW_UNSAFE_AUTH_PROVIDER_REATTACH=true`

* Rename methods to avoid confusion between OAuth and OmniAuth
1 year ago
Emelia Smith 68eaa804c9
Merge pull request from GHSA-7w3c-p9j8-mq3x
* Ensure destruction of OAuth Applications notifies streaming

Due to doorkeeper using a dependent: delete_all relationship, the destroy of an OAuth Application bypassed the existing AccessTokenExtension callbacks for announcing destructing of access tokens.

* Ensure password resets revoke access to Streaming API

* Improve performance of deleting OAuth tokens

---------

Co-authored-by: Claire <claire.github-309c@sitedethib.com>
1 year ago
Matt Jankowski 95da28d201
Add common `ThreadingHelper` module for specs (#29116) 1 year ago
Claire 66dda7c762
Fix already-invalid reports failing to resolve (#29027) 1 year ago
Matt Jankowski 6d35a77c92
Combine repeated subjects in `models/user` spec (#28937) 2 years ago
Matt Jankowski 42ab855b23
Add specs for `Instance` model scopes and add `with_domain_follows` scope (#28767) 2 years ago
Matt Jankowski 2866106ec1
Reduce factory creation in `spec/models/account_statuses_cleanup_policy` (#28361) 2 years ago
Matt Jankowski 6b6586f5d0
Add `CustomFilterKeyword#to_regex` method (#28893) 2 years ago
Matt Jankowski b0207d7757
Add coverage for `Tag.recently_used` scope (#28850) 2 years ago
Matt Jankowski 18004bf227
Add `Account.matches_uri_prefix` scope and use in activitypub/followers_synchronizations controller (#28820) 2 years ago
Matt Jankowski 1480573c83
Add `Account.auditable` scope, fix N+1 in admin/action_logs#index (#28812) 2 years ago
Matt Jankowski d0b3bc23d7
Remove unused `matches_domain` scopes on Account, DomainAllow, DomainBlock (#28803) 2 years ago
Matt Jankowski 07e10e3747
Combine assertions about same setup in `Account#suspend!` spec (#28787) 2 years ago
Matt Jankowski 1b0cb3b54d
Announcement reactions query spec improvement and refactor (#28768) 2 years ago
Claire 98b5f85f10
Rename and refactor `User#confirm!` to `User#mark_email_as_confirmed!` (#28735) 2 years ago
Matt Jankowski cd37048439
Move followable_by coverage to suggestions (#28697) 2 years ago
Matt Jankowski 8b26614fa7
Combine results include check in spec/models/account (#28471) 2 years ago
Matt Jankowski 0a7cff53c2
Add coverage for `Account.followable_by` scope (#28689) 2 years ago
Matt Jankowski 543d7890fd
Use normalizes to prepare `User` values (#28650)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2 years ago
Matt Jankowski 00341c70ff
Use Sidekiq `fake!` instead of `inline!` in specs (#25369) 2 years ago
Claire 10203bd57a
Clean up `Setting` model and remove dead code (#28661) 2 years ago
Jean Boussier 1781849884
Inline what remains of the rails-settings-cached gem (#28618)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2 years ago
Matt Jankowski 5dc634796a
Misc coverage improvements re: sidekiq/inline (#28651) 2 years ago
Matt Jankowski e677eb164c
Remove unused `Announcement#time_range?` (#28648) 2 years ago
Matt Jankowski 3e43cd095c
Remove unused scope `Announcement.without_muted` (#28645) 2 years ago
Matt Jankowski aa6d07dbd9
Use normalizes to prepare CustomEmoji `domain` value (#28624) 2 years ago
Matt Jankowski 12bed81187
Add validation specs to `CustomFilter` model (#28600) 2 years ago
Matt Jankowski bb8077e784
Fix `RSpec/LetSetup` cop in models/account_status_cleanup_policy (#28470) 2 years ago
Matt Jankowski e6e217fedd
Clean up `tagged_with_*` Status specs, fix `RSpec/LetSetup` cop (#28462) 2 years ago
Matt Jankowski c753b1ad35
Clean up of `RSpec/LetSetup` within `spec/models` (#28444) 2 years ago
Claire 6fed0fcbaa
Remove unneeded settings cleanup from specs (#28425) 2 years ago
Matt Jankowski af366f65ee
Add spec coverage for `models/form/custom_emoji_batch` class (#28388) 2 years ago
Matt Jankowski 1820bad646
Fix `Performance/StringIdentifierArgument` cop (#28399) 2 years ago
Matt Jankowski 28e1a7a394
Improve spec coverage for `models/announcement` class (#28350) 2 years ago
Matt Jankowski 89a8e6e622
Remove 2x double subject call in `models/form/account_batch` spec (#28209) 2 years ago
Matt Jankowski 5631f139c1
Fix `Lint/SymbolConversion` cop (#28175) 2 years ago
Matt Jankowski 440b80b2e7
Model concerns organization into module namespaces (#28149) 2 years ago
Matt Jankowski e48ecd2929
Remove `default_scope` from `Admin::ActionLog` (#28026) 2 years ago
Matt Jankowski 973597c6f1
Consolidate configuration of `Sidekiq::Testing.fake!` setup (#28046) 2 years ago
Eugen Rochko cdc57c74b7
Fix unsupported time zone or locale preventing sign-up (#28035)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2 years ago
Matt Jankowski 371f355719
Reduce `.times` usage in `AccountStatusesCleanupPolicy` (#27947) 2 years ago
Matt Jankowski d2aacea8da
Reduce `.times` usage in AccountSearch spec, use constant for default limit (#27946) 2 years ago
Matt Jankowski 00c6ebd86f
Reduce `.times` usage in `StatusPin` and add `PIN_LIMIT` constant in validator (#27945) 2 years ago
Matt Jankowski b2c5b20ef2
Fix `RSpec/AnyInstance` cop (#27810) 2 years ago
Matt Jankowski b7807f3d84
Use `normalizes` to prepare `Webhook#events` value (#27605) 2 years ago
Matt Jankowski 63c9102f8a
Fix `RSpec/MessageChain` cop (#27776) 2 years ago
Matt Jankowski 69d00e2721
Fix `RSpec/InstanceVariable` cop (#27766) 2 years ago
Matt Jankowski ce91d14d48
Fix `Style/WordArray` cop (#27770) 2 years ago
Matt Jankowski 49e2772064
Fix `RSpec/MessageSpies` cop (#27751) 2 years ago
Matt Jankowski cfa14ec6d1
Fix `Lint/EmptyBlock` cop (#27748) 2 years ago
Matt Jankowski b06284c572
Fix `RSpec/HookArgument` cop (#27747) 2 years ago
Matt Jankowski 949f5eb860
Fix `RSpec/MetadataStyle` cop in spec/ (#27729) 2 years ago