From d84da571e90e2c88c90e541df0cad8516270f358 Mon Sep 17 00:00:00 2001 From: Mikael Finstad Date: Sun, 4 Aug 2024 23:19:57 +0200 Subject: [PATCH] convert pcm_dvd #2092 --- src/renderer/src/util/streams.ts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/renderer/src/util/streams.ts b/src/renderer/src/util/streams.ts index 74cfd613..3b104682 100644 --- a/src/renderer/src/util/streams.ts +++ b/src/renderer/src/util/streams.ts @@ -155,8 +155,13 @@ function getPerStreamFlags({ stream, outputIndex, outFormat, manuallyCopyDisposi // https://forum.doom9.org/showthread.php?t=174718 // https://github.com/mifi/lossless-cut/issues/476 // ffmpeg cannot encode pcm_bluray - if (outFormat !== 'mpegts' && stream.codec_name === 'pcm_bluray') { + if (stream.codec_name === 'pcm_bluray' && outFormat !== 'mpegts') { addCodecArgs('pcm_s24le'); + } else if (stream.codec_name === 'pcm_dvd' && ['matroska', 'mov'].includes(outFormat)) { + // https://github.com/mifi/lossless-cut/discussions/2092 + // coolitnow-partial.vob + // https://superuser.com/questions/1272614/use-ffmpeg-to-merge-mpeg2-files-with-pcm-dvd-audio + addCodecArgs('pcm_s32le'); } else if (outFormat === 'dv' && stream.codec_name === 'pcm_s16le' && stream.sample_rate !== '48000') { // DV seems to require 48kHz output // https://trac.ffmpeg.org/ticket/8352