From 833ab45c587ade65329de5d3d4298f3653a24630 Mon Sep 17 00:00:00 2001 From: Mikael Finstad Date: Sat, 13 Nov 2021 18:39:28 +0700 Subject: [PATCH] fix issue with newer ffmpeg version --- src/hooks/useFfmpegOperations.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/hooks/useFfmpegOperations.js b/src/hooks/useFfmpegOperations.js index f63bfcbc..6201839f 100644 --- a/src/hooks/useFfmpegOperations.js +++ b/src/hooks/useFfmpegOperations.js @@ -8,7 +8,7 @@ import { getOutPath, transferTimestamps, getOutFileExtension, getOutDir, isMac } import { isCuttingStart, isCuttingEnd, handleProgress, getFfCommandLine, getFfmpegPath, getDuration, runFfmpeg, createChaptersFromSegments } from '../ffmpeg'; const execa = window.require('execa'); -const { join } = window.require('path'); +const { join, resolve } = window.require('path'); const fs = window.require('fs-extra'); const stringToStream = window.require('string-to-stream'); @@ -250,7 +250,9 @@ function useFfmpegOperations({ filePath, enableTransferTimestamps }) { console.log('ffmpeg', ffmpegArgs.join(' ')); // https://superuser.com/questions/787064/filename-quoting-in-ffmpeg-concat - const concatTxt = paths.map(file => `file '${join(file).replace(/'/g, "'\\''")}'`).join('\n'); + // Must add "file:" or we get "Impossible to open 'pipe:xyz.mp4'" on newer ffmpeg versions + // https://superuser.com/questions/718027/ffmpeg-concat-doesnt-work-with-absolute-path + const concatTxt = paths.map(file => `file 'file:${resolve(file).replace(/'/g, "'\\''")}'`).join('\n'); console.log(concatTxt);