From 789f857e26b15b97b079d35a11a2de6db3c72ba8 Mon Sep 17 00:00:00 2001 From: Mikael Finstad Date: Sun, 6 Oct 2024 21:05:43 +0200 Subject: [PATCH] convert all non webvtt to webvtt in webm closes #2179 --- src/renderer/src/util/streams.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/renderer/src/util/streams.ts b/src/renderer/src/util/streams.ts index b98076a5..cb57c5d2 100644 --- a/src/renderer/src/util/streams.ts +++ b/src/renderer/src/util/streams.ts @@ -126,8 +126,9 @@ function getPerStreamFlags({ stream, outputIndex, outFormat, manuallyCopyDisposi // https://github.com/mifi/lossless-cut/issues/418 // https://www.reddit.com/r/PleX/comments/bcfvev/can_someone_eli5_subtitles/ addCodecArgs('srt'); - } else if (outFormat === 'webm' && stream.codec_name === 'mov_text') { + } else if (outFormat === 'webm' && stream.codec_name !== 'webvtt') { // Only WebVTT subtitles are supported for WebM. + // https://github.com/mifi/lossless-cut/issues/2179#issuecomment-2395413115 addCodecArgs('webvtt'); // eslint-disable-next-line unicorn/prefer-switch } else if (outFormat === 'srt') { // not technically lossless but why not