slip: remove unnecessary break after goto
8904120b52
slip: Check if rstate is initialized before uncompressing
3f01ddb962
slip: make slhc_free() silently accept an error pointer
baf76f0c58
slip: make slhc_compress() more robust against malicious packets
110a40dfb7
net/veth: Fix packet checksumming
0b7967503d
veth: Fix the byte counters
675071a2ef
Revert: veth: remove unneeded ifname code from veth_newlink()
6c8c44462a
veth: convert to 64 bit statistics
6311cc44a2
veth: fix 64bit stats on 32bit arches
cf05c700cf
veth: Allow to create peer link with given ifindex
e6f8f1a739
Extract "Protocol" field decompression code from transport protocols to
PPP generic layer, where it actually belongs. As a consequence, this
patch fixes incorrect place of PFC decompression in L2TP driver (when
it's not PPPOX_BOUND) and also enables this decompression for other
protocols, like PPPoE.
Protocol field decompression also happens in PPP Multilink Protocol
code and in PPP compression protocols implementations (bsd, deflate,
mppe). It looks like there is no easy way to get rid of that, so it was
decided to leave it as is, but provide those cases with appropriate
comments instead.
Changes in v2:
- Fix the order of checking skb data room and proto decompression
- Remove "inline" keyword from ppp_decompress_proto()
- Don't split line before function name
- Prefix ppp_decompress_proto() function with "__"
- Add ppp_decompress_proto() function with skb data room checks
- Add description for introduced functions
- Fix comments (as per review on mailing list)
Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
Reviewed-by: Guillaume Nault <g.nault@alphalink.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
Ref: 7fb1b8ca8f
l2tp: Fix PPP header erasure and memory leak
55b92b7a11
l2tp: Correctly return -EBADF from pppol2tp_getname
4ac36a4ada
l2tp: Fix the connect status check in pppol2tp_getname
56cff471d0
ppp: deflate: never return len larger than output buffer
e2a4800e75
ppp: deflate: Fix possible crash in deflate_init
3ebe1bca58
ppp: deflate: Remove useless call "zlib_inflateEnd"
dc5fa2073f
Use vzalloc() and vzalloc_node() in net drivers
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Acked-by: Jon Mason <jon.mason@exar.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Ref: 89bf67f1f0
- revert (from newest):
pppoe: fix memory corruption in padt work structure
fe53985aaa
ppp: remove PPPOX_ZOMBIE socket state
a8acce6aa5
ppp: don't set sk_state to PPPOX_ZOMBIE in pppoe_disc_rcv()
8734e485fe
pppoe: Use workqueue to die properly when a PADT is received
287f3a943f
pppoe: remove unused return value from two methods
3b12bb6043
ppp: slight optimization of addr compare
7ed8ca5b1e
net: pppoe: use correct channel MTU when using Multilink PPP
a8a3e41c67
pppoe: Use workqueue to die properly when a PADT is received
287f3a943f
pppoe: Lacks DST MAC address check
a068833bbf
pppoe: drop pppoe device in pppoe_unbind_sock_work
665a6cd809
ppp: don't override sk->sk_state in pppoe_flush_dev()
e6740165b8
ppp: fix pppoe_dev deletion condition in pppoe_release()
1acea4f6ce
ppp: don't set sk_state to PPPOX_ZOMBIE in pppoe_disc_rcv()
8734e485fe
ppp: remove PPPOX_ZOMBIE socket state
a8acce6aa5
pppoe: fix memory corruption in padt work structure
fe53985aaa
pppoe: only process PADT targeted at local interfaces
b8c1583951
Some devices (ex ZTE 2726) simply don't respond at all when data is sent
to some of their USB interfaces. The data gets stuck in the TTYs queue
and sits there until close(2), which them blocks because closing_wait
defaults to 30 seconds (even though the fd is O_NONBLOCK). This is
rarely desired. Implement the standard mechanism to adjust closing_wait
and let applications handle it how they want to.
Signed-off-by: Dan Williams <dcbw@redhat.com>
Ref: 02303f7337
Simple pasting job using the new ops function. Also fix a couple of devices
directly returning the internal struct (which happens at this point to match
for the fields that matter but isn't correct or futureproof)
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ref: 0bca1b913a
Dan Rosenberg noted that various drivers return the struct with uncleared
fields. Instead of spending forever trying to stomp all the drivers that
get it wrong (and every new driver) do the job in one place.
This first patch adds the needed operations and hooks them up, including
the needed USB midlayer and serial core plumbing.
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ref: d281da7ff6
The commit 4547be7 rewrites suspend and resume functions. According
to this rewrite, when a serial port is a printk console device and
can suspend(without set no_console_suspend flag), it will definitely
call set_termios function during its resume, but parameter termios
isn't initialized, this will pass an unpredictable config to the
serial port. If this serial port is not a userspace opened tty device
, a suspend and resume action will make this serial port unusable.
I.E. ttyS0 is a printk console device, ttyS1 or keyboard+display is
userspace tty device, a suspend/resume action will make ttyS0
unusable.
If a serial port is both a printk console device and an opened tty
device, this issue can be overcome because it will call set_termios
again with the correct parameter in the uart_change_speed function.
Refer to the deleted content of commit 4547be7, revert parts relate
to restore settings into parameter termios. It is safe because if
a serial port is a printk console only device, the only meaningful
field in termios is c_cflag and its old config is saved in
uport->cons->cflag, if this port is also an opened tty device,
it will clear uport->cons->cflag in the uart_open and the old config
is saved in tty->termios.
Signed-off-by: Jason Wang <jason77.wang@gmail.com>
Acked-by: Stanislav Brabec <sbrabec@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ref: 891b9dd107
The commit 4547be7 rewrites suspend and resume functions, this
introduces a problem on the OMAP3EVM platoform. when the kernel boots
with no_console_suspend and we suspend the kernel, then resume it,
the serial console will be not usable. This problem should be common
for all platforms.
The cause for this problem is that when enter suspend, if we choose
no_console_suspend, the console_stop will be skiped. But in resume
function, the console port will be set to uninitialized state by
calling set_termios function and the console_start is called without
checking whether the no_console_suspend is set, Now fix it.
Signed-off-by: Jason Wang <jason77.wang@gmail.com>
Acked-by: Stanislav Brabec <sbrabec@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ref: ca2e71aa8c
Certain ZTE modems, namely: MF823. MF831, MF910, built-in modem from
MF286R, expose both CDC-ECM and RNDIS network interfaces.
They have a trait of ignoring the locally-administered MAC address
configured on the interface both in CDC-ECM and RNDIS part,
and this leads to dropping of incoming traffic by the host.
However, the workaround was only present in CDC-ECM, and MF286R
explicitly requires it in RNDIS mode.
Re-use the workaround in rndis_host as well, to fix operation of MF286R
module, some versions of which expose only the RNDIS interface. Do so by
introducing new flag, RNDIS_DRIVER_DATA_DST_MAC_FIXUP, and testing for it
in rndis_rx_fixup. This is required, as RNDIS uses frame batching, and all
of the packets inside the batch need the fixup. This might introduce a
performance penalty, because test is done for every returned Ethernet
frame.
Apply the workaround to both "flavors" of RNDIS interfaces, as older ZTE
modems, like MF823 found in the wild, report the USB_CLASS_COMM class
interfaces, while MF286R reports USB_CLASS_WIRELESS_CONTROLLER.
Suggested-by: Bjørn Mork <bjorn@mork.no>
Cc: Kristian Evensen <kristian.evensen@gmail.com>
Cc: Oliver Neukum <oliver@neukum.org>
Signed-off-by: Lech Perczak <lech.perczak@gmail.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Ref: 36e747972d
pedro
M_ars
ducky
desertkun