Fix for: LED_DIAG was/is always green regardless if you turn DIAG LED on or off
Now:
- Diag ON --> amber LED on and green LED off
- Diag OFF --> amber LED off and green LED on
LED Diag: color amber gpio 0 (active LOW)
LED Diag: color green gpio 2 (active LOW)
Add color logic for LED_WHITE (cosmetic):
- with wan-up switch Internet LED color from amber to green
WAN LED: color green gpio 3 (active LOW)
WAN LED: color amber gpio 1 (active LOW)
align to Freshtomato behaviour for R6400 / R7000 / R8000 and a little bit cosmetic
additional reference:
https://forum.openwrt.org/t/d-link-dir-868l-dir-880l-support/5738/5
Fix for: LED_DIAG was/is always green regardless if you turn DIAG LED on or off
Now:
- Diag ON --> amber LED on and green LED off
- Diag OFF --> amber LED off and green LED on
LED Diag: color amber gpio 3 (active LOW)
LED Diag: color green gpio 2 (active LOW)
align to Freshtomato behaviour for R6400 / R7000 / R8000 and a little bit cosmetic
additional reference:
https://github.com/torvalds/linux/blob/master/arch/arm/boot/dts/bcm4708-netgear-r6250.dts
Fix for: LED_DIAG was/is always green regardless if you turn DIAG LED on or off
Now:
- Diag ON --> amber LED on and green LED off
- Diag OFF --> amber LED off and green LED on
LED Diag: color amber gpio 3 (active LOW)
LED Diag: color green gpio 2 (active LOW)
align to Freshtomato behaviour for R6400 / R7000 / R8000 and a little bit cosmetic
additional reference:
https://github.com/torvalds/linux/blob/master/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts
This reverts commit aab96ddcce.
Problem: with that patch samba does not load/start up after boot / reboot
Hardware & Setup: RT-N18U with PPPoE, OpenVPN, miniupnpd, …
I can reproduce this every time (tested it like 10-15 times). If i start samba manually (via GUI or cmd line) everthing works after wanup.
The old start sequence does work always
Commit of tsynik: 1c1a825209
I think the early redial and exiting of dnsmasq is the problem at time ~ 01:00:29
Jan 1 01:00:28 RT-N18U user.info preinit[1]: samba daemon is started
Jan 1 01:00:28 RT-N18U user.info preinit[1]: Asus RT-N18U: FreshTomato 2019.2 -Test1 K26ARM USB VPN-64K-NOSMP
Jan 1 01:00:28 RT-N18U user.info preinit[1]: samba daemon is started
Jan 1 01:00:29 RT-N18U user.info redial[841]: Redial: wan down. Reconnecting...
Jan 1 01:00:29 RT-N18U daemon.info dnsmasq[955]: exiting on receipt of SIGTERM
Jan 1 01:00:29 RT-N18U daemon.info dnsmasq[1006]: started, version 2.80-305ffb5 cachesize 4096
without that patch redial and exiting of dnsmasq happens much later - at time ~ 01:00:49
samba does load/start properly
Jan 1 01:00:27 RT-N18U user.info preinit[1]: minidlna is stopped
Jan 1 01:00:27 RT-N18U user.info preinit[1]: vsftpd is stopped
Jan 1 01:00:27 RT-N18U user.info preinit[1]: samba daemon is stopped
Jan 1 01:00:27 RT-N18U kern.warn kernel: gro disabled
Jan 1 01:00:28 RT-N18U user.info preinit[1]: samba daemon is started
Jan 1 01:00:28 RT-N18U user.info preinit[1]: MultiWAN: MWAN is 1 (max 4)
Jan 1 01:00:28 RT-N18U daemon.info pppd[917]: Plugin rp-pppoe.so loaded.
Jan 1 01:00:28 RT-N18U daemon.info pppd[917]: RP-PPPoE plugin version 3.13 compiled against pppd 2.4.7
Jan 1 01:00:29 RT-N18U user.info redial[919]: Redial (wan) started, the check interval is 10 seconds
Jan 1 01:00:29 RT-N18U daemon.notice pppd[918]: pppd 2.4.7 started by root, uid 0
Jan 1 01:00:29 RT-N18U kern.info kernel: Ebtables v2.0 registered
Jan 1 01:00:29 RT-N18U kern.info kernel: device eth1 left promiscuous mode
Jan 1 01:00:29 RT-N18U kern.info kernel: br0: port 2(eth1) entering forwarding state
Jan 1 01:00:29 RT-N18U kern.info kernel: device eth1 entered promiscuous mode
Jan 1 01:00:29 RT-N18U kern.info kernel: br0: port 2(eth1) entering forwarding state
Jan 1 01:00:29 RT-N18U kern.info kernel: br0: port 2(eth1) entering forwarding state
Jan 1 01:00:30 RT-N18U kern.info kernel: ipt_account 0.1.21 : Piotr Gasidlo <quaker@barbara.eu.org>, http://code.google.com/p/ipt-account/
Jan 1 01:00:30 RT-N18U user.info rcheck[976]: Time not yet set. Only "all day, everyday" restrictions will be activated.
Jan 1 01:00:30 RT-N18U user.info preinit[1]: Asus RT-N18U: FreshTomato 2019.2 -Test2 K26ARM USB VPN-64K-NOSMP
Jan 1 01:00:31 RT-N18U user.info preinit[1]: samba daemon is started
Jan 1 01:00:35 RT-N18U daemon.err nmbd[924]: *****
Jan 1 01:00:35 RT-N18U daemon.err nmbd[924]: ...
... samba is comming up
...
Jan 1 01:00:49 RT-N18U user.info redial[919]: Redial: wan down. Reconnecting...
Jan 1 01:00:49 RT-N18U daemon.info dnsmasq[850]: exiting on receipt of SIGTERM
Jan 1 01:00:49 RT-N18U daemon.info dnsmasq[1021]: started, version 2.80-305ffb5 cachesize 4096
Fix for: LED_DIAG was/is always green regardless if you turn DIAG LED on or off
Now:
- Diag ON --> amber LED on and green LED off
- Diag OFF --> amber LED off and green LED on
LED Diag: color amber gpio 0 (active LOW)
LED Diag: color green gpio 2 (active LOW)
Add color logic for LED_WHITE (cosmetic):
- with wan-up switch Internet LED color from amber to green
WAN LED: color green gpio 3 (active LOW)
WAN LED: color amber gpio 1 (active LOW)
align to Freshtomato behaviour for R6400 / R7000 / R8000 and a little bit cosmetic
additional reference:
https://forum.openwrt.org/t/d-link-dir-868l-dir-880l-support/5738/5
Fix for: LED_DIAG was/is always green regardless if you turn DIAG LED on or off
Now:
- Diag ON --> amber LED on and green LED off
- Diag OFF --> amber LED off and green LED on
LED Diag: color amber gpio 3 (active LOW)
LED Diag: color green gpio 2 (active LOW)
align to Freshtomato behaviour for R6400 / R7000 / R8000 and a little bit cosmetic
additional reference:
https://github.com/torvalds/linux/blob/master/arch/arm/boot/dts/bcm4708-netgear-r6250.dts
Fix for: LED_DIAG was/is always green regardless if you turn DIAG LED on or off
Now:
- Diag ON --> amber LED on and green LED off
- Diag OFF --> amber LED off and green LED on
LED Diag: color amber gpio 3 (active LOW)
LED Diag: color green gpio 2 (active LOW)
align to Freshtomato behaviour for R6400 / R7000 / R8000 and a little bit cosmetic
additional reference:
https://github.com/torvalds/linux/blob/master/arch/arm/boot/dts/bcm4708-netgear-r6300-v2.dts
This reverts commit 94e828cd6e.
Problem: with that patch samba does not load/start up after boot / reboot
Hardware & Setup: RT-N18U with PPPoE, OpenVPN, miniupnpd, …
I can reproduce this every time (tested it like 10-15 times). If i start samba manually (via GUI or cmd line) everthing works after wanup.
The old start sequence does work always
Commit of tsynik: 1c1a825209
I think the early redial and exiting of dnsmasq is the problem at time ~ 01:00:29
Jan 1 01:00:28 RT-N18U user.info preinit[1]: samba daemon is started
Jan 1 01:00:28 RT-N18U user.info preinit[1]: Asus RT-N18U: FreshTomato 2019.2 -Test1 K26ARM USB VPN-64K-NOSMP
Jan 1 01:00:28 RT-N18U user.info preinit[1]: samba daemon is started
Jan 1 01:00:29 RT-N18U user.info redial[841]: Redial: wan down. Reconnecting...
Jan 1 01:00:29 RT-N18U daemon.info dnsmasq[955]: exiting on receipt of SIGTERM
Jan 1 01:00:29 RT-N18U daemon.info dnsmasq[1006]: started, version 2.80-305ffb5 cachesize 4096
without that patch redial and exiting of dnsmasq happens much later - at time ~ 01:00:49
samba does load/start properly
Jan 1 01:00:27 RT-N18U user.info preinit[1]: minidlna is stopped
Jan 1 01:00:27 RT-N18U user.info preinit[1]: vsftpd is stopped
Jan 1 01:00:27 RT-N18U user.info preinit[1]: samba daemon is stopped
Jan 1 01:00:27 RT-N18U kern.warn kernel: gro disabled
Jan 1 01:00:28 RT-N18U user.info preinit[1]: samba daemon is started
Jan 1 01:00:28 RT-N18U user.info preinit[1]: MultiWAN: MWAN is 1 (max 4)
Jan 1 01:00:28 RT-N18U daemon.info pppd[917]: Plugin rp-pppoe.so loaded.
Jan 1 01:00:28 RT-N18U daemon.info pppd[917]: RP-PPPoE plugin version 3.13 compiled against pppd 2.4.7
Jan 1 01:00:29 RT-N18U user.info redial[919]: Redial (wan) started, the check interval is 10 seconds
Jan 1 01:00:29 RT-N18U daemon.notice pppd[918]: pppd 2.4.7 started by root, uid 0
Jan 1 01:00:29 RT-N18U kern.info kernel: Ebtables v2.0 registered
Jan 1 01:00:29 RT-N18U kern.info kernel: device eth1 left promiscuous mode
Jan 1 01:00:29 RT-N18U kern.info kernel: br0: port 2(eth1) entering forwarding state
Jan 1 01:00:29 RT-N18U kern.info kernel: device eth1 entered promiscuous mode
Jan 1 01:00:29 RT-N18U kern.info kernel: br0: port 2(eth1) entering forwarding state
Jan 1 01:00:29 RT-N18U kern.info kernel: br0: port 2(eth1) entering forwarding state
Jan 1 01:00:30 RT-N18U kern.info kernel: ipt_account 0.1.21 : Piotr Gasidlo <quaker@barbara.eu.org>, http://code.google.com/p/ipt-account/
Jan 1 01:00:30 RT-N18U user.info rcheck[976]: Time not yet set. Only "all day, everyday" restrictions will be activated.
Jan 1 01:00:30 RT-N18U user.info preinit[1]: Asus RT-N18U: FreshTomato 2019.2 -Test2 K26ARM USB VPN-64K-NOSMP
Jan 1 01:00:31 RT-N18U user.info preinit[1]: samba daemon is started
Jan 1 01:00:35 RT-N18U daemon.err nmbd[924]: *****
Jan 1 01:00:35 RT-N18U daemon.err nmbd[924]: ...
... samba is comming up
...
Jan 1 01:00:49 RT-N18U user.info redial[919]: Redial: wan down. Reconnecting...
Jan 1 01:00:49 RT-N18U daemon.info dnsmasq[850]: exiting on receipt of SIGTERM
Jan 1 01:00:49 RT-N18U daemon.info dnsmasq[1021]: started, version 2.80-305ffb5 cachesize 4096
- reduces the amount of dropped packets on some setups, which will in turn improve performance.
- additionally replace &iface[0] references with straight iface, for better readability and reduced risk of errors
- reduces the amount of dropped packets on some setups, which will in turn improve performance.
- additionally replace &iface[0] references with straight iface, for better readability and reduced risk of errors
Fix for: LED_DIAG was always white regardless if you turn DIAG LED on or off
Now:
- Diag ON --> amber LED on and white LED off
- Diag OFF --> amber LED off and white LED on
LED Diag: color amber gpio 3 (active LOW)
LED Diag: color white gpio 2 (active LOW)
Fix for: LED_DIAG was always white regardless if you turn DIAG LED on or off
Now:
- Diag ON --> amber LED on and white LED off
- Diag OFF --> amber LED off and white LED on
LED Diag: color amber gpio 2 (active LOW)
LED Diag: color white gpio 1 (active LOW)
Fix for: LED_DIAG was always white regardless if you turn DIAG LED on or off
Now:
- Diag ON --> amber LED on and white LED off
- Diag OFF --> amber LED off and white LED on
LED Diag: color amber gpio 3 (active LOW)
LED Diag: color white gpio 2 (active LOW)
- abort on errors in subdir builds: 5e90783d11
The current recursive loops do not check the exit status of make
in subdirs which leads to `make` passing even when a subdir failed
to compile or install.
URL: https://bugs.gentoo.org/334727
Signed-off-by: Martin von Gagern <Martin.vGagern@gmx.net>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
- pppd: Fix sign-extension when displaying bytes in octal: 5e8c3cb256
print_string() displays characters as \\%.03o but without first
casting it from "char" to "unsigned char" so it gets sign-extended
to an int. This causes output like \37777777630 instead of \230.
Signed-off-by: Philip A. Prindeville <philipp@redfish-solutions.com>
- Suppress false error message on PPPoE disconnect: 219aac3b53
Once the kernel handles PPPoE PADTs correctly[1], a PADT triggered
disconnect will result in EALREADY when pppd tries to clear the session ID.
Simply ignore the error if, and only if, the error is EALREADY
[1] https://patchwork.ozlabs.org/patch/444717/
Signed-off-by: Simon Farnsworth <simon@farnz.org.uk>
- Send PADT on PPPoE disconnect: cd2c14f998
Once we've terminated the PPP session, there is no chance of a PPP layer
disconnect. Some PPPoE relays don't detect the PPP session going down, and
depend on a long timeout or a PPPoE PADT to terminate the session.
Send a PADT on disconnect to work around these buggy relays.
Signed-off-by: Simon Farnsworth <simon@farnz.org.uk>
- pppd: ipxcp: Prevent buffer overrun on remote router name: fe149de624
This fixes an if condition to prevent a possible 1-byte overrun
on ipxcp_hisoptions[0].name.
Reported-by: "Sabas Rosales, Blanca E" <blanca.e.sabas.rosales@intel.com>
Signed-off-by: Paul Mackerras <paulus@ozlabs.org>
- pppd: Fix ccp_cilen calculated size if both deflate_correct and deflate_draft are enabled: 094cb8ae4c
This fixes a bug where ccp_cilen() will return 4 bytes less than
necessary for the addci buffer if both deflate_correct and
deflate_draft are enabled.
Signed-off-by: Sylvain Rochet <gradator@gradator.net>
Signed-off-by: Paul Mackerras <paulus@samba.org>
- pppd: Remove unused declaration of ttyname: 66ae569f1c
Signed-off-by: George Burgess IV <george@gbiv.net>
- pppd: Fix printing call in print_option(): 3b409a8e29
print_option() was in this case passing p/opt->addr2 as the format string
instead of the string to be printed (as a quoted string). That could lead
to a nasty crash.
Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
Signed-off-by: Paul Mackerras <paulus@ozlabs.org>
- pppd: Don't try to free(NULL - 1): b5a2fd5ca2
A logic bug in update_script_environment() means that it can call
remove_script_env() even when the variable being removed is not
present in the script_env array. The result of that is that
remove_script_env() will call free() with argument NULL - 1.
To fix this, we avoid calling remove_script_env() in this case.
Signed-off-by: Paul Mackerras <paulus@ozlabs.org>
- Change include from sys/errno.h to errno.h: 56a4760236
According to POSIX, the canonical location for errno.h is on the top level.
Signed-off-by: Stefan Nickl <Stefan.Nickl@gmail.com>
- pppoe: include netinet/in.h before linux/in.h: 50a2997b25
This fixes builds with newer kernels. Basically, <netinet/in.h> needs to be
included before <linux/in.h> otherwise the earlier, unaware of the latter,
tries to redefine symbols and structures. Also, <linux/if_pppox.h> doesn't work
alone anymore, since it pulls the headers in the wrong order, so we better
include <netinet/in.h> early.
101-pppd-patches-from-wl500g.googlecode.com-project.patch
102-pppd-Fixes-from-upstream.patch
103-pppd-patches-from-upstream-fix-quote-handling-in.patch
104-pppd-chat-allow-timeout-value-to-come-from-environment.patch
105-pppd-typo-fix.patch
106-build-pppd-fix-passing-extracflags.patch
107-pppd-debian-patches.patch
108-pppd-always-create-a-new-process-group-debian-patch.patch
109-pppd-populate-gateway-of-default-route-with-peer-address-patch-from-OpenWRT.patch
110-pppd-openwrt-patches-to-reduce-size.patch
111-pptp-server-for-tomato.patch
112-ppp-single-line-mlppp-support.patch
- see inside every patch for more info about it
Fix for: LED_DIAG was always white regardless if you turn DIAG LED on or off
Now:
- Diag ON --> amber LED on and white LED off
- Diag OFF --> amber LED off and white LED on
LED Diag: color amber gpio 2 (active LOW)
LED Diag: color white gpio 1 (active LOW)
kille72
M_ars
pedro