Regression since 7.69.0 and 68fb25f.
The code wrongly assigned 'from' instead of 'auth' which probably was a
copy and paste mistake from other code, leading to that auth could
remain NULL and later cause an error to be returned.
Assisted-by: Eric Sauvageau
Fixes#5294Closes#5295
Fix from upstream: 446fb0518b
- cosmetic in router/Makefile regarding new library
NOTE: This commit requires at least Debian 10.x as the host for proper compilation; otherwise do a revert
Hint: for arm-master branch, arm-ng branch with extra commit (almost the same)
!!!IMPORTANT for the Upgrade!!!: select the new image and click/select "After flashing, erase all data in NVRAM memory"
basic testing done/ok, working so far :-)
!!!IMPORTANT for the Upgrade!!!: select the new image and click/select "After flashing, erase all data in NVRAM memory"
basic testing done with R7000 and RT-N18U, working so far :-)
The NCM specification defines two formats of transfer blocks: with 16-bit
fields (NTB-16) and with 32-bit fields (NTB-32). Currently only NTB-16 is
implemented.
This patch adds the support of NTB-32. The motivation behind this is that
some devices such as E5785 or E5885 from the current generation of Huawei
LTE routers do not support NTB-16. The previous generations of Huawei
devices are also use NTB-32 by default.
Also this patch enables NTB-32 by default for Huawei devices.
During the 2019 ValdikSS made five attempts to contact Huawei to add the
NTB-16 support to their router firmware, but they were unsuccessful.
Signed-off-by: Alexander Bersenev <bay@hackerdom.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>
0fa81b304a
The ndp32->wLength is two bytes long, so replace cpu_to_le32 with cpu_to_le16.
Fixes: 0fa81b3 ("cdc_ncm: Implement the 32-bit version of NCM Transfer Block")
Signed-off-by: Alexander Bersenev <bay@hackerdom.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>
5d0ab06b63
M_ars
pedro