From ec8241afa60a09d8ba067ee1caa38a899cd5a860 Mon Sep 17 00:00:00 2001 From: edrikk Date: Thu, 24 May 2018 01:13:44 +0000 Subject: [PATCH] Fix potential FILE * leak in nvram_commit --- release/src-rt-6.x.4708/router/nvram_arm/nvram_linux.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/release/src-rt-6.x.4708/router/nvram_arm/nvram_linux.c b/release/src-rt-6.x.4708/router/nvram_arm/nvram_linux.c index a8d503975d..9d7af7d083 100644 --- a/release/src-rt-6.x.4708/router/nvram_arm/nvram_linux.c +++ b/release/src-rt-6.x.4708/router/nvram_arm/nvram_linux.c @@ -2,11 +2,11 @@ * NVRAM variable manipulation (Linux user mode half) * * Copyright (C) 2012, Broadcom Corporation. All Rights Reserved. - * + * * Permission to use, copy, modify, and/or distribute this software for any * purpose with or without fee is hereby granted, provided that the above * copyright notice and this permission notice appear in all copies. - * + * * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY @@ -212,8 +212,10 @@ nvram_commit(void) fp = fopen("/var/log/commit_ret", "w"); - if ((ret = nvram_init(NULL))) + if ((ret = nvram_init(NULL))) { + fclose(fp); return ret; + } ret = ioctl(nvram_fd, NVRAM_MAGIC, NULL);