Merge pull request #861 from pangeachat/stack-overflow-fix

don't call messagesSinceUpdate from clearMessagesSinceUpdate repeatedly

lib/pangea/controllers/get_analytics_controller.dart

@@ -162,7 +162,8 @@ class GetAnalyticsController {
         return formattedCache;
       } catch (err) {
         // if something goes wrong while trying to format the local data, clear it
-        _pangeaController.myAnalytics.clearMessagesSinceUpdate();
+        _pangeaController.myAnalytics
+            .clearMessagesSinceUpdate(clearDrafts: true);
         return {};
       }
     } catch (exception, stackTrace) {

lib/pangea/controllers/my_analytics_controller.dart

@@ -243,7 +243,12 @@ class MyAnalyticsController extends BaseController<AnalyticsStream> {
   }
 
   /// Clears the local cache of recently sent constructs. Called before updating analytics
-  void clearMessagesSinceUpdate() {
+  void clearMessagesSinceUpdate({clearDrafts = false}) {
+    if (clearDrafts) {
+      _pangeaController.pStoreService.delete(PLocalKey.messagesSinceUpdate);
+      return;
+    }
+
     final localCache = _pangeaController.analytics.messagesSinceUpdate;
     final draftKeys = localCache.keys.where((key) => key.startsWith('draft'));
     if (draftKeys.isEmpty) {