From 7f9c0047fb5ac9c8d3e80fa56a26ef46a7d0818d Mon Sep 17 00:00:00 2001
From: William Jordan-Cooley <wcjord@gmail.com>
Date: Wed, 30 Oct 2024 15:22:34 -0400
Subject: [PATCH] no xp for ign, more minus xp for inc, dont show 0 xp
 constructs

---
 lib/pangea/enum/construct_use_type_enum.dart   |  8 ++++----
 .../analytics_summary/analytics_popup.dart     | 18 +++++++++++-------
 2 files changed, 15 insertions(+), 11 deletions(-)

diff --git a/lib/pangea/enum/construct_use_type_enum.dart b/lib/pangea/enum/construct_use_type_enum.dart
index 6ced270b7..196cf89b4 100644
--- a/lib/pangea/enum/construct_use_type_enum.dart
+++ b/lib/pangea/enum/construct_use_type_enum.dart
@@ -105,23 +105,23 @@ extension ConstructUseTypeExtension on ConstructUseTypeEnum {
         return 2;
 
       case ConstructUseTypeEnum.corIt:
+        return 1;
+
       case ConstructUseTypeEnum.ignIt:
       case ConstructUseTypeEnum.ignIGC:
       case ConstructUseTypeEnum.ignPA:
       case ConstructUseTypeEnum.ignWL:
-        return 1;
-
       case ConstructUseTypeEnum.unk:
       case ConstructUseTypeEnum.nan:
         return 0;
 
       case ConstructUseTypeEnum.incIt:
       case ConstructUseTypeEnum.incIGC:
-        return -1;
+        return -2;
 
       case ConstructUseTypeEnum.incPA:
       case ConstructUseTypeEnum.incWL:
-        return -2;
+        return -3;
     }
   }
 }
diff --git a/lib/pangea/widgets/chat_list/analytics_summary/analytics_popup.dart b/lib/pangea/widgets/chat_list/analytics_summary/analytics_popup.dart
index 9dcc7b06b..7f609ce11 100644
--- a/lib/pangea/widgets/chat_list/analytics_summary/analytics_popup.dart
+++ b/lib/pangea/widgets/chat_list/analytics_summary/analytics_popup.dart
@@ -16,6 +16,11 @@ class AnalyticsPopup extends StatelessWidget {
     super.key,
   });
 
+  // we just want to show the constructs that have points
+  List<ConstructUses> get constructs => constructsModel.constructList
+      .where((constructUse) => constructUse.points > 0)
+      .toList();
+
   @override
   Widget build(BuildContext context) {
     return Dialog(
@@ -36,16 +41,16 @@ class AnalyticsPopup extends StatelessWidget {
             ),
             body: Padding(
               padding: const EdgeInsets.symmetric(vertical: 20),
-              child: constructsModel.constructList.isEmpty
+              child: constructs.isEmpty
                   ? Center(
                       child: Text(L10n.of(context)!.noDataFound),
                     )
                   : ListView.builder(
-                      itemCount: constructsModel.constructList.length,
+                      itemCount: constructs.length,
                       itemBuilder: (context, index) {
                         return Tooltip(
                           message:
-                              "${constructsModel.constructList[index].points} / ${constructsModel.maxXPPerLemma}",
+                              "${constructs[index].points} / ${constructsModel.maxXPPerLemma}",
                           child: ListTile(
                             onTap: () {},
                             title: Text(
@@ -55,12 +60,11 @@ class AnalyticsPopup extends StatelessWidget {
                                           .constructList[index].lemma,
                                       context,
                                     )
-                                  : constructsModel.constructList[index].lemma,
+                                  : constructs[index].lemma,
                             ),
                             subtitle: LinearProgressIndicator(
-                              value:
-                                  constructsModel.constructList[index].points /
-                                      constructsModel.maxXPPerLemma,
+                              value: constructs[index].points /
+                                  constructsModel.maxXPPerLemma,
                               minHeight: 20,
                               borderRadius: const BorderRadius.all(
                                 Radius.circular(AppConfig.borderRadius),