Merge branch 'main' into save-new-space-avatar

lib/pages/chat_details/chat_details_view.dart

@@ -436,7 +436,9 @@ class ChatDetailsView extends StatelessWidget {
                               onTap: () =>
                                   context.go('/rooms/${room.id}/invite'),
                             ),
-                          if (room.showClassEditOptions && room.isSpace)
+                          if (room.showClassEditOptions &&
+                              room.isSpace &&
+                              !room.isSubspace)
                             SpaceDetailsToggleAddStudentsTile(
                               controller: controller,
                             ),

lib/pangea/extensions/pangea_room_extension/children_and_parents_extension.dart

@@ -1,6 +1,8 @@
 part of "pangea_room_extension.dart";
 
 extension ChildrenAndParentsRoomExtension on Room {
+  bool get _isSubspace => _pangeaSpaceParents.isNotEmpty;
+
   //note this only will return rooms that the user has joined or been invited to
   List<Room> get _joinedChildren {
     if (!isSpace) return [];
@@ -91,7 +93,7 @@ extension ChildrenAndParentsRoomExtension on Room {
   String _nameIncludingParents(BuildContext context) {
     String nameSoFar = getLocalizedDisplayname(MatrixLocals(L10n.of(context)!));
     Room currentRoom = this;
-    if (currentRoom.pangeaSpaceParents.isEmpty) {
+    if (!currentRoom._isSubspace) {
       return nameSoFar;
     }
     currentRoom = currentRoom.pangeaSpaceParents.first;
@@ -100,7 +102,7 @@ extension ChildrenAndParentsRoomExtension on Room {
     nameToAdd =
         nameToAdd.length <= 10 ? nameToAdd : "${nameToAdd.substring(0, 10)}...";
     nameSoFar = '$nameToAdd > $nameSoFar';
-    if (currentRoom.pangeaSpaceParents.isEmpty) {
+    if (!currentRoom._isSubspace) {
       return nameSoFar;
     }
     return "... > $nameSoFar";

lib/pangea/extensions/pangea_room_extension/pangea_room_extension.dart

@@ -122,6 +122,9 @@ extension PangeaRoom on Room {
   }) async =>
       await _pangeaSetSpaceChild(roomId, suggested: suggested);
 
+  /// Checks if this space has a parent space
+  bool get isSubspace => _isSubspace;
+
 // class_and_exchange_settings
 
   DateTime? get rulesUpdatedAt => _rulesUpdatedAt;