You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
25cf78395c
Some recent "improvements" to CheckLicense were buggy, at least partially because I did not increase test coverage when adding new code paths. This change fixes two known mistakes and greatly increases test coverage. One bug was that the code assumed that match.groups()[0] would always be the current year, but that assumption is invalid when a license regex is passed in. Another bug is that the new_license_re took away the possibility of the license ending with */ but that is used in .css files. The increased test coverage catches these and validates other assumptions around new files. The failures were reproduced and then the fixes validated using this command: vpython3 tests/presubmit_unittest.py Bug: 1098010 Change-Id: Ic91ca9f7a182660aef7b1eead79e841f58e15a3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4032366 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: Josip Sokcevic <sokcevic@google.com> |
2 years ago | |
|---|---|---|
| .. | ||
| gstools | ||
| OWNERS | 3 years ago | |
| PRESUBMIT.py | 3 years ago | |
| auth_test.py | 5 years ago | |
| autoninja_test.py | 3 years ago | |
| bot_update_coverage_test.py | 3 years ago | |
| cipd_bootstrap_test.py | 5 years ago | |
| detect_host_arch_test.py | 4 years ago | |
| download_from_google_storage_unittest.py | 3 years ago | |
| fetch_test.py | 3 years ago | |
| fix_encoding_test.py | 3 years ago | |
| gclient_cipd_smoketest.py | 3 years ago | |
| gclient_eval_unittest.py | 4 years ago | |
| gclient_git_mutates_smoketest.py | 4 years ago | |
| gclient_git_smoketest.py | 3 years ago | |
| gclient_no_sync_smoketest.py | 3 years ago | |
| gclient_paths_test.py | 5 years ago | |
| gclient_scm_test.py | 3 years ago | |
| gclient_smoketest.py | 5 years ago | |
| gclient_smoketest_base.py | 3 years ago | |
| gclient_test.py | 3 years ago | |
| gclient_transitions_smoketest.py | 5 years ago | |
| gclient_utils_test.py | 3 years ago | |
| gerrit_client_test.py | 4 years ago | |
| gerrit_util_test.py | 4 years ago | |
| git_cache_test.py | 5 years ago | |
| git_cl_creds_check_report.txt | 5 years ago | |
| git_cl_test.py | 2 years ago | |
| git_common_test.py | 3 years ago | |
| git_dates_test.py | 6 years ago | |
| git_find_releases_test.py | 3 years ago | |
| git_footers_test.py | 4 years ago | |
| git_hyper_blame_test.py | 5 years ago | |
| git_map_test.py | 4 years ago | |
| git_migrate_default_branch_test.py | 3 years ago | |
| git_number_test.py | 6 years ago | |
| git_rebase_update_test.py | 3 years ago | |
| gsutil_test.py | 4 years ago | |
| lockfile_test.py | 5 years ago | |
| metrics_test.py | 4 years ago | |
| my_activity_test.py | 4 years ago | |
| ninjalog_uploader_test.py | 3 years ago | |
| owners_client_test.py | 3 years ago | |
| owners_finder_test.py | 4 years ago | |
| presubmit_unittest.py | 2 years ago | |
| rdb_wrapper_test.py | 3 years ago | |
| recipes_test.py | 3 years ago | |
| roll_dep_test.py | 3 years ago | |
| scm_unittest.py | 4 years ago | |
| split_cl_test.py | 4 years ago | |
| subcommand_test.py | 3 years ago | |
| subprocess2_test.py | 3 years ago | |
| upload_to_google_storage_unittest.py | 4 years ago | |
| utils_test.py | 3 years ago | |
| watchlists_unittest.py | 5 years ago | |