You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Alexander Thomas 24996afd00 Revert "Reland "resolve CIPD package names in gclient"" ... This reverts commit d69302761b. Reason for revert: Broke Dart CI ``` gclient.py revinfo --output-json output.json --filter='https://chrome-infra-packages.appspot.com/dart/dart-sdk/${platform}' ``` No longer returns: ``` { "sdk/tools/sdks/dart-sdk:dart/dart-sdk/${platform}": { "rev": "git_revision:7a6514d1377175decd3a886fe4190fbbebddac3a", "url": "https://chrome-infra-packages.appspot.com/dart/dart-sdk/${platform}" } } ``` Bad build: https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/vm-aot-msan-linux-release-x64/90/overview Good build: https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/vm-aot-msan-linux-release-x64/89/overview Original change's description: > Reland "resolve CIPD package names in gclient" > > This CL relands the below CL with the addition of handling situations where the CIPD package name has a variable=value and does not equate to true. In this case just return the original value in DEPS. > > This is a reland of commit 8faa5514ec > > Original change's description: > > resolve CIPD package names in gclient > > > > Currently the package names are not resolved in gclient output, see example below. > > > > This is part of broader work to improve CIPD output, the next CL will replace 'None'. > > > > ``` > > $~ gclient revinfo -a | grep '${platform}\|${arch}' > > > > src/buildtools/linux64:gn/gn/linux-${arch}: None > > src/buildtools/reclient:infra/rbe/client/${platform}: None > > src/third_party/dawn/third_party/ninja:infra/3pp/tools/ninja/${platform}: None > > src/third_party/dawn/tools/golang:infra/3pp/tools/go/${platform}: None > > src/third_party/devtools-frontend-internal/devtools-frontend/third_party/esbuild:infra/3pp/tools/esbuild/${platform}: None > > src/third_party/devtools-frontend/src/third_party/esbuild:infra/3pp/tools/esbuild/${platform}: None > > src/third_party/ninja:infra/3pp/tools/ninja/${platform}: None > > src/tools/luci-go:infra/tools/luci/isolate/${platform}: None > > src/tools/luci-go:infra/tools/luci/swarming/${platform}: None > > src/tools/resultdb:infra/tools/result_adapter/${platform}: None > > ``` > > > > Bug:b/279097790 > > Change-Id: I21abf2579910e9d79d9ee0dcd018ee761e3d3c1c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4463983 > > Reviewed-by: Rachael Newitt <renewitt@google.com> > > Reviewed-by: Gavin Mak <gavinmak@google.com> > > Commit-Queue: Dan Le Febvre <dlf@google.com> > > Bug: b/279097790 > Change-Id: Ib08dac506ce221243c595dde5cb00e8e0d7dc7ed > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4501582 > Reviewed-by: Gavin Mak <gavinmak@google.com> > Commit-Queue: Dan Le Febvre <dlf@google.com> Bug: b/279097790 Change-Id: Ibf82354ac5005d9d6279d88aa99c8fb344aa6833 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4518113 Owners-Override: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Dan Le Febvre <dlf@google.com>		2 years ago
..
gstools	…
OWNERS	Move reclient cache dir to gclient root to avoid wipeout on gn clean	3 years ago
auth_test.py	…
autoninja_test.py	…
bot_update_coverage_test.py	…
cipd_bootstrap_test.py	…
detect_host_arch_test.py	…
download_from_google_storage_unittest.py	…
fetch_test.py	…
fix_encoding_test.py	Disable two encoding tests on Windows	3 years ago
gclient_cipd_smoketest.py	Revert "Reland "resolve CIPD package names in gclient""	2 years ago
gclient_eval_unittest.py	…
gclient_git_mutates_smoketest.py	…
gclient_git_smoketest.py	Revert "Reland "resolve CIPD package names in gclient""	2 years ago
gclient_no_sync_smoketest.py	…
gclient_paths_test.py	…
gclient_scm_test.py	Revert "Move scm.py to lib/"	3 years ago
gclient_smoketest.py	…
gclient_smoketest_base.py	…
gclient_test.py	Revert "Reland "resolve CIPD package names in gclient""	2 years ago
gclient_transitions_smoketest.py	Revert "Move scm.py to lib/"	3 years ago
gclient_utils_test.py	…
gerrit_client_test.py	…
gerrit_util_test.py	Apply the gerrit REST timeout to only 'GetChanges' calls	3 years ago
git_cache_test.py	…
git_cl_creds_check_report.txt	…
git_cl_test.py	[git-cl][presubmit] Remove references to LUCI_OMIT_PYTHON2.	2 years ago
git_common_test.py	…
git_dates_test.py	…
git_find_releases_test.py	…
git_footers_test.py	…
git_hyper_blame_test.py	…
git_map_test.py	…
git_migrate_default_branch_test.py	…
git_number_test.py	…
git_rebase_update_test.py	…
gsutil_test.py	…
lockfile_test.py	…
metrics_test.py	…
my_activity_test.py	…
ninja_reclient_test.py	Move reclient cache dir to gclient root to avoid wipeout on gn clean	3 years ago
ninjalog_uploader_test.py	[ninjalog_uploader] Exclude absolute paths and options from targets	3 years ago
owners_client_test.py	…
owners_finder_test.py	…
presubmit_canned_checks_test.py	Handle windows paths correctly in CheckInclusiveLanguage	3 years ago
presubmit_unittest.py	[git-cl][presubmit] Remove references to LUCI_OMIT_PYTHON2.	2 years ago
rdb_wrapper_test.py	…
recipes_test.py	…
roll_dep_test.py	…
scm_unittest.py	Revert "Move scm.py to lib/"	3 years ago
split_cl_test.py	…
subcommand_test.py	…
subprocess2_test.py	…
upload_to_google_storage_unittest.py	…
utils_test.py	Revert "Extract searching relevat files in utils function"	3 years ago
watchlists_unittest.py	…