You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
09c0c073ea
Some of the expensive checks when running presubmit --all, such as CheckStableMojomChanges (~300 s) and CheckAddedDepsHaveTargetApprovals (~200 s) only look at diffs and are therefore guaranteed to be NOPs when running presubmit --all or --files=. Passing along the no_diffs state lets these expensive checks be skipped, thus allowing for faster iteration times. Initial testing suggests that (with some supporting changes in the Chromium repo) this reduces "presubmit --all" times by about ten minutes, or a bit more than 10%, and additional improvements may be possible. Special handling for the no-diffs case also offers a simple way to avoid presubmit failures that happen whenever all files are flagged as being changed. Finally, and perhaps most importantly for having a presubmit --all bot, when --no_diffs is passed we can treat errors like "Issue wasn't uploaded" and "Add a description to the CL" as messages, thus making it possible to have zero presubmit errors when run on origin/main. Bug: 1320937, 1322936 Change-Id: I0d09dd4aae8fdaa48c8b2f89337441cf96dcff72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3628368 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: Gavin Mak <gavinmak@google.com> |
4 years ago | |
|---|---|---|
| .. | ||
| gstools | ||
| OWNERS | 4 years ago | |
| PRESUBMIT.py | 5 years ago | |
| auth_test.py | 6 years ago | |
| autoninja_test.py | 4 years ago | |
| bot_update_coverage_test.py | 4 years ago | |
| cipd_bootstrap_test.py | 6 years ago | |
| detect_host_arch_test.py | 5 years ago | |
| download_from_google_storage_unittest.py | 4 years ago | |
| fetch_test.py | 4 years ago | |
| fix_encoding_test.py | 4 years ago | |
| gclient_cipd_smoketest.py | 6 years ago | |
| gclient_eval_unittest.py | 5 years ago | |
| gclient_git_mutates_smoketest.py | 5 years ago | |
| gclient_git_smoketest.py | 4 years ago | |
| gclient_paths_test.py | 6 years ago | |
| gclient_scm_test.py | 4 years ago | |
| gclient_smoketest.py | 6 years ago | |
| gclient_smoketest_base.py | 4 years ago | |
| gclient_test.py | 4 years ago | |
| gclient_transitions_smoketest.py | 6 years ago | |
| gclient_utils_test.py | 5 years ago | |
| gerrit_client_test.py | 4 years ago | |
| gerrit_util_test.py | 5 years ago | |
| git_cache_test.py | 5 years ago | |
| git_cl_creds_check_report.txt | 5 years ago | |
| git_cl_test.py | 4 years ago | |
| git_common_test.py | 4 years ago | |
| git_dates_test.py | 6 years ago | |
| git_find_releases_test.py | 4 years ago | |
| git_footers_test.py | 4 years ago | |
| git_hyper_blame_test.py | 6 years ago | |
| git_map_test.py | 4 years ago | |
| git_migrate_default_branch_test.py | 4 years ago | |
| git_number_test.py | 6 years ago | |
| git_rebase_update_test.py | 4 years ago | |
| gsutil_test.py | 4 years ago | |
| lockfile_test.py | 6 years ago | |
| metrics_test.py | 4 years ago | |
| my_activity_test.py | 4 years ago | |
| ninjalog_uploader_test.py | 4 years ago | |
| owners_client_test.py | 5 years ago | |
| owners_finder_test.py | 5 years ago | |
| owners_unittest.py | 6 years ago | |
| presubmit_unittest.py | 4 years ago | |
| rdb_wrapper_test.py | 5 years ago | |
| recipes_test.py | 4 years ago | |
| roll_dep_test.py | 6 years ago | |
| scm_unittest.py | 4 years ago | |
| split_cl_test.py | 4 years ago | |
| subcommand_test.py | 6 years ago | |
| subprocess2_test.py | 4 years ago | |
| upload_to_google_storage_unittest.py | 4 years ago | |
| utils_test.py | 4 years ago | |
| watchlists_unittest.py | 6 years ago | |