You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
117 lines
3.9 KiB
Python
117 lines
3.9 KiB
Python
# Copyright (c) 2012 The Chromium Authors. All rights reserved.
|
|
# Use of this source code is governed by a BSD-style license that can be
|
|
# found in the LICENSE file.
|
|
|
|
"""Top-level presubmit script for depot tools.
|
|
|
|
See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
|
|
details on the presubmit API built into depot_tools.
|
|
"""
|
|
|
|
|
|
def CommonChecks(input_api, output_api, tests_to_black_list):
|
|
results = []
|
|
results.extend(input_api.canned_checks.CheckOwners(input_api, output_api))
|
|
black_list = list(input_api.DEFAULT_BLACK_LIST) + [
|
|
r'^cpplint\.py$',
|
|
r'^cpplint_chromium\.py$',
|
|
r'^python[0-9]*_bin[\/\\].+',
|
|
r'^site-packages-py[0-9]\.[0-9][\/\\].+',
|
|
r'^svn_bin[\/\\].+',
|
|
r'^testing_support[\/\\]_rietveld[\/\\].+']
|
|
disabled_warnings = [
|
|
'R0401', # Cyclic import
|
|
'W0613', # Unused argument
|
|
]
|
|
pylint = input_api.canned_checks.GetPylint(
|
|
input_api,
|
|
output_api,
|
|
white_list=[r'.*\.py$'],
|
|
black_list=black_list,
|
|
disabled_warnings=disabled_warnings)
|
|
# TODO(maruel): Make sure at least one file is modified first.
|
|
# TODO(maruel): If only tests are modified, only run them.
|
|
unit_tests = input_api.canned_checks.GetUnitTestsInDirectory(
|
|
input_api,
|
|
output_api,
|
|
'tests',
|
|
whitelist=[r'.*test\.py$'],
|
|
blacklist=tests_to_black_list)
|
|
tests = pylint
|
|
if not input_api.platform.startswith(('cygwin', 'win32')):
|
|
tests.extend(unit_tests)
|
|
else:
|
|
print('Warning: not running unit tests on Windows')
|
|
results.extend(input_api.RunTests(tests))
|
|
return results
|
|
|
|
|
|
def RunGitClTests(input_api, output_api):
|
|
"""Run all the shells scripts in the directory test.
|
|
"""
|
|
if input_api.platform == 'win32':
|
|
# Skip for now as long as the test scripts are bash scripts.
|
|
return []
|
|
|
|
# First loads a local Rietveld instance.
|
|
import sys
|
|
old_sys_path = sys.path
|
|
try:
|
|
sys.path = [input_api.PresubmitLocalPath()] + sys.path
|
|
from testing_support import local_rietveld
|
|
server = local_rietveld.LocalRietveld()
|
|
finally:
|
|
sys.path = old_sys_path
|
|
|
|
results = []
|
|
try:
|
|
# Start a local rietveld instance to test against.
|
|
server.start_server()
|
|
test_path = input_api.os_path.abspath(
|
|
input_api.os_path.join(input_api.PresubmitLocalPath(), 'tests'))
|
|
for test in input_api.os_listdir(test_path):
|
|
# test-lib.sh is not an actual test so it should not be run. The other
|
|
# tests are tests known to fail.
|
|
DISABLED_TESTS = (
|
|
'owners.sh', 'push-from-logs.sh', 'rename.sh', 'test-lib.sh')
|
|
if test in DISABLED_TESTS or not test.endswith('.sh'):
|
|
continue
|
|
|
|
print('Running %s' % test)
|
|
try:
|
|
if input_api.verbose:
|
|
input_api.subprocess.check_call(
|
|
[input_api.os_path.join(test_path, test)], cwd=test_path)
|
|
else:
|
|
input_api.subprocess.check_output(
|
|
[input_api.os_path.join(test_path, test)], cwd=test_path,
|
|
stderr=input_api.subprocess.STDOUT)
|
|
except (OSError, input_api.subprocess.CalledProcessError), e:
|
|
results.append(output_api.PresubmitError('%s failed\n%s' % (test, e)))
|
|
except local_rietveld.Failure, e:
|
|
results.append(output_api.PresubmitError('\n'.join(str(i) for i in e.args)))
|
|
finally:
|
|
server.stop_server()
|
|
return results
|
|
|
|
|
|
def CheckChangeOnUpload(input_api, output_api):
|
|
# Do not run integration tests on upload since they are way too slow.
|
|
tests_to_black_list = [
|
|
r'^checkout_test\.py$',
|
|
r'^gclient_smoketest\.py$',
|
|
r'^scm_unittest\.py$',
|
|
r'^subprocess2_test\.py$',
|
|
]
|
|
return CommonChecks(input_api, output_api, tests_to_black_list)
|
|
|
|
|
|
def CheckChangeOnCommit(input_api, output_api):
|
|
output = []
|
|
output.extend(CommonChecks(input_api, output_api, []))
|
|
output.extend(input_api.canned_checks.CheckDoNotSubmit(
|
|
input_api,
|
|
output_api))
|
|
output.extend(RunGitClTests(input_api, output_api))
|
|
return output
|