aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
main
chrome/4147
chrome/3987
chrome/3865
chrome/3904
infra/config
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'eeafa0eaec'
${ noResults }
depot_tools/tests
History
Bob Haarman eeafa0eaec Revert "gclient_utils: buffer output as bytestrings in Annotated" 
This reverts commit 5d284fdf48.

Reason for revert: breaks buildbots, crbug.com/1011982

Original change's description:
> gclient_utils: buffer output as bytestrings in Annotated
> 
> In Python 3 byestrings and normal strings can't be concatenated.
> To fix this we buffer as bytestrings in the Annotated wrapper.
> We can't decode to a string because the output might come byte-by-byte, so it doesn't work with Unicode characters like ✔.
> 
> Also had to update gclient_test.py, where double-wrapping stdout with Annotated caused made output not work and include_zero=True working caused other unintended side-effects.
> 
> Example error from "fetch chromium":
> Traceback (most recent call last):
>   File "C:\Google\depot_tools\gclient_scm.py", line 1045, in _Clone
>     self._Run(clone_cmd, options, cwd=self._root_dir, retry=True,
>   File "C:\Google\depot_tools\gclient_scm.py", line 1370, in _Run
>     gclient_utils.CheckCallAndFilter(cmd, env=env, **kwargs)
>   File "C:\Google\depot_tools\gclient_utils.py", line 583, in CheckCallAndFilter
>     show_header_if_necessary(needs_header, attempt)
>   File "C:\Google\depot_tools\gclient_utils.py", line 533, in show_header_if_necessary
>     stdout_write(header.encode())
>   File "C:\Google\depot_tools\gclient_utils.py", line 391, in write
>     obj[0] += out
> TypeError: can only concatenate str (not "bytes") to str
> 
> Bug: 984182
> Change-Id: If7037d30e9faf524f2405258281f6e6cd0bcdcae
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1778745
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Auto-Submit: Raul Tambre <raul@tambre.ee>

TBR=dpranke@chromium.org,ehmaldonado@chromium.org,raul@tambre.ee

Change-Id: I5ea8d3249c58a3487996649a264bb5be059fe884
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 984182
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1845500
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 		6 years ago
..
gstools
…
OWNERS [ninjalog_uploader] add tests 7 years ago
auth_test.py
…
bot_update_coverage_test.py Revert "Reland "depot_tools: Move six to depot_tools' .vpython"" 6 years ago
cipd_bootstrap_test.py [cipd] Add presubmit support for checking *.digests file. 7 years ago
download_from_google_storage_unittest.py Convert print statements to Python 3 style 7 years ago
fix_encoding_test.py Fix invalid Python file encoding "utf8" 7 years ago
gclient_eval_unittest.py Add support for multi argument ands and ors, and the same precedence with 6 years ago
gclient_scm_test.py tests/gclient_scm_test.py: Fix invalid escape sequences in regex strings 6 years ago
gclient_smoketest.py Make gclient.py warn on Python 3 6 years ago
gclient_test.py Revert "gclient_utils: buffer output as bytestrings in Annotated" 6 years ago
gclient_utils_test.py Revert "gclient_utils: buffer output as bytestrings in Annotated" 6 years ago
git_cache_test.py depot_tools: Run git_cache_test and git_dates_test on Python 3. 6 years ago
git_cl_creds_check_report.txt
…
git_cl_test.py git-cl: Clean-up 6 years ago
git_common_test.py depot_tools: Run git_common_test in Python 3 6 years ago
git_dates_test.py depot_tools: Run git_cache_test and git_dates_test on Python 3. 6 years ago
git_drover_test.py
…
git_footers_test.py depot_tools: Run git_footers_test on Python 3. 6 years ago
git_hyper_blame_test.py depot_tools: Run git_common_test in Python 3 6 years ago
git_number_test.py
…
git_rebase_update_test.py Revert "Fix semantics of git new-branch --upstream" 7 years ago
gsutil_test.py
…
metrics_test.py depot_tools: Run some tests on Python 3 on the bots. 6 years ago
ninjalog_uploader_test.py [ninjalog] fully anonymize build stats before sending 7 years ago
owners_finder_test.py
…
owners_unittest.py owners: add owners_rooted_at_file() 6 years ago
presubmit_unittest.py Make presubmit bark at FIXED= in CL description 6 years ago
recipes_test.py [recipes] Remove deprecated (ignored) --use-bootstrap flag 7 years ago
roll_dep_test.py roll-dep: Use gclient setdep/getdep. 7 years ago
scm_unittest.py depot_tools: Run some tests on Python 3 on the bots. 6 years ago
subprocess2_test.py depot_tools: Run some tests on Python 3 on the bots. 6 years ago
upload_to_google_storage_unittest.py Convert except statements to be Python 3 compatible 7 years ago
watchlists_unittest.py depot_tools: Make watchlist tests use mock and remove pymox. 6 years ago