Example error during "git cl upload":
Traceback (most recent call last):
  File "C:\Google\depot_tools\presubmit_support.py", line 220, in CallCommand
    returncode, stdout = self._RunWithTimeout(cmd, test.stdin, test.kwargs)
  File "C:\Google\depot_tools\presubmit_support.py", line 204, in _RunWithTimeout
    p = subprocess.Popen(cmd, **kwargs)
  File "C:\Google\depot_tools\subprocess2.py", line 143, in __init__
    super(Popen, self).__init__(args, **kwargs)
  File "C:\Google\depot_tools\bootstrap-3_8_0b1_chromium_1_bin\python\bin\Lib\subprocess.py", line 390, in __init__
    errread, errwrite)
  File "C:\Google\depot_tools\bootstrap-3_8_0b1_chromium_1_bin\python\bin\Lib\subprocess.py", line 640, in _execute_child
    startupinfo)
TypeError: environment can only contain strings
Bug: 984182
Change-Id: Id996d73a80845aaeaa061107ed123627091cb600
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1815872
Commit-Queue: Raul Tambre <raul@tambre.ee>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Raul Tambre <raul@tambre.ee>
						
					
				
			 | 
			6 years ago | |
|---|---|---|
| bootstrap | 6 years ago | |
| fetch_configs | 6 years ago | |
| git-templates | ||
| infra | 6 years ago | |
| man | 6 years ago | |
| python-bin | 6 years ago | |
| recipes | 6 years ago | |
| testing_support | 6 years ago | |
| tests | 6 years ago | |
| third_party | 6 years ago | |
| win_toolchain | 6 years ago | |
| zsh-goodies | ||
| .gitattributes | 6 years ago | |
| .gitignore | 6 years ago | |
| .style.yapf | 6 years ago | |
| .vpython | 6 years ago | |
| .vpython3 | 6 years ago | |
| CROS_OWNERS | 6 years ago | |
| LICENSE | ||
| OWNERS | 6 years ago | |
| PRESUBMIT.py | 6 years ago | |
| README.gclient.md | ||
| README.git-cl.md | 6 years ago | |
| README.md | 7 years ago | |
| WATCHLISTS | 6 years ago | |
| auth.py | 6 years ago | |
| autoninja | 6 years ago | |
| autoninja.bat | 6 years ago | |
| autoninja.py | 6 years ago | |
| bb | 7 years ago | |
| bb.bat | 7 years ago | |
| bootstrap_python3 | 6 years ago | |
| breakpad.py | ||
| cbuildbot | 6 years ago | |
| chrome_set_ver | 6 years ago | |
| cipd | 7 years ago | |
| cipd.bat | 7 years ago | |
| cipd.ps1 | 7 years ago | |
| cipd_bin_setup.bat | 6 years ago | |
| cipd_bin_setup.sh | 6 years ago | |
| cipd_client_version | 6 years ago | |
| cipd_client_version.digests | 6 years ago | |
| cipd_manifest.txt | 6 years ago | |
| cipd_manifest.versions | 6 years ago | |
| cit | 6 years ago | |
| cit.bat | 6 years ago | |
| cit.py | 6 years ago | |
| clang-format | ||
| clang-format.bat | ||
| clang_format.py | 7 years ago | |
| clang_format_merge_driver | ||
| clang_format_merge_driver.bat | ||
| clang_format_merge_driver.py | 7 years ago | |
| codereview.settings | ||
| compile_single_file | ||
| compile_single_file.bat | ||
| compile_single_file.py | 6 years ago | |
| cpplint.bat | ||
| cpplint.py | 6 years ago | |
| cpplint_chromium.py | ||
| cros | 6 years ago | |
| cros_sdk | 6 years ago | |
| crosjobs | 6 years ago | |
| dart_format.py | 7 years ago | |
| detect_host_arch.py | 6 years ago | |
| download_from_google_storage | 6 years ago | |
| download_from_google_storage.bat | 6 years ago | |
| download_from_google_storage.py | 6 years ago | |
| ensure_bootstrap | 6 years ago | |
| fetch | 6 years ago | |
| fetch.bat | 6 years ago | |
| fetch.py | 6 years ago | |
| fix_encoding.py | 6 years ago | |
| gclient | 6 years ago | |
| gclient-new-workdir.py | 6 years ago | |
| gclient.bat | 6 years ago | |
| gclient.py | 6 years ago | |
| gclient_completion.sh | ||
| gclient_eval.py | 6 years ago | |
| gclient_paths.py | 6 years ago | |
| gclient_scm.py | 6 years ago | |
| gclient_utils.py | 6 years ago | |
| gerrit_client.py | 6 years ago | |
| gerrit_util.py | 6 years ago | |
| git-cache | ||
| git-cl | ||
| git-crrev-parse | ||
| git-drover | ||
| git-find-releases | ||
| git-footers | ||
| git-freeze | ||
| git-gs | ||
| git-hyper-blame | ||
| git-map | 6 years ago | |
| git-map-branches | ||
| git-mark-merge-base | ||
| git-nav-downstream | ||
| git-nav-upstream | 7 years ago | |
| git-new-branch | ||
| git-number | ||
| git-rebase-update | ||
| git-rename-branch | ||
| git-reparent-branch | ||
| git-retry | ||
| git-runhooks | 6 years ago | |
| git-squash-branch | ||
| git-thaw | ||
| git-upstream-diff | ||
| git_cache.py | 6 years ago | |
| git_cl.py | 6 years ago | |
| git_cl_completion.sh | ||
| git_common.py | 6 years ago | |
| git_dates.py | ||
| git_drover.py | 6 years ago | |
| git_find_releases.py | 6 years ago | |
| git_footers.py | 6 years ago | |
| git_freezer.py | 6 years ago | |
| git_hyper_blame.py | 6 years ago | |
| git_map.py | 6 years ago | |
| git_map_branches.py | 6 years ago | |
| git_mark_merge_base.py | 6 years ago | |
| git_nav_downstream.py | 6 years ago | |
| git_new_branch.py | 6 years ago | |
| git_number.py | 6 years ago | |
| git_rebase_update.py | 6 years ago | |
| git_rename_branch.py | 6 years ago | |
| git_reparent_branch.py | 6 years ago | |
| git_retry.py | 6 years ago | |
| git_squash_branch.py | 6 years ago | |
| git_upstream_diff.py | 6 years ago | |
| gn | ||
| gn.bat | ||
| gn.py | 7 years ago | |
| goma_auth | 6 years ago | |
| goma_auth.bat | 6 years ago | |
| goma_ctl | 6 years ago | |
| goma_ctl.bat | 6 years ago | |
| gsutil.py | 6 years ago | |
| gsutil.py.bat | 7 years ago | |
| gsutil.vpython | 6 years ago | |
| led | 7 years ago | |
| led.bat | ||
| luci-auth | 7 years ago | |
| luci-auth.bat | ||
| lucicfg | 7 years ago | |
| lucicfg.bat | 7 years ago | |
| mac_toolchain | 7 years ago | |
| metrics.README.md | 6 years ago | |
| metrics.py | 6 years ago | |
| metrics_utils.py | 6 years ago | |
| my_activity.py | 6 years ago | |
| ninja | 6 years ago | |
| ninja-linux32 | ||
| ninja-linux64 | ||
| ninja-mac | ||
| ninja.exe | ||
| ninjalog.README.md | 7 years ago | |
| ninjalog_uploader.py | 6 years ago | |
| ninjalog_uploader_wrapper.py | 6 years ago | |
| owners.py | 6 years ago | |
| owners_finder.py | 6 years ago | |
| post_build_ninja_summary.py | 6 years ago | |
| presubmit_canned_checks.py | 6 years ago | |
| presubmit_support.py | 6 years ago | |
| profile.xml | ||
| prpc | 7 years ago | |
| prpc.bat | ||
| pylint | 6 years ago | |
| pylint-1.5 | 6 years ago | |
| pylint-1.6 | 6 years ago | |
| pylint-1.7 | 6 years ago | |
| pylint-1.8 | 6 years ago | |
| pylint-1.9 | 6 years ago | |
| pylint.bat | 6 years ago | |
| pylint_main.py | 6 years ago | |
| pylintrc | 6 years ago | |
| python_runner.sh | 6 years ago | |
| repo | 6 years ago | |
| roll-dep | 6 years ago | |
| roll-dep.bat | 6 years ago | |
| roll_dep.py | 6 years ago | |
| scm.py | 6 years ago | |
| setup_color.py | 6 years ago | |
| split_cl.py | 6 years ago | |
| subcommand.py | 6 years ago | |
| subprocess2.py | 6 years ago | |
| update_depot_tools | 6 years ago | |
| update_depot_tools.bat | 6 years ago | |
| update_depot_tools_toggle.py | ||
| upload_metrics.py | 6 years ago | |
| upload_to_google_storage.py | 6 years ago | |
| vpython | 6 years ago | |
| vpython.bat | 6 years ago | |
| vpython3 | 6 years ago | |
| vpython3.bat | 6 years ago | |
| watchlists.py | 6 years ago | |
| weekly | 7 years ago | |
| wtf | 7 years ago | |
| yapf | 7 years ago | |
| yapf.bat | 7 years ago | |
		
			
				
				README.md
			
		
		
			
			
		
	
	depot_tools
Tools for working with Chromium development. It requires python 2.7.
Tools
The most important tools are:
fetch: Agclientwrapper to checkout a project. Usefetch --helpfor more details.gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Usegclient helpfor more details and README.gclient.md.git cl: A code review tool to interact with Rietveld or Gerrit. Usegit cl helpfor more details and README.git-cl.md.roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.
There are a lot of git utilities included.
Updating
depot_tools updates itself automatically when running gclient tool. To
disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0.
To update package manually, run update_depot_tools.bat on Windows,
or ./update_depot_tools on Linux or Mac.
On Windows only, running gclient will install git and python.
Contributing
To contribute change for review:
git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>
# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail
# Edit change description if needed.
git cl desc
# If change is approved, flag it to be committed.
git cl set-commit
# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
cpplint.py
Until 2018, our cpplint.py was a copy of the upstream version at
https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that
repository is not maintained any more.
If you want to update cpplint.py in depot_tools, just upload a patch to do
so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py here is also used by the Tricium
analyzer,
so if the cpplint.py here changes, we should also update the copy used there.