aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
main
chrome/4147
chrome/3987
chrome/3865
chrome/3904
infra/config
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'e8703543e3'
${ noResults }
depot_tools/tests
History
Robert Iannucci 5025893cb6 [presubmit_support] Prevent depot_tools' virtualenv from leaking into other repos. 
Currently in LUCI `git cl` is invoked on chromium_presubmit using vpython. This
means that it operates under the depot_tools .vpython environment (which is
blank).

Some features in presubmit_support allow invocation of python subprocesses, and
previously they would use `sys.executable` (especially on windows, but
occasionally on non-windows as well).

In non-vpython environments, this just picks up the system python and whatever
modules happen to be installed there. Some python unittests work around this on
non-windows systems by having a shebang line which explicitly invokes vpython.

This CL changes presubmit_support so that invocations of 'python', or executions
of '.py' scripts will always end up invoking vpython. In the best case, this will
pick up the invoked scripts' vpython environment. In the worst case, this will
invoke the script under an empty vpython environment (aka "stock python").

R=dpranke@chromium.org, jbudorick@chromium.org, tandrii@chromium.org, tikuta@chromium.org

Bug: 821669
Change-Id: I5d2d5dfd0364022d56833c2c8af4983553a29c7a
Reviewed-on: https://chromium-review.googlesource.com/961865
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
 		7 years ago
..
gstools
…
auth_test.py [depot_tools] Fix timestamp issues related to local auth 8 years ago
bot_update_coverage_test.py [bot_update] Remove support for rietveld patches. 7 years ago
checkout_test.py Revert "Fix checkout.py issues when p.patchlevel > 1." 8 years ago
download_from_google_storage_unittest.py download_from_google_storage: allow normal files with .. 7 years ago
fix_encoding_test.py
…
gclient_eval_unittest.py gclient eval: Get rid of global_scope, local_scope and functions other than Var. 7 years ago
gclient_scm_test.py gclient sync: Add support to apply gerrit refs. 7 years ago
gclient_smoketest.py gclient sync: Add support to apply gerrit refs. 7 years ago
gclient_test.py gclient sync: Add support to apply gerrit refs. 7 years ago
gclient_utils_test.py gclient: Stop printing newline in front of "________ running hook" 8 years ago
git_cache_test.py
…
git_cl_creds_check_report.txt git cl creds-check: improve report and give better recommendation. 8 years ago
git_cl_test.py [git_cl] Remove rietveld CMDland implementation. 7 years ago
git_common_test.py git_test_utils: Fixed custom git metadata in git commit schemas. 7 years ago
git_dates_test.py
…
git_drover_test.py Reland "Use core.quotePath=false when git is listing files" 8 years ago
git_footers_test.py Let git_footers split final paragraphs in specific cases 8 years ago
git_hyper_blame_test.py Update git_hyper_blame_test for git 2.16 7 years ago
git_number_test.py
…
git_rebase_update_test.py
…
gsutil_test.py download_from_google_storage: Fix tests and rename 8 years ago
owners_finder_test.py Skip files owned by reviewers when quering for missing owners. 7 years ago
owners_unittest.py Also check override files before checking the fs 8 years ago
patch_test.py
…
presubmit_unittest.py [presubmit_support] Prevent depot_tools' virtualenv from leaking into other repos. 7 years ago
recipes_test.py
…
scm_unittest.py Correct Git show's path format on Windows 8 years ago
subprocess2_test.py
…
upload_to_google_storage_unittest.py tests: Use the right clean up method name for some test cases. 8 years ago
watchlists_unittest.py
…