You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 
 
 
Go to file
Bruce Dawson e6bbb3a237 Avoid redundant global presubmit checks
PanProjectChecks is called twice, once from the root PRESUBMIT.py and
once from third_party/blink/PRESUBMIT.py. For the file-based checks a
series of filters avoids redundant reporting, but certain global checks
were being run twice, potentially causing duplicate reporting.

This adds an optional global_checks flag which can be set to false in
the blink PRESUBMIT.

Bug: 1309977
Change-Id: Ia43a7a0f29cf7b58ac9bab0e9aa374e9bf0155a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3611409
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Jesse McKenna <jessemckenna@google.com>
4 years ago
bootstrap git 2.35.1.chromium.8 to depot_tools stable. 4 years ago
fetch_configs
git-templates
infra Roll recipe dependencies (trivial). 4 years ago
man
python-bin
python2-bin
recipes Roll recipe dependencies (trivial). 4 years ago
testing_support Explicitly run everything with python3 4 years ago
tests autoninja: add simple test 4 years ago
third_party
win_toolchain Remove scottmg from OWNERS 4 years ago
zsh-goodies
.cipd_impl.ps1
.gitattributes Reland "Update gsutil to use gsutil version 4.68" 4 years ago
.gitignore
.style.yapf
.vpython
.vpython3
CROS_OWNERS
DIR_METADATA
GOMA_OWNERS
LICENSE
LUCI_OWNERS
OWNERS Add brucedawson@ as presubmit*.py OWNER 4 years ago
PRESUBMIT.py autoninja: add simple test 4 years ago
README.gclient.md
README.git-cl.md
README.md Indicate py3 compatibility for update_depot_tools_toggle.py 4 years ago
WATCHLISTS
auth.py
autoninja [autoninja] Respect user-provided AUTONINJA_BUILD_ID 4 years ago
autoninja.bat [autoninja] Respect user-provided AUTONINJA_BUILD_ID on Windows 4 years ago
autoninja.py autoninja: add simple test 4 years ago
bb
bb.bat
bootstrap_python3
breakpad.py
cbuildbot
cipd [cipd] Detect Mac ARM running under Rosetta 4 years ago
cipd.bat
cipd_bin_setup.bat
cipd_bin_setup.sh
cipd_client_version
cipd_client_version.digests
cipd_manifest.txt Update Pinpoint CLI - support attempts arg 4 years ago
cipd_manifest.versions Update Pinpoint CLI - support attempts arg 4 years ago
cit
cit.bat
cit.py
clang-format
clang-format.bat
clang_format.py
clang_format_merge_driver
clang_format_merge_driver.bat
clang_format_merge_driver.py
codereview.settings
compile_single_file
compile_single_file.bat
compile_single_file.py
cpplint.bat
cpplint.py Improve git cl presubmit --all output 4 years ago
cpplint_chromium.py
cros
cros_sdk
crosjobs
detect_host_arch.py Explicitly run everything with python3 4 years ago
dirmd
dirmd.bat
download_from_google_storage
download_from_google_storage.bat
download_from_google_storage.py
ensure_bootstrap Use python3 for gsutil bootstrapping 4 years ago
fetch
fetch.bat
fetch.py Explicitly run everything with python3 4 years ago
fix_encoding.py Fix \r\r\n line endings in presubmit output 4 years ago
gclient Skip depot_tools update for gclient recurse 4 years ago
gclient-new-workdir.py Explicitly run everything with python3 4 years ago
gclient.bat
gclient.py Fix vpython3 version mismatch error 4 years ago
gclient_completion.sh
gclient_eval.py
gclient_paths.py
gclient_scm.py Fix host and repo parsing for download-topics 4 years ago
gclient_utils.py
gerrit_client.py
gerrit_util.py
git-cache
git-cl
git-crrev-parse
git-drover
git-find-releases
git-footers
git-freeze
git-gs Add *.ts (typescript files) to git-gs 4 years ago
git-hyper-blame
git-map
git-map-branches
git-mark-merge-base
git-migrate-default-branch
git-nav-downstream
git-nav-upstream
git-new-branch
git-number
git-rebase-update
git-rename-branch
git-reparent-branch
git-retry
git-runhooks
git-squash-branch
git-thaw
git-upstream-diff
git_cache.py Explicitly run everything with python3 4 years ago
git_cl.py Make swift-format default True on Mac hosts 4 years ago
git_cl_completion.sh
git_common.py
git_dates.py
git_drover.py Explicitly run everything with python3 4 years ago
git_find_releases.py Explicitly run everything with python3 4 years ago
git_footers.py Explicitly run everything with python3 4 years ago
git_freezer.py Explicitly run everything with python3 4 years ago
git_hyper_blame.py Explicitly run everything with python3 4 years ago
git_map.py Explicitly run everything with python3 4 years ago
git_map_branches.py Explicitly run everything with python3 4 years ago
git_mark_merge_base.py Explicitly run everything with python3 4 years ago
git_migrate_default_branch.py
git_nav_downstream.py Explicitly run everything with python3 4 years ago
git_new_branch.py Explicitly run everything with python3 4 years ago
git_number.py
git_rebase_update.py Make the "mark branch dormant" instructions simpler to copy+paste. 4 years ago
git_rename_branch.py Explicitly run everything with python3 4 years ago
git_reparent_branch.py Explicitly run everything with python3 4 years ago
git_retry.py Explicitly run everything with python3 4 years ago
git_squash_branch.py Explicitly run everything with python3 4 years ago
git_upstream_diff.py Explicitly run everything with python3 4 years ago
gn
gn.bat
gn.py
goma_auth
goma_auth.bat Set errorlevel in .bat wrappers on exit /b where appropriate. 4 years ago
goma_ctl
goma_ctl.bat Set errorlevel in .bat wrappers on exit /b where appropriate. 4 years ago
gsutil.py Reland "Update gsutil to use gsutil version 4.68" 4 years ago
gsutil.py.bat Use python3 for gsutil bootstrapping 4 years ago
gsutil.vpython3 Reland "Update gsutil to use gsutil version 4.68" 4 years ago
led
led.bat
lockfile.py
luci-auth
luci-auth.bat
lucicfg
lucicfg.bat
mac_toolchain
metrics.README.md
metrics.py Explicitly run everything with python3 4 years ago
metrics_utils.py Explicitly run everything with python3 4 years ago
my_activity.py
ninja Drop ninja-linux32 4 years ago
ninja-linux64
ninja-mac
ninja.exe
ninjalog.README.md
ninjalog_uploader.py [ninjalog uploader] Collect more android GN args 4 years ago
ninjalog_uploader_wrapper.py ninjalog_uploader_wrapper.py: handle broken config file 4 years ago
owners.py
owners_client.py
owners_finder.py
pinpoint
pinpoint.bat
post_build_ninja_summary.py
presubmit_canned_checks.py Avoid redundant global presubmit checks 4 years ago
presubmit_canned_checks_test.py Explicitly run everything with python3 4 years ago
presubmit_canned_checks_test_mocks.py
presubmit_support.py Handle mixed slash types in FilterSourceFile 4 years ago
profile.xml
prpc
prpc.bat
pylint
pylint-1.5
pylint-1.5.bat
pylint-2.6
pylint-2.6.bat
pylint-2.7
pylint-2.7.bat
pylint.bat
pylint_main.py Explicitly run everything with python3 4 years ago
pylintrc
python_runner.sh
rdb
rdb.bat
rdb_wrapper.py Explicitly run everything with python3 4 years ago
repo
repo_launcher Explicitly run everything with python3 4 years ago
roll-dep
roll-dep.bat
roll_dep.py Explicitly run everything with python3 4 years ago
rustfmt.py
scm.py
setup_color.py Explicitly run everything with python3 4 years ago
split_cl.py Explicitly run everything with python3 4 years ago
subcommand.py
subprocess2.py
swift-format Support git cl formatting for swift files 4 years ago
swift_format.py Make swift-format default True on Mac hosts 4 years ago
update_depot_tools Print updating depot_tools in stderr 4 years ago
update_depot_tools.bat Set errorlevel in .bat wrappers on exit /b where appropriate. 4 years ago
update_depot_tools_toggle.py Indicate py3 compatibility for update_depot_tools_toggle.py 4 years ago
upload_metrics.py
upload_to_google_storage.py Explicitly run everything with python3 4 years ago
utils.py Add a basic depot_tools version information 4 years ago
vpython
vpython.bat Revert "Add VPYTHON_BYPASS support for vpython on Windows" 4 years ago
vpython3
vpython3.bat The python3 bin directory no longer needs to be added to PATH. 4 years ago
watchlists.py Explicitly run everything with python3 4 years ago
weekly Explicitly run everything with python3 4 years ago
whitespace.txt
win32imports.py
wtf Explicitly run everything with python3 4 years ago
yapf
yapf.bat

README.md

depot_tools

Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.

Tools

The most important tools are:

  • fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.
  • gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.
  • git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.
  • roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.

There are a lot of git utilities included.

Updating

depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0 or run ./update_depot_tools_toggle.py --disable.

To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

On Windows only, running gclient will install git and python.

Contributing

To contribute change for review:

git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>

# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail

# Edit change description if needed.
git cl desc

# If change is approved, flag it to be committed.
git cl set-commit

# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"

See also open bugs, open reviews, forum or report problems.

cpplint.py

Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.

Note that the cpplint.py here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.