You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
8e57b4bc55
Ran: vi $(git grep --name-only iteritems | grep -v third_party) vi $(git grep --name-only itervalues | grep -v third_party) vi $(git grep --name-only 'print ' | grep -v third_party) and edited the files quickly with adhoc macros. Then ran in recipes/: ./recipes.py test train There was only a small subset of files that had been updated to use six.iteritems() and six.itervalues(). Since the dataset size that is being used in gclient is small (pretty much always below 200 items), it's better to just switch to .items() right away and take the temporary performance hit, so that we don't need to come back to rewrite the code. Recipe-Nontrivial-Roll: build Bug: 984182 Change-Id: I5faf11486b66b0d73c9098ab0f2ce1b15a45c53e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1854900 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Auto-Submit: Marc-Antoine Ruel <maruel@chromium.org> |
6 years ago | |
|---|---|---|
| .. | ||
| bot_update | 6 years ago | |
| cipd | 6 years ago | |
| depot_tools | 6 years ago | |
| gclient | 6 years ago | |
| gerrit | 6 years ago | |
| git | 6 years ago | |
| git_cl | 6 years ago | |
| gitiles | 6 years ago | |
| gsutil | 6 years ago | |
| infra_paths | 6 years ago | |
| osx_sdk | 6 years ago | |
| presubmit | 6 years ago | |
| tryserver | 6 years ago | |
| windows_sdk | 6 years ago | |
| OWNERS | ||