You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
seems to take an inordinate amount of time. The idea is to lint whole files, and only try to compute deltas if the file contains at least one error. For my environment, the three affected presubmit rules took 2000ms each for a 4-file changelist. With this change, all my rules run in about a second, and none take anything close to 500ms. Also, since there seem to be environment-dependent factors at work here, I'm proposing putting timer warnings that print a message if any check takes longer than 500ms. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82559 Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=82568 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82607 Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=82653 Review URL: http://codereview.chromium.org/6883050 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@82762 0039d316-1c4b-4281-b951-d872f2087c98 |
14 years ago | |
---|---|---|
bootstrap | 14 years ago | |
git_cl | 14 years ago | |
tests | 14 years ago | |
third_party | 14 years ago | |
zsh-goodies | 15 years ago | |
.gitignore | 14 years ago | |
LICENSE | 16 years ago | |
OWNERS | 14 years ago | |
PRESUBMIT.py | 14 years ago | |
README | 15 years ago | |
README.codereview | 14 years ago | |
README.gclient | 16 years ago | |
README.git-cl | 14 years ago | |
README.testing | 14 years ago | |
WATCHLISTS | 14 years ago | |
apply_issue.py | 14 years ago | |
breakpad.py | 15 years ago | |
checkout.py | 14 years ago | |
chrome-update-create-task.bat | 15 years ago | |
chrome-update.bat | 15 years ago | |
chrome-update.py | 14 years ago | |
chromite | 14 years ago | |
codereview.settings | 15 years ago | |
cpplint.bat | 16 years ago | |
cpplint.py | 15 years ago | |
create-chromium-git-src | 15 years ago | |
drover | 15 years ago | |
drover.bat | 16 years ago | |
drover.py | 14 years ago | |
fix_encoding.py | 14 years ago | |
gcl | 14 years ago | |
gcl.bat | 16 years ago | |
gcl.py | 14 years ago | |
gclient | 14 years ago | |
gclient.bat | 16 years ago | |
gclient.py | 14 years ago | |
gclient_scm.py | 14 years ago | |
gclient_utils.py | 14 years ago | |
git-cl | 14 years ago | |
git-cl-upload-hook | 14 years ago | |
git-gs | 15 years ago | |
git-try | 15 years ago | |
git_cl.py | 14 years ago | |
hammer | 16 years ago | |
hammer.bat | 16 years ago | |
owners.py | 14 years ago | |
patch.py | 14 years ago | |
presubmit_canned_checks.py | 14 years ago | |
presubmit_support.py | 14 years ago | |
profile.xml | 16 years ago | |
pylintrc | 14 years ago | |
repo | 14 years ago | |
rietveld.py | 14 years ago | |
scm.py | 14 years ago | |
subprocess2.py | 14 years ago | |
trychange.py | 14 years ago | |
update_depot_tools | 14 years ago | |
watchlists.py | 14 years ago | |
weekly | 15 years ago | |
wtf | 15 years ago |
README
This package contains tools for working with Chromium development. The "gclient" wrapper knows how to keep this repository updated to the latest versions of these tools as found at: http://src.chromium.org/svn/trunk/tools/depot_tools This package contains: chrome-update-create-task.bat Creates a scheduled task to do an automatic local chromium build every day. cpplint.py A copy of our linting tool which enforces Google style. Fetched from http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py gcl A tool for uploading and managing code reviews on the Chromium project, using the Rietveld code review tool. More info at: http://code.google.com/p/rietveld/ gclient A script for managing a workspace with modular dependencies that are each checked out independently from different repositories. More info at: http://code.google.com/p/gclient/ hammer A wrapper script for building Chromium with the SCons software construction tool. More info at: http://www.scons.org/ Note: svn and python will be installed automatically if not accessible (on Windows only). To update this distribution manually, run bootstrap\gclient.bat on Windows, or bootstrap/gclient.sh on Linux or Mac. To disable automatic updating, set the environment variable DEPOT_TOOLS_UPDATE=0