You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Go to file

Bruce Dawson d895d01ac4 Report more issues as errors with presubmit --all Change crrev.com/c/3788227 fixed one instance of errors being treated as warnings when running "git cl presubmit" with the --upload option. This is undesirable when testing "git cl presubmit" with --all or --files, because it makes the errors harder to find. This change fixes four more newly discovered instances of this behavior. That is, this change makes it so that pylint issues and other serious problems will be reported as errors when running: git cl presubmit --force --all --upload This will make the pylint errors that this command triggers easier to find and fix: git cl presubmit --force --upload --files mojo\public\tools\bindings\*.py This change does _not_ turn cpplint warnings into errors, even though they are errors when running non-upload presubmits. That is because there are several directories that only run cpplint on upload and these directories have many errors and there is no short-term path to changing this. Bug: 1309977 Change-Id: If49f820fc6894dcd1d9aaaf4d932b04f79922bc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3791744 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: Jesse McKenna <jessemckenna@google.com>		4 years ago
bootstrap	…
fetch_configs	…
git-templates	…
infra	Roll recipe dependencies (trivial).	4 years ago
man	…
python-bin	…
python2-bin	…
recipes	[no-sync] bot_update: Remove previous no-sync exp changes and implement new one.	4 years ago
testing_support	…
tests	[no-sync] bot_update: Remove previous no-sync exp changes and implement new one.	4 years ago
third_party	…
win_toolchain	Use python3 for cpplint and get_toolchain on Win	4 years ago
zsh-goodies	…
.cipd_impl.ps1	…
.gitattributes	…
.gitignore	…
.isort.cfg	…
.style.yapf	…
.vpython	…
.vpython3	…
CROS_OWNERS	…
DIR_METADATA	…
GOMA_OWNERS	…
LICENSE	…
LUCI_OWNERS	…
OWNERS	…
PRESUBMIT.py	…
README.gclient.md	…
README.git-cl.md	…
README.md	…
WATCHLISTS	…
auth.py	…
autoninja	…
autoninja.bat	…
autoninja.py	…
bb	…
bb.bat	…
black	…
bootstrap_python3	…
breakpad.py	…
cbuildbot	…
cipd	…
cipd.bat	…
cipd_bin_setup.bat	…
cipd_bin_setup.sh	…
cipd_client_version	…
cipd_client_version.digests	…
cipd_manifest.txt	Update lucicfg version 1.32.0 to 1.32.1	4 years ago
cipd_manifest.versions	Update lucicfg version 1.32.0 to 1.32.1	4 years ago
cit	…
cit.bat	…
cit.py	…
clang-format	…
clang-format.bat	…
clang_format.py	…
clang_format_merge_driver	…
clang_format_merge_driver.bat	…
clang_format_merge_driver.py	…
codereview.settings	…
compile_single_file	…
compile_single_file.bat	…
compile_single_file.py	…
cpplint.bat	…
cpplint.py	…
cpplint_chromium.py	…
cros	…
cros_sdk	…
crosjobs	…
detect_host_arch.py	…
dirmd	…
dirmd.bat	…
download_from_google_storage	…
download_from_google_storage.bat	…
download_from_google_storage.py	…
ensure_bootstrap	…
fetch	…
fetch.bat	…
fetch.py	…
fix_encoding.py	…
gclient	…
gclient-new-workdir.py	…
gclient.bat	…
gclient.py	[no-sync] Save previous values to files.	4 years ago
gclient_completion.sh	…
gclient_eval.py	…
gclient_paths.py	…
gclient_scm.py	…
gclient_utils.py	…
gerrit_client.py	…
gerrit_util.py	…
git-cache	…
git-cl	…
git-crrev-parse	…
git-drover	…
git-find-releases	…
git-footers	…
git-freeze	…
git-gs	…
git-hyper-blame	…
git-map	…
git-map-branches	…
git-mark-merge-base	…
git-migrate-default-branch	…
git-nav-downstream	…
git-nav-upstream	…
git-new-branch	…
git-number	…
git-rebase-update	…
git-rename-branch	…
git-reparent-branch	…
git-retry	…
git-runhooks	…
git-squash-branch	…
git-thaw	…
git-upstream-diff	…
git_cache.py	…
git_cl.py	…
git_cl_completion.sh	…
git_common.py	…
git_dates.py	…
git_drover.py	…
git_find_releases.py	…
git_footers.py	…
git_freezer.py	…
git_hyper_blame.py	…
git_map.py	…
git_map_branches.py	…
git_mark_merge_base.py	…
git_migrate_default_branch.py	…
git_nav_downstream.py	…
git_new_branch.py	…
git_number.py	…
git_rebase_update.py	…
git_rename_branch.py	…
git_reparent_branch.py	…
git_retry.py	…
git_squash_branch.py	…
git_upstream_diff.py	…
gn	…
gn.bat	…
gn.py	…
goma_auth	…
goma_auth.bat	…
goma_ctl	…
goma_ctl.bat	…
gsutil.py	…
gsutil.py.bat	…
gsutil.vpython3	…
isort	…
led	…
led.bat	…
lockfile.py	…
luci-auth	…
luci-auth.bat	…
lucicfg	…
lucicfg.bat	…
mac_toolchain	…
metrics.README.md	…
metrics.py	…
metrics_utils.py	…
my_activity.py	…
ninja	…
ninja-linux64	…
ninja-mac	…
ninja.exe	…
ninjalog.README.md	…
ninjalog_uploader.py	…
ninjalog_uploader_wrapper.py	…
owners.py	…
owners_client.py	…
owners_finder.py	…
pinpoint	…
pinpoint.bat	…
post_build_ninja_summary.py	…
presubmit_canned_checks.py	Report more issues as errors with presubmit --all	4 years ago
presubmit_canned_checks_test.py	…
presubmit_canned_checks_test_mocks.py	…
presubmit_support.py	…
profile.xml	…
prpc	…
prpc.bat	…
pylint-1.5	…
pylint-1.5.bat	…
pylint-2.6	…
pylint-2.6.bat	…
pylint-2.7	…
pylint-2.7.bat	…
pylint_main.py	…
pylintrc	…
python_runner.sh	…
rdb	…
rdb.bat	…
rdb_wrapper.py	…
repo	…
repo_launcher	…
roll-dep	…
roll-dep.bat	…
roll_dep.py	…
rustfmt.py	…
scm.py	…
setup_color.py	…
split_cl.py	…
subcommand.py	…
subprocess2.py	…
swift-format	…
swift_format.py	…
update_depot_tools	…
update_depot_tools.bat	…
update_depot_tools_toggle.py	…
upload_metrics.py	…
upload_to_google_storage.py	…
utils.py	…
vpython	…
vpython.bat	…
vpython3	…
vpython3.bat	…
watchlists.py	…
weekly	…
whitespace.txt	…
win32imports.py	…
wtf	…
yapf	…
yapf.bat	…

README.md

depot_tools

Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.

Tools

The most important tools are:

fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.
gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.
git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.
roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.

There are a lot of git utilities included.

Updating

depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0 or run ./update_depot_tools_toggle.py --disable.

To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

On Windows only, running gclient will install git and python.

Contributing

To contribute change for review:

git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>

# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail

# Edit change description if needed.
git cl desc

# If change is approved, flag it to be committed.
git cl set-commit

# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"

See also open bugs, open reviews, forum or report problems.

cpplint.py

Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.

Note that the cpplint.py here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.