Change crrev.com/c/3788227 fixed one instance of errors being treated as warnings when running "git cl presubmit" with the --upload option. This is undesirable when testing "git cl presubmit" with --all or --files, because it makes the errors harder to find. This change fixes four more newly discovered instances of this behavior. That is, this change makes it so that pylint issues and other serious problems will be reported as errors when running: git cl presubmit --force --all --upload This will make the pylint errors that this command triggers easier to find and fix: git cl presubmit --force --upload --files mojo\public\tools\bindings\*.py This change does _not_ turn cpplint warnings into errors, even though they are errors when running non-upload presubmits. That is because there are several directories that only run cpplint on upload and these directories have many errors and there is no short-term path to changing this. Bug: 1309977 Change-Id: If49f820fc6894dcd1d9aaaf4d932b04f79922bc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3791744 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: Jesse McKenna <jessemckenna@google.com> |
3 years ago | |
---|---|---|
bootstrap | 3 years ago | |
fetch_configs | 3 years ago | |
git-templates | ||
infra | 3 years ago | |
man | 4 years ago | |
python-bin | 4 years ago | |
python2-bin | 4 years ago | |
recipes | 3 years ago | |
testing_support | 3 years ago | |
tests | 3 years ago | |
third_party | 3 years ago | |
win_toolchain | 3 years ago | |
zsh-goodies | ||
.cipd_impl.ps1 | 4 years ago | |
.gitattributes | 3 years ago | |
.gitignore | 3 years ago | |
.isort.cfg | 3 years ago | |
.style.yapf | 5 years ago | |
.vpython | 4 years ago | |
.vpython3 | 3 years ago | |
CROS_OWNERS | 4 years ago | |
DIR_METADATA | 4 years ago | |
GOMA_OWNERS | 4 years ago | |
LICENSE | ||
LUCI_OWNERS | 4 years ago | |
OWNERS | 3 years ago | |
PRESUBMIT.py | 3 years ago | |
README.gclient.md | ||
README.git-cl.md | 4 years ago | |
README.md | 3 years ago | |
WATCHLISTS | 3 years ago | |
auth.py | 4 years ago | |
autoninja | 3 years ago | |
autoninja.bat | 3 years ago | |
autoninja.py | 3 years ago | |
bb | 4 years ago | |
bb.bat | 4 years ago | |
black | 3 years ago | |
bootstrap_python3 | 4 years ago | |
breakpad.py | ||
cbuildbot | 6 years ago | |
cipd | 3 years ago | |
cipd.bat | 5 years ago | |
cipd_bin_setup.bat | 3 years ago | |
cipd_bin_setup.sh | 6 years ago | |
cipd_client_version | 3 years ago | |
cipd_client_version.digests | 3 years ago | |
cipd_manifest.txt | 3 years ago | |
cipd_manifest.versions | 3 years ago | |
cit | 4 years ago | |
cit.bat | 4 years ago | |
cit.py | 3 years ago | |
clang-format | 4 years ago | |
clang-format.bat | 4 years ago | |
clang_format.py | 4 years ago | |
clang_format_merge_driver | 4 years ago | |
clang_format_merge_driver.bat | 4 years ago | |
clang_format_merge_driver.py | 3 years ago | |
codereview.settings | 4 years ago | |
compile_single_file | 4 years ago | |
compile_single_file.bat | 4 years ago | |
compile_single_file.py | 3 years ago | |
cpplint.bat | 3 years ago | |
cpplint.py | 3 years ago | |
cpplint_chromium.py | ||
cros | 5 years ago | |
cros_sdk | 6 years ago | |
crosjobs | 4 years ago | |
detect_host_arch.py | 3 years ago | |
dirmd | 4 years ago | |
dirmd.bat | 4 years ago | |
download_from_google_storage | 4 years ago | |
download_from_google_storage.bat | 3 years ago | |
download_from_google_storage.py | 3 years ago | |
ensure_bootstrap | 3 years ago | |
fetch | 5 years ago | |
fetch.bat | 3 years ago | |
fetch.py | 3 years ago | |
fix_encoding.py | 3 years ago | |
gclient | 3 years ago | |
gclient-new-workdir.py | 3 years ago | |
gclient.bat | 3 years ago | |
gclient.py | 3 years ago | |
gclient_completion.sh | ||
gclient_eval.py | 3 years ago | |
gclient_paths.py | 4 years ago | |
gclient_scm.py | 3 years ago | |
gclient_utils.py | 3 years ago | |
gerrit_client.py | 3 years ago | |
gerrit_util.py | 3 years ago | |
git-cache | 5 years ago | |
git-cl | 5 years ago | |
git-crrev-parse | 4 years ago | |
git-drover | 5 years ago | |
git-find-releases | 5 years ago | |
git-footers | 5 years ago | |
git-freeze | 5 years ago | |
git-gs | 3 years ago | |
git-hyper-blame | 5 years ago | |
git-map | 5 years ago | |
git-map-branches | 5 years ago | |
git-mark-merge-base | 5 years ago | |
git-migrate-default-branch | 5 years ago | |
git-nav-downstream | 5 years ago | |
git-nav-upstream | 6 years ago | |
git-new-branch | 5 years ago | |
git-number | 5 years ago | |
git-rebase-update | 5 years ago | |
git-rename-branch | 5 years ago | |
git-reparent-branch | 5 years ago | |
git-retry | 5 years ago | |
git-runhooks | 3 years ago | |
git-squash-branch | 5 years ago | |
git-thaw | 5 years ago | |
git-upstream-diff | 5 years ago | |
git_cache.py | 3 years ago | |
git_cl.py | 3 years ago | |
git_cl_completion.sh | 5 years ago | |
git_common.py | 3 years ago | |
git_dates.py | ||
git_drover.py | 3 years ago | |
git_find_releases.py | 3 years ago | |
git_footers.py | 3 years ago | |
git_freezer.py | 3 years ago | |
git_hyper_blame.py | 3 years ago | |
git_map.py | 3 years ago | |
git_map_branches.py | 3 years ago | |
git_mark_merge_base.py | 3 years ago | |
git_migrate_default_branch.py | 4 years ago | |
git_nav_downstream.py | 3 years ago | |
git_new_branch.py | 3 years ago | |
git_number.py | 3 years ago | |
git_rebase_update.py | 3 years ago | |
git_rename_branch.py | 3 years ago | |
git_reparent_branch.py | 3 years ago | |
git_retry.py | 3 years ago | |
git_squash_branch.py | 3 years ago | |
git_upstream_diff.py | 3 years ago | |
gn | 4 years ago | |
gn.bat | 4 years ago | |
gn.py | 3 years ago | |
goma_auth | 4 years ago | |
goma_auth.bat | 3 years ago | |
goma_ctl | 4 years ago | |
goma_ctl.bat | 3 years ago | |
gsutil.py | 3 years ago | |
gsutil.py.bat | 3 years ago | |
gsutil.vpython3 | 3 years ago | |
isort | 3 years ago | |
led | 4 years ago | |
led.bat | 4 years ago | |
lockfile.py | 5 years ago | |
luci-auth | 4 years ago | |
luci-auth.bat | 4 years ago | |
lucicfg | 4 years ago | |
lucicfg.bat | 4 years ago | |
mac_toolchain | 6 years ago | |
metrics.README.md | 4 years ago | |
metrics.py | 3 years ago | |
metrics_utils.py | 3 years ago | |
my_activity.py | 3 years ago | |
ninja | 3 years ago | |
ninja-linux64 | 3 years ago | |
ninja-mac | 3 years ago | |
ninja.exe | 3 years ago | |
ninjalog.README.md | 3 years ago | |
ninjalog_uploader.py | 3 years ago | |
ninjalog_uploader_wrapper.py | 3 years ago | |
owners.py | 4 years ago | |
owners_client.py | 4 years ago | |
owners_finder.py | 3 years ago | |
pinpoint | 4 years ago | |
pinpoint.bat | 4 years ago | |
post_build_ninja_summary.py | 4 years ago | |
presubmit_canned_checks.py | 3 years ago | |
presubmit_canned_checks_test.py | 3 years ago | |
presubmit_canned_checks_test_mocks.py | 3 years ago | |
presubmit_support.py | 3 years ago | |
profile.xml | ||
prpc | 4 years ago | |
prpc.bat | 4 years ago | |
pylint-1.5 | 3 years ago | |
pylint-1.5.bat | 4 years ago | |
pylint-2.6 | 3 years ago | |
pylint-2.6.bat | 4 years ago | |
pylint-2.7 | 3 years ago | |
pylint-2.7.bat | 4 years ago | |
pylint_main.py | 3 years ago | |
pylintrc | 5 years ago | |
python_runner.sh | 5 years ago | |
rdb | 4 years ago | |
rdb.bat | 4 years ago | |
rdb_wrapper.py | 3 years ago | |
repo | 4 years ago | |
repo_launcher | 3 years ago | |
roll-dep | 5 years ago | |
roll-dep.bat | 5 years ago | |
roll_dep.py | 3 years ago | |
rustfmt.py | 4 years ago | |
scm.py | 3 years ago | |
setup_color.py | 3 years ago | |
split_cl.py | 3 years ago | |
subcommand.py | 3 years ago | |
subprocess2.py | 4 years ago | |
swift-format | 3 years ago | |
swift_format.py | 3 years ago | |
update_depot_tools | 3 years ago | |
update_depot_tools.bat | 3 years ago | |
update_depot_tools_toggle.py | 3 years ago | |
upload_metrics.py | 3 years ago | |
upload_to_google_storage.py | 3 years ago | |
utils.py | 3 years ago | |
vpython | 3 years ago | |
vpython.bat | 3 years ago | |
vpython3 | 5 years ago | |
vpython3.bat | 3 years ago | |
watchlists.py | 3 years ago | |
weekly | 3 years ago | |
whitespace.txt | 4 years ago | |
win32imports.py | 5 years ago | |
wtf | 3 years ago | |
yapf | 3 years ago | |
yapf.bat | 4 years ago |
README.md
depot_tools
Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.
Tools
The most important tools are:
fetch
: Agclient
wrapper to checkout a project. Usefetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Usegclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Usegit cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.
There are a lot of git utilities included.
Updating
depot_tools
updates itself automatically when running gclient
tool. To
disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
or
run ./update_depot_tools_toggle.py --disable
.
To update package manually, run update_depot_tools.bat
on Windows,
or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
Contributing
To contribute change for review:
git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>
# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail
# Edit change description if needed.
git cl desc
# If change is approved, flag it to be committed.
git cl set-commit
# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
cpplint.py
Until 2018, our cpplint.py
was a copy of the upstream version at
https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that
repository is not maintained any more.
If you want to update cpplint.py
in depot_tools
, just upload a patch to do
so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py
here is also used by the Tricium
analyzer,
so if the cpplint.py here changes, we should also update the copy used there.