vpython3.bat adds an entry to the path. Unfortunately that modification
persists after the batch file returns. Repeated running of vpython3.bat
will eventually grow the path so long that the command to update the
path exceeds the 8191 character cmd.exe command-length limit. This can
most easily be seen by repeatedly running this command:
vpython3 -c "print('Hello world!')" && set path | wc
After about 35 invocations (dependent on exact system setup) this
happens:
>vpython3 -c "print('Hello world!')" && set path | wc
The input line is too long.
The syntax of the command is incorrect.
This batch also (but less critically) leaks the PYTHON3_BIN_RELDIR
environment variable.
The fix is to add a setlocal command to keep environment changes local.
Bug: 1003139
Change-Id: I11a31e1013017da702299bfe8eb4888985c228f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3566378
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Brian Ryner <bryner@google.com>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
|
4 years ago | |
|---|---|---|
| bootstrap | 4 years ago | |
| fetch_configs | 4 years ago | |
| git-templates | ||
| infra | 4 years ago | |
| man | 4 years ago | |
| python-bin | 5 years ago | |
| python2-bin | 5 years ago | |
| recipes | 4 years ago | |
| testing_support | 4 years ago | |
| tests | 4 years ago | |
| third_party | 4 years ago | |
| win_toolchain | 4 years ago | |
| zsh-goodies | ||
| .cipd_impl.ps1 | 5 years ago | |
| .gitattributes | 4 years ago | |
| .gitignore | 5 years ago | |
| .style.yapf | ||
| .vpython | 4 years ago | |
| .vpython3 | 4 years ago | |
| CROS_OWNERS | 5 years ago | |
| DIR_METADATA | 5 years ago | |
| GOMA_OWNERS | 4 years ago | |
| LICENSE | ||
| LUCI_OWNERS | 4 years ago | |
| OWNERS | 4 years ago | |
| PRESUBMIT.py | 4 years ago | |
| README.gclient.md | ||
| README.git-cl.md | 5 years ago | |
| README.md | 4 years ago | |
| WATCHLISTS | 4 years ago | |
| auth.py | 5 years ago | |
| autoninja | 5 years ago | |
| autoninja.bat | 4 years ago | |
| autoninja.py | 4 years ago | |
| bb | 5 years ago | |
| bb.bat | 5 years ago | |
| bootstrap_python3 | 5 years ago | |
| breakpad.py | ||
| cbuildbot | ||
| cipd | 5 years ago | |
| cipd.bat | 6 years ago | |
| cipd_bin_setup.bat | ||
| cipd_bin_setup.sh | ||
| cipd_client_version | 4 years ago | |
| cipd_client_version.digests | 4 years ago | |
| cipd_manifest.txt | 4 years ago | |
| cipd_manifest.versions | 4 years ago | |
| cit | 5 years ago | |
| cit.bat | 5 years ago | |
| cit.py | 4 years ago | |
| clang-format | 5 years ago | |
| clang-format.bat | 5 years ago | |
| clang_format.py | 5 years ago | |
| clang_format_merge_driver | 5 years ago | |
| clang_format_merge_driver.bat | 5 years ago | |
| clang_format_merge_driver.py | 4 years ago | |
| codereview.settings | 5 years ago | |
| compile_single_file | 5 years ago | |
| compile_single_file.bat | 5 years ago | |
| compile_single_file.py | 4 years ago | |
| cpplint.bat | ||
| cpplint.py | 4 years ago | |
| cpplint_chromium.py | ||
| cros | 6 years ago | |
| cros_sdk | ||
| crosjobs | 5 years ago | |
| detect_host_arch.py | 4 years ago | |
| dirmd | 5 years ago | |
| dirmd.bat | 5 years ago | |
| download_from_google_storage | 5 years ago | |
| download_from_google_storage.bat | 5 years ago | |
| download_from_google_storage.py | 4 years ago | |
| ensure_bootstrap | 4 years ago | |
| fetch | 6 years ago | |
| fetch.bat | 6 years ago | |
| fetch.py | 4 years ago | |
| fix_encoding.py | 5 years ago | |
| gclient | 4 years ago | |
| gclient-new-workdir.py | 4 years ago | |
| gclient.bat | 6 years ago | |
| gclient.py | 4 years ago | |
| gclient_completion.sh | ||
| gclient_eval.py | 4 years ago | |
| gclient_paths.py | 5 years ago | |
| gclient_scm.py | 4 years ago | |
| gclient_utils.py | 4 years ago | |
| gerrit_client.py | 4 years ago | |
| gerrit_util.py | 4 years ago | |
| git-cache | 6 years ago | |
| git-cl | ||
| git-crrev-parse | 4 years ago | |
| git-drover | 6 years ago | |
| git-find-releases | 6 years ago | |
| git-footers | 6 years ago | |
| git-freeze | 6 years ago | |
| git-gs | 4 years ago | |
| git-hyper-blame | 6 years ago | |
| git-map | 6 years ago | |
| git-map-branches | 6 years ago | |
| git-mark-merge-base | 6 years ago | |
| git-migrate-default-branch | 5 years ago | |
| git-nav-downstream | 6 years ago | |
| git-nav-upstream | ||
| git-new-branch | 6 years ago | |
| git-number | 6 years ago | |
| git-rebase-update | 6 years ago | |
| git-rename-branch | 6 years ago | |
| git-reparent-branch | 6 years ago | |
| git-retry | 6 years ago | |
| git-runhooks | 4 years ago | |
| git-squash-branch | 6 years ago | |
| git-thaw | 6 years ago | |
| git-upstream-diff | 6 years ago | |
| git_cache.py | 4 years ago | |
| git_cl.py | 4 years ago | |
| git_cl_completion.sh | 6 years ago | |
| git_common.py | 4 years ago | |
| git_dates.py | ||
| git_drover.py | 4 years ago | |
| git_find_releases.py | 4 years ago | |
| git_footers.py | 4 years ago | |
| git_freezer.py | 4 years ago | |
| git_hyper_blame.py | 4 years ago | |
| git_map.py | 4 years ago | |
| git_map_branches.py | 4 years ago | |
| git_mark_merge_base.py | 4 years ago | |
| git_migrate_default_branch.py | 4 years ago | |
| git_nav_downstream.py | 4 years ago | |
| git_new_branch.py | 4 years ago | |
| git_number.py | 4 years ago | |
| git_rebase_update.py | 4 years ago | |
| git_rename_branch.py | 4 years ago | |
| git_reparent_branch.py | 4 years ago | |
| git_retry.py | 4 years ago | |
| git_squash_branch.py | 4 years ago | |
| git_upstream_diff.py | 4 years ago | |
| gn | 4 years ago | |
| gn.bat | 4 years ago | |
| gn.py | 4 years ago | |
| goma_auth | 5 years ago | |
| goma_auth.bat | 4 years ago | |
| goma_ctl | 5 years ago | |
| goma_ctl.bat | 4 years ago | |
| gsutil.py | 4 years ago | |
| gsutil.py.bat | 6 years ago | |
| gsutil.vpython3 | 4 years ago | |
| led | 5 years ago | |
| led.bat | 5 years ago | |
| lockfile.py | 6 years ago | |
| luci-auth | 5 years ago | |
| luci-auth.bat | 5 years ago | |
| lucicfg | 5 years ago | |
| lucicfg.bat | 5 years ago | |
| mac_toolchain | ||
| metrics.README.md | 5 years ago | |
| metrics.py | 4 years ago | |
| metrics_utils.py | 4 years ago | |
| my_activity.py | 4 years ago | |
| ninja | ||
| ninja-linux32 | ||
| ninja-linux64 | ||
| ninja-mac | 5 years ago | |
| ninja.exe | ||
| ninjalog.README.md | 4 years ago | |
| ninjalog_uploader.py | 4 years ago | |
| ninjalog_uploader_wrapper.py | 4 years ago | |
| owners.py | 5 years ago | |
| owners_client.py | 5 years ago | |
| owners_finder.py | 4 years ago | |
| pinpoint | 5 years ago | |
| pinpoint.bat | 5 years ago | |
| post_build_ninja_summary.py | 5 years ago | |
| presubmit_canned_checks.py | 4 years ago | |
| presubmit_canned_checks_test.py | 4 years ago | |
| presubmit_canned_checks_test_mocks.py | 4 years ago | |
| presubmit_support.py | 4 years ago | |
| profile.xml | ||
| prpc | 5 years ago | |
| prpc.bat | 5 years ago | |
| pylint | ||
| pylint-1.5 | 4 years ago | |
| pylint-1.5.bat | 5 years ago | |
| pylint-2.6 | 4 years ago | |
| pylint-2.6.bat | 5 years ago | |
| pylint-2.7 | 4 years ago | |
| pylint-2.7.bat | 4 years ago | |
| pylint.bat | ||
| pylint_main.py | 4 years ago | |
| pylintrc | 6 years ago | |
| python_runner.sh | 6 years ago | |
| rdb | 5 years ago | |
| rdb.bat | 5 years ago | |
| rdb_wrapper.py | 4 years ago | |
| repo | 5 years ago | |
| repo_launcher | 4 years ago | |
| roll-dep | 6 years ago | |
| roll-dep.bat | 6 years ago | |
| roll_dep.py | 4 years ago | |
| rustfmt.py | 4 years ago | |
| scm.py | 4 years ago | |
| setup_color.py | 4 years ago | |
| split_cl.py | 4 years ago | |
| subcommand.py | 4 years ago | |
| subprocess2.py | 5 years ago | |
| update_depot_tools | 4 years ago | |
| update_depot_tools.bat | 4 years ago | |
| update_depot_tools_toggle.py | 4 years ago | |
| upload_metrics.py | 5 years ago | |
| upload_to_google_storage.py | 4 years ago | |
| utils.py | 4 years ago | |
| vpython | 5 years ago | |
| vpython.bat | 4 years ago | |
| vpython3 | 6 years ago | |
| vpython3.bat | 4 years ago | |
| watchlists.py | 4 years ago | |
| weekly | 4 years ago | |
| whitespace.txt | 5 years ago | |
| win32imports.py | 6 years ago | |
| wtf | 4 years ago | |
| yapf | 4 years ago | |
| yapf.bat | 5 years ago | |
README.md
depot_tools
Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.
Tools
The most important tools are:
fetch: Agclientwrapper to checkout a project. Usefetch --helpfor more details.gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Usegclient helpfor more details and README.gclient.md.git cl: A code review tool to interact with Rietveld or Gerrit. Usegit cl helpfor more details and README.git-cl.md.roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.
There are a lot of git utilities included.
Updating
depot_tools updates itself automatically when running gclient tool. To
disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0 or
run ./update_depot_tools_toggle.py --disable.
To update package manually, run update_depot_tools.bat on Windows,
or ./update_depot_tools on Linux or Mac.
On Windows only, running gclient will install git and python.
Contributing
To contribute change for review:
git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>
# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail
# Edit change description if needed.
git cl desc
# If change is approved, flag it to be committed.
git cl set-commit
# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
cpplint.py
Until 2018, our cpplint.py was a copy of the upstream version at
https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that
repository is not maintained any more.
If you want to update cpplint.py in depot_tools, just upload a patch to do
so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py here is also used by the Tricium
analyzer,
so if the cpplint.py here changes, we should also update the copy used there.